From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web08.12477.1614098693631237828 for ; Tue, 23 Feb 2021 08:44:54 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MkxYAaSR; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614098692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tNlodLCjVw651wLRJ+wy+3FhaoOpn/Aul9UbAzlufvs=; b=MkxYAaSRRG5yd2EYp+8gFdv2ItiSJx9H3Nv6OwcyR+qE6NHImovWEiP8JcYA3u/YZZ8aG0 mCgbAlNfaXrCN+/3C/xM03hTT/hby4cm6QzPHwgVXvYuNnhXt7K3A4lMbtvpMugC1Yt2EL lEhbmjMkynIid7ZulYVMIEO9DljOK/k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-216-zyRnSHpxOtaYrJEW4XkfkA-1; Tue, 23 Feb 2021 11:44:51 -0500 X-MC-Unique: zyRnSHpxOtaYrJEW4XkfkA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 93B1A106BC69; Tue, 23 Feb 2021 16:44:49 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-109.ams2.redhat.com [10.36.113.109]) by smtp.corp.redhat.com (Postfix) with ESMTP id D324610016F7; Tue, 23 Feb 2021 16:44:47 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v8 02/10] OvmfPkg/CpuHotplugSmm: collect hot-unplug events To: Ankur Arora , devel@edk2.groups.io Cc: imammedo@redhat.com, boris.ostrovsky@oracle.com, Jordan Justen , Ard Biesheuvel , Aaron Young References: <20210222071928.1401820-1-ankur.a.arora@oracle.com> <20210222071928.1401820-3-ankur.a.arora@oracle.com> <90b4d42f-20fd-b04c-cdf1-774fa19c1052@redhat.com> <1fc423a8-1230-bcc9-2544-bdec8cd682bf@oracle.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 23 Feb 2021 17:44:46 +0100 MIME-Version: 1.0 In-Reply-To: <1fc423a8-1230-bcc9-2544-bdec8cd682bf@oracle.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 02/22/21 23:03, Ankur Arora wrote: > On 2021-02-22 4:27 a.m., Laszlo Ersek wrote: >> On 02/22/21 08:19, Ankur Arora wrote: >>> diff --git a/OvmfPkg/CpuHotplugSmm/QemuCpuhp.c >>> b/OvmfPkg/CpuHotplugSmm/QemuCpuhp.c >>> index 8d4a6693c8d6..36372a5e6193 100644 >>> --- a/OvmfPkg/CpuHotplugSmm/QemuCpuhp.c >>> +++ b/OvmfPkg/CpuHotplugSmm/QemuCpuhp.c >>> @@ -164,6 +164,9 @@ QemuCpuhpWriteCommand ( >>>     @param[out] ToUnplugApicIds  The APIC IDs of the CPUs that are >>> about to be >>>                                  hot-unplugged. >>>   +  @param[out] ToUnplugSelector The QEMU Selectors of the CPUs that >>> are about to >>> +                               be hot-unplugged. >>> + >>>     @param[out] ToUnplugCount    The number of filled-in APIC IDs in >>>                                  ToUnplugApicIds. >>>   >> > Acking the comments above. > >> (7) Please (a) call the parameter "ToUnplugSelectors" (plural), and (b) >> make sure that there are two space characters between the variable name >> "column" and the documentation "column". (All in all, please move the >> RHS column to the right by two spaces.) > > That would make the RHS of ToUnplugSelectors not line up with the other > two out params. (Even though this mail does not seem to show that, they > do line up in the code.) Is that okay? Sorry, I was unclear. I meant the request as follows: please move the full-height RHS column, containing *all* the parameter descriptions, to the right, by 2 spaces; please also re-wrap wherever necessary, to maintain <= 80 chars width. Thanks Laszlo