From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.75201.1674744297299556898 for ; Thu, 26 Jan 2023 06:44:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=IgBC6f/B; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 233BE20E6582; Thu, 26 Jan 2023 06:44:56 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 233BE20E6582 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1674744296; bh=9d7cJqXXeZA9JGgJDpJ7m9+vCas0Rl6hgaitYFLl/YA=; h=Date:Subject:From:To:Cc:Reply-To:References:In-Reply-To:From; b=IgBC6f/B1UvEHT2xXxA63JCGv5UN3me4ZZ676yDrX558SWv4iKiIEH3B0jDTSnIIW EdXCdvtkOWa79IZofobpFVg/uihA8PfgfskBsvIy1dQZHaXlhNEHXrIYzEPcJxmYWq U9Y3GHQG/MpVfmrr4G840WjdXLviyV+1kvrc5bjY= Message-ID: Date: Thu, 26 Jan 2023 09:44:55 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file From: "Michael Kubacki" To: devel@edk2.groups.io, Michael D Kinney , Leif Lindholm , Andrew Fish Cc: Chris Fernald , Oliver Steffen Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com References: <173C1FA3C96CC3CD.14781@groups.io> In-Reply-To: <173C1FA3C96CC3CD.14781@groups.io> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I've seen interest on the patch but no R-b yet. I believe those in the TO line might be the best to provide that since this is a new directory. If anyone is interested in being a maintainer/reviewer, let me know and I'll update the file. Thanks, Michael On 1/20/2023 3:51 PM, Michael Kubacki wrote: > From: Michael Kubacki > > Tianocore maintains container images in the tianocore/containers repo > and stores container images within the GitHub container registry. > > https://github.com/tianocore/containers > > This change adds a devcontainer.json file to the edk2 repo. This > file's metadata and settings to configurate a development container > for a given well-defined tool and runtime stack. > > More information about the devcontainer.json file is available here: > https://containers.dev/implementors/json_reference/ > > This file is recognized by popular tools such as GitHub Codespaces > and VS Code. In VS Code in particular, it makes it much easier for > a user to be aware a dev container exists (via UI notifications) > and to load the container. > > A minimal number of VS Code extensions are specified that are useful > for edk2 development or to assist in complying with CI checks in > place in edk2. > > Cc: Andrew Fish > Cc: Chris Fernald > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Oliver Steffen > Signed-off-by: Michael Kubacki > --- > .devcontainer/devcontainer.json | 16 ++++++++++++++++ > Maintainers.txt | 5 +++++ > 2 files changed, 21 insertions(+) > > diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json > new file mode 100644 > index 000000000000..592bb8cf6626 > --- /dev/null > +++ b/.devcontainer/devcontainer.json > @@ -0,0 +1,16 @@ > +{ > + "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", > + "postCreateCommand": "git config --global --add safe.directory * && pip install --upgrade -r pip-requirements.txt", > + "customizations": { > + "vscode": { > + "extensions": [ > + "DavidAnson.vscode-markdownlint", > + "ms-azuretools.vscode-docker", > + "ms-vscode-remote.remote-containers", > + "ms-vscode.cpptools", > + "walonli.edk2-vscode", > + "zachflower.uncrustify" > + ] > + } > + } > +} > diff --git a/Maintainers.txt b/Maintainers.txt > index 68f603b48398..4aa7973d5156 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -117,6 +117,11 @@ M: Michael Kubacki [makubacki] > R: Michael D Kinney [mdkinney] > R: Liming Gao [lgao4] > > +.devcontainer/ > +F: .devcontainer/ > +M: Michael Kubacki [makubacki] > +R: Chris Fernald [cfernald] > + > .github/ > F: .github/ > M: Sean Brogan [spbrogan]