Re: [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu

["Laszlo Ersek" <lersek@redhat.com>]

On 07/24/19 03:51, rebecca@bsdio.com wrote:
> Specify the firmware to use via the newer '-drive if=pflash' syntax
> which allows specifying the raw format and readonly parameters. This
> avoids warnings with newer version of QEMU.
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  OvmfPkg/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index a2c4eff2a5..e2890ff762 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -268,7 +268,7 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
>    fi
>    ln -sf $FV_DIR/OVMF.fd $QEMU_FIRMWARE_DIR/bios.bin
>    if [[ "$ENABLE_FLASH" == "yes" ]]; then
> -    QEMU_COMMAND="$QEMU_COMMAND -pflash $QEMU_FIRMWARE_DIR/bios.bin"
> +    QEMU_COMMAND="$QEMU_COMMAND -drive if=pflash,format=raw,readonly,file=$QEMU_FIRMWARE_DIR/bios.bin"
>    else
>      QEMU_COMMAND="$QEMU_COMMAND -L $QEMU_FIRMWARE_DIR"
>    fi
> 

I'm late to reviewing the "OvmfPkg/build.sh" patches, but then again,
I'm glad that both Jordan and Phil are scrutinizing them :)

So I guess, on "OvmfPkg/build.sh" patches, I'll just defer to Jordan and
Phil. I appreciate the relief! (ask me about my day... or rather don't...)

Laszlo