From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Thu, 25 Jul 2019 17:14:13 -0700
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id DD3C53081244;
	Fri, 26 Jul 2019 00:14:12 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-178.ams2.redhat.com [10.36.116.178])
	by smtp.corp.redhat.com (Postfix) with ESMTP id D923E608A4;
	Fri, 26 Jul 2019 00:14:11 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu
To: devel@edk2.groups.io, rebecca@bsdio.com,
 Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <20190724015101.13044-1-rebecca@bsdio.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <e4c07e17-351e-4749-23a3-d01fac091a36@redhat.com>
Date: Fri, 26 Jul 2019 02:14:10 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190724015101.13044-1-rebecca@bsdio.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 26 Jul 2019 00:14:12 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 07/24/19 03:51, rebecca@bsdio.com wrote:
> Specify the firmware to use via the newer '-drive if=pflash' syntax
> which allows specifying the raw format and readonly parameters. This
> avoids warnings with newer version of QEMU.
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  OvmfPkg/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index a2c4eff2a5..e2890ff762 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -268,7 +268,7 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
>    fi
>    ln -sf $FV_DIR/OVMF.fd $QEMU_FIRMWARE_DIR/bios.bin
>    if [[ "$ENABLE_FLASH" == "yes" ]]; then
> -    QEMU_COMMAND="$QEMU_COMMAND -pflash $QEMU_FIRMWARE_DIR/bios.bin"
> +    QEMU_COMMAND="$QEMU_COMMAND -drive if=pflash,format=raw,readonly,file=$QEMU_FIRMWARE_DIR/bios.bin"
>    else
>      QEMU_COMMAND="$QEMU_COMMAND -L $QEMU_FIRMWARE_DIR"
>    fi
> 

I'm late to reviewing the "OvmfPkg/build.sh" patches, but then again,
I'm glad that both Jordan and Phil are scrutinizing them :)

So I guess, on "OvmfPkg/build.sh" patches, I'll just defer to Jordan and
Phil. I appreciate the relief! (ask me about my day... or rather don't...)

Laszlo