From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.221.65; helo=mail-wr1-f65.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AFE9C21163DDF for ; Thu, 1 Nov 2018 12:02:22 -0700 (PDT) Received: by mail-wr1-f65.google.com with SMTP id d17-v6so20788546wre.11 for ; Thu, 01 Nov 2018 12:02:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CEAakLuCOIvhXzHzwxhSZBR/oyLepI66CvauWUN/V6I=; b=DDDogky7VpBd6LUdFnLnz5pkvdTSP0mXmU3FsWJ66yrmT3wdqJ08euPtG+lV+w7/rw H7gPynwBKdIMQGFDkrmZ0JnOYY5TBlF36zxVfOAuFWG7VBAhXjNnQIwiLPyFkcxUoYOH baaodwizw2Muvi9KYzhjc787Vo8iTWRdnPtgxlXra5Iw4j7jfxwofTYCwOOwsDWg5+Bo dxwEh5R+Zd5tRZj76z/Igz2HHqnhEIzZfao3d+GpC4hRCgy0aFYA6csynIG7/OXXuj/P 1nP5dvFWkH+h5y2+5hJ0Jc7hVyuP2yiNrEChKZ4VIklu8NakYELEyhjWMlMGs+NU9OdV KFGg== X-Gm-Message-State: AGRZ1gKn0S2gFP0hhQIiukP9JtmpivdVwhpQVdZKgYisD6icBOOSQgF+ UK72Nb23mTvzAtpAIojAU3VJZw== X-Google-Smtp-Source: AJdET5dXy3WXMa7KDbJr+fvtf42D/e8f7Zm+sWdygFYBSUzaGSeJp5ksnlUWA3tNSAw2IIll8SJUJg== X-Received: by 2002:adf:f290:: with SMTP id k16-v6mr7748051wro.108.1541098941223; Thu, 01 Nov 2018 12:02:21 -0700 (PDT) Received: from [192.168.1.130] ([139.47.31.199]) by smtp.gmail.com with ESMTPSA id x18-v6sm6947802wrs.50.2018.11.01.12.02.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Nov 2018 12:02:20 -0700 (PDT) To: yuchenlin@synology.com, edk2-devel@lists.01.org Cc: phil@philjordan.eu, jordan.l.justen@intel.com, anthony.perard@citrix.com, lersek@redhat.com References: <20181024064008.26535-1-yuchenlin@synology.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Thu, 1 Nov 2018 20:02:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181024064008.26535-1-yuchenlin@synology.com> Subject: Re: [PATCH 0/4] OvmfPkg: simply use the Bochs interface for vmsvga X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 19:02:23 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Yu-chen Lin, On 24/10/18 8:40, yuchenlin@synology.com wrote: > From: yuchenlin > > In this series, replace the original vmsvga driver to Bochs > interface. This is the 'v2' of your previous patch 'OvmfPkg: initialize bochs when initializing vmsvga': https://lists.01.org/pipermail/edk2-devel/2018-October/031235.html Keeping different versions and referencing previous series helps when reviewing. > > Simply revert vmsvga driver implementation. After it, use Bochs > interface for initializing vmsvga. > > Because of the PCI BARs difference between std vga and vmsvga. > We can not simply recognize the "QEMU VMWare SVGA" as the > QEMU_VIDEO_BOCHS_MMIO variant. > > BAR | std vga | vmsvga > --------------------------------- > 0 | Framebuffer | I/O space > 1 | Reserved | Framebuffer > 2 | MMIO | FIFO > > To overcome this problem, we remain variant QEMU_VIDEO_VMWARE_SVGA, > and use it for: > > (1) Get framebuffer from correct PCI BAR > (2) Prevent using BAR2 for MMIO > > We have tested on qemu before and after commit 104bd1dc70 and all worked. Did you also test against QEMU v2.9.1? > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: yuchenlin > > yuchenlin (4): > Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support" > Revert "OvmfPkg/QemuVideoDxe: Helper functions for unaligned port > I/O." > Revert "OvmfPkg/QemuVideoDxe: list "UnalignedIoInternal.h" in the INF > file" > OvmfPkg: simply use the Bochs interface for vmsvga > > OvmfPkg/QemuVideoDxe/Driver.c | 137 ++------------- > OvmfPkg/QemuVideoDxe/Gop.c | 68 +------- > OvmfPkg/QemuVideoDxe/Initialize.c | 157 ------------------ > OvmfPkg/QemuVideoDxe/Qemu.h | 27 --- > OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf | 7 - > OvmfPkg/QemuVideoDxe/UnalignedIoGcc.c | 70 -------- > OvmfPkg/QemuVideoDxe/UnalignedIoIcc.c | 80 --------- > OvmfPkg/QemuVideoDxe/UnalignedIoInternal.h | 59 ------- > OvmfPkg/QemuVideoDxe/UnalignedIoMsc.c | 78 --------- > OvmfPkg/QemuVideoDxe/UnalignedIoUnsupported.c | 66 -------- > 10 files changed, 17 insertions(+), 732 deletions(-) > delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoGcc.c > delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoIcc.c > delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoInternal.h > delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoMsc.c > delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoUnsupported.c >