From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>,
Rebecca Cran <rebecca@bsdio.com>
Subject: [PATCH 02/13] OvmfPkg: support powering off bhyve guests
Date: Wed, 15 Apr 2020 17:09:28 -0600 [thread overview]
Message-ID: <e4e9b29189b83076e1d1a0b9c989938f5226cab6.1586991816.git.rebecca@bsdio.com> (raw)
In-Reply-To: <cover.1586991816.git.rebecca@bsdio.com>
Update ResetSystemLib to support powering off bhyve guests instead of
having them enter the CpuDeadLoop.
On bhyve, the Power Management 1 Control Register is located at 0x404;
a write with SLP_TYP set to 5 will power off the guest.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
OvmfPkg/Include/IndustryStandard/Bhyve.h | 4 ++++
OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c | 6 ++++++
2 files changed, 10 insertions(+)
diff --git a/OvmfPkg/Include/IndustryStandard/Bhyve.h b/OvmfPkg/Include/IndustryStandard/Bhyve.h
index 950f87048b..ceabc54d59 100644
--- a/OvmfPkg/Include/IndustryStandard/Bhyve.h
+++ b/OvmfPkg/Include/IndustryStandard/Bhyve.h
@@ -18,4 +18,8 @@
#define BHYVE_ACPI_TIMER_IO_ADDR 0x408
+#define BHYVE_PMBASE_VALUE 0x400
+
+#define BHYVE_PCI_DEVICE_ID 0x1275 // NetApp vendor ID
+
#endif // __BHYVE_H__
diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
index 2f2e1293a3..8d9b9dfcf5 100644
--- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
+++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
@@ -28,6 +28,12 @@ AcpiPmControl (
AcpiPmBaseAddress = 0;
HostBridgeDevId = PciRead16 (OVMF_HOSTBRIDGE_DID);
switch (HostBridgeDevId) {
+ case BHYVE_PCI_DEVICE_ID:
+ AcpiPmBaseAddress = BHYVE_PMBASE_VALUE;
+ // Bhyve needs a value of 5 to enter S5 (power off)
+ if (SuspendType == 0)
+ SuspendType = 5;
+ break;
case INTEL_82441_DEVICE_ID:
AcpiPmBaseAddress = PIIX4_PMBA_VALUE;
break;
--
2.26.1
next prev parent reply other threads:[~2020-04-15 23:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 23:09 [PATCH 00/13] BhyvePkg - initial patch series for review Rebecca Cran
2020-04-15 23:09 ` [PATCH 01/13] OvmfPkg: Add bhyve support into AcpiTimerLib Rebecca Cran
2020-04-17 8:07 ` [edk2-devel] " Laszlo Ersek
2020-04-15 23:09 ` Rebecca Cran [this message]
2020-04-17 8:55 ` [edk2-devel] [PATCH 02/13] OvmfPkg: support powering off bhyve guests Laszlo Ersek
2020-04-17 18:56 ` Rebecca Cran
2020-04-21 22:14 ` Rebecca Cran
2020-04-22 15:49 ` Laszlo Ersek
2020-04-15 23:09 ` [PATCH 03/13] BhyvePkg: Add BhyveFwCtlLibNull Rebecca Cran
2020-04-15 23:09 ` [PATCH 04/13] OvmfPkg: Add QemuFwCfgS3LibNull Rebecca Cran
2020-04-17 16:37 ` [edk2-devel] " Laszlo Ersek
2020-04-15 23:09 ` [PATCH 05/13] OvmfPkg: Add VBE2 mode info structure to LegacyVgaBios.h Rebecca Cran
2020-04-17 16:43 ` [edk2-devel] " Laszlo Ersek
2020-04-15 23:09 ` [PATCH 06/13] OvmfPkg: add QemuFwCfgPeiLibNull Rebecca Cran
2020-04-17 16:57 ` [edk2-devel] " Laszlo Ersek
2020-04-15 23:09 ` [PATCH 07/13] OvmfPkg: add QemuFwCfgS3LibNull Rebecca Cran
2020-04-17 17:01 ` [edk2-devel] " Laszlo Ersek
2020-04-15 23:09 ` [PATCH 08/13] Add BhyvePkg, to support the bhyve hypervisor Rebecca Cran
2020-04-15 23:09 ` [PATCH 09/13] OvmfPkg: Add bhyve support to PlatformPei Rebecca Cran
2020-04-15 23:09 ` [PATCH 10/13] OvmfPkg: Add bhyve support to AcpiPlatformDxe Rebecca Cran
2020-04-15 23:09 ` [PATCH 11/13] BhyvePkg: Add InstrincsLib to BhyveFwCtlLib Rebecca Cran
2020-04-15 23:09 ` [PATCH 12/13] BhyvePkg: __attribute__ doesn't exist on MSVC toolchains Rebecca Cran
2020-04-15 23:09 ` [PATCH 13/13] BhyvePkg: fix BhyveSetGraphicsMode call for VS2019 build Rebecca Cran
2020-04-16 20:47 ` [edk2-devel] [PATCH 00/13] BhyvePkg - initial patch series for review Laszlo Ersek
2020-04-16 22:43 ` Laszlo Ersek
2020-04-17 6:46 ` Rebecca Cran
2020-04-17 6:55 ` Rebecca Cran
2020-04-20 9:51 ` Laszlo Ersek
2020-04-20 9:57 ` Laszlo Ersek
2020-04-21 17:12 ` Rebecca Cran
2020-04-17 7:55 ` Laszlo Ersek
2020-04-17 15:31 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4e9b29189b83076e1d1a0b9c989938f5226cab6.1586991816.git.rebecca@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox