From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.89]) by mx.groups.io with SMTP id smtpd.web09.1090.1619805477423279384 for ; Fri, 30 Apr 2021 10:57:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=nKKgd6IJ; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.89, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=imcguMPk3PI9F29v0udDsNdvMZgtXXSwn3FJsuFCsoev8/Tw7Ve368DwzpDP0k5rqAjJ+qW66e9O7zHlfQ3U0wXo50MrcPFBQVNZn+SNQ6XDTw5of4bwuDgZTbZGJMDxARjhOgK/lrSMRROwGaBW3tQyRpz/SM2GLSh3/jA160nzMl8ER4sW5gLhlFCYDNffbN1scU9hyxscGQ0pnhqbN6WN/hlPUwlq/XGO/nvRcay62SGaYxFFd2Kft90qWZe3B4yirmNy8GLY7r/MAx4HbQT15Y1Vz21Y4ldRhfbRp2jRg1sdELZlKUrYuSmXGd5iFhKjCZ2Llcai3lh1mTwRYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SCEs9ten3ElAFD78KWK+VqeoxufWPZ2N4VC2GQZ1VGE=; b=jcxfH+qy8Vc5fc5rYgJjtcb0vei9+yIQe4CbqvI3MyeEH4J5SIbWsftF4EKtn9XbSkPk7o5PnCOu4jwMvaESlFoi7Dd0FRM2AfMAAglt4I1Ivakmgcn/UxUBB14Mx2qSkdhL5YsSKVho6gZZijHHWj6rXb4WXGlE4zeX2etMLWbytslS7iuyG3QVwEeBFSdl1V5umKAABwUN/0FFmSXm97wyEFSNh0vP4cPvKxf1lN3uDhVGKKFpHoUfxvtMwwBxLXywPirLeyST9bYKe5qNRhYgGJYJ7E2tAMi2WVaEn+Pjg9or9unGrU2BNFSJQHXrEaIF6iy1aNalKuZcuMVgOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SCEs9ten3ElAFD78KWK+VqeoxufWPZ2N4VC2GQZ1VGE=; b=nKKgd6IJwHVxB2PAK1X4WBNfrjuy8FX3KCF3kwz3m/Ea5nUoE+s5G6H3wnDImUjRj8PpOmcxoIZkDFgTmBXEQeIK4Y6Tx4T2pBn6lPsjcoP6Xy6Iy9Cm88VJmZuDAylAjjjfXb4D1FmqwIs8RpZwpWojgUn2AGZY/7loKGvDE6o= Authentication-Results: linux.ibm.com; dkim=none (message not signed) header.d=none;linux.ibm.com; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM5PR1201MB2506.namprd12.prod.outlook.com (2603:10b6:3:e7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.23; Fri, 30 Apr 2021 17:57:55 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::b914:4704:ad6f:aba9]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::b914:4704:ad6f:aba9%12]) with mapi id 15.20.4065.033; Fri, 30 Apr 2021 17:57:55 +0000 Subject: Re: [edk2-devel] [PATCH v2 4/4] OvmfPkg/Tcg2ConfigPei: Mark TPM MMIO range as unencrypted for SEV-ES To: Laszlo Ersek , devel@edk2.groups.io Cc: Joerg Roedel , Borislav Petkov , Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Min Xu , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Stefan Berger References: <00ff47c80f180b5b9054890de0ce5e1975fe2b1f.1619540470.git.thomas.lendacky@amd.com> <6807464e-823e-3a16-cf1c-24f612a43936@redhat.com> <096090a1-6fd4-6364-fc88-733a0b3ef422@amd.com> <2232673b-69db-43ca-7c93-347b3d4fa62f@redhat.com> From: "Lendacky, Thomas" Message-ID: Date: Fri, 30 Apr 2021 12:57:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <2232673b-69db-43ca-7c93-347b3d4fa62f@redhat.com> X-Originating-IP: [67.79.209.213] X-ClientProxiedBy: SA0PR11CA0134.namprd11.prod.outlook.com (2603:10b6:806:131::19) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from office-linux.texastahm.com (67.79.209.213) by SA0PR11CA0134.namprd11.prod.outlook.com (2603:10b6:806:131::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.25 via Frontend Transport; Fri, 30 Apr 2021 17:57:54 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 91e2bd91-a179-41f7-b563-08d90c017b7a X-MS-TrafficTypeDiagnostic: DM5PR1201MB2506: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Rw87Tb/pKaJEyIhdMsz/dTVCiM6DmYiIJslBUxEPb9zBlhj/7RspVU0h8ZyzpeAt0bxHiewGAPcI/BROeekfKZ3ehMCrhfx3H28e24H8G6YRBCJXZNCW82vixzrtIvCzF/3Bqgkmr9rc50jtkB1JmF3uMZkDfBbK2EPE2re/KTwSPWp1vxAfjdp1Mcy3MHJJonV+PE3ukcNGMmQ8hqa8pgHyrRSWwpvh2fGq9jlyqpl393vYfEzyeJtecIXk62rJhPxSRytVUM09raVc/+2HZNX21KQJgjjkL2nZB1+RWbd8BeOj1W7zn8D5geGmXmtXOykmxHtmWs1gjCdR05akduHSy9I99e+hp1R5wiwoHKrJs6CM9RFS+m4nQ3dxawVGre2wwKoVFZYRIJdeImz1O1ccaNg5QBZi5eRZkz1MI5XGA9a0fKJcrKYVfGX9j3pK4WL20uPOyA9G9bfKrkmZpqbSCN9/xSpnDpji2Fi9ankTuTO2ahFCYGJUbS4cHhwW+pFzQKxUZGOy/2rwiQ9TmzbbOqLwEaplwLEbYQPRGmFVW3Y7VlDvw8LyXhBqFP0gLQKOMlDezeIqdvpA0QHIWKqQDLba7BEFN0bDLzP3K3I7Oa5MpvJb18DXuG7EF5Wcdfun5A7QKiup6nE2mySxCL0fTqWO1kYt6dh2jVAHoFDw9jEXo8QDzB5NGgiONZS9 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(396003)(366004)(346002)(376002)(6486002)(36756003)(7416002)(316002)(66556008)(19627235002)(5660300002)(8936002)(38100700002)(54906003)(478600001)(6512007)(4326008)(8676002)(83380400001)(186003)(66946007)(16526019)(26005)(956004)(31686004)(86362001)(6506007)(2906002)(53546011)(31696002)(2616005)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?cmJ2SW9RYWFFbnVRdnVWNUswMlhVV1RTczhpc2l2Z3BqUVljaTkrVExISEhk?= =?utf-8?B?dnZsbktGZ0lyVFVlS2VxTkxoY3BMdWJPenJHa0VlWlhMYUsvZ0NNc2h3YVk0?= =?utf-8?B?VzMxMnordWczYzNCeElJQnhnYzBjRWxqRE9xaWJwU2theEtUdHdSMTFaeVV3?= =?utf-8?B?aVpITlZQTGhSVEtDd0c0TjB0QkpPVkdiTm9lRHhOQnRmbC9CNU1JcHhOazRO?= =?utf-8?B?WWFjYmg5Zm9pQkwzUUxNdU9RSWVFbFFwNlowVU8vS0drUW9SVFptN3RIM2p4?= =?utf-8?B?dytmMzRITi9Gb3l5eENuRjlkN2pUZnNhV2JMeFU0YTR2Y2I1eTI3TmppdHdi?= =?utf-8?B?dGFWSVgzN1FLelprQS9FbTVscWIreCtVUVBuakE4ckc5YXE5Z3o5MmFHcFVK?= =?utf-8?B?Y00zbVh1T3RheTB1VGhlN3ZZQ2FBZ1hTOXR5Zzk3MFRrYVl0N21vbjlJSG5W?= =?utf-8?B?NzE5SzJuRlVQcnU4c3RrSHFyRVlXS1pYZWx6QTlWMmpCdVVoYXlYVXczZ2VF?= =?utf-8?B?dEdVWlhGUTVvbzFxQjRQa05KQUo4MTd6WE5oQk1uUldybnpuNTlPaU5oK0J2?= =?utf-8?B?bCttckJFYlVuQndLQ3hmZmJsRCtZMlNvT0kvV0J0ZG90Q1FqU0dCUDhiSWUw?= =?utf-8?B?cjg4U3h5QzFVd0tGNTlYcDVPQXVNRldGUlRGV1F5V1dlTVpOYlgwNU9UWlRN?= =?utf-8?B?Q3YzbGlhTVVJeG1nVmRHVGtVSTRZcDU5MTZFc0xJV0lNaWwrcERMVFJ0TkNq?= =?utf-8?B?NTJpbGRoUEl6WXFqOThlYVdpQWFqV2FoTXV1TFZPYmt3cWtWS3dnY2czbk1K?= =?utf-8?B?R2F3UHhBeWVTWXdLS3VsRldadEpsR0lmZ1lqTHVwLzdBNGpDL25walIvU01j?= =?utf-8?B?Lzg4WDhXdy9SR3Y1cWJubjIycDJZcmh5K0cvZEZOSkVwQ1FKaW5vNHFSRVdN?= =?utf-8?B?Y0NVaVlOWlg0dy82RTlPNFBDWWFMRnV0WTk3Zks4Q05CQnNDMDB1ZzRnNDIz?= =?utf-8?B?YU13MVBCT1JaSWFzS3V4Nm9UQjNYUXlyVWo3TnYxZkFsbDkyYlVWbDdycVNL?= =?utf-8?B?SzNDV09ZZ2t1dTZHcUc2RWNpK2s1alhCdnJqZTFBeWE5WVlpc0tXZHhXalpD?= =?utf-8?B?TFozbXlyTWRTSVY4ckJqRjBROTZpS3dnMCtSNFhKQmZMSnp4bk5tQmdCNjB0?= =?utf-8?B?Q0t6UEMzZk8wSmZxY1FWdmp6ZkJqMUIybnFTMGpqVm5xeGVzOHA4RGJlMXll?= =?utf-8?B?cGxOaTg2ZDcwQ3hjcGtXQkZWN3JjZTkxQzFWZnV1end1M1Y5MTNaS0NQQVFi?= =?utf-8?B?WmUxV2N1L2Q3a1VYdDJ0eHVYVHl4Z1JCdkRHakVXVUtXcGhOVFRUVGNLQTFv?= =?utf-8?B?aVNCTC82Y05IdWxydGQ4WUVENmlZam9xalNPWFVWQlUycmQrTzl2K0xIaUVx?= =?utf-8?B?QVlYWCt0QkNXVHF0eDJlem1nUndkZHZGN3RRMHJXKzNEYWZSaTlXSU5mS3dC?= =?utf-8?B?aCtIbVIrc283VTdGa1kyR2hRSDFYZ1ZRbFJoR0tRNm1mbml3bS9sYjVvSVpo?= =?utf-8?B?RHVhWDc5SkdYdVM4ckJLTmVIeUY0dzA3ck9Ga25qTmFaK0cyV3lxblhoYkNZ?= =?utf-8?B?aFlvQmNFbGdpUEZBVjBTdHVyc3RjbXh5Z3hEQVBoT3R5QVQxRkw4K1VwUklT?= =?utf-8?B?OHMyQmR1RlI3SXE3VmVabTJyQ0Zubzc2dmtSMG9HSktRbTJtQWJzNFVhbFhF?= =?utf-8?Q?b98fDeQXX/Ep97Az+dmVpoMdukgqY+aS8Pz8oSd?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91e2bd91-a179-41f7-b563-08d90c017b7a X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2021 17:57:55.7964 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bSe2WyIpJF4fmn9ay22PyCtFassiXTnRp0YFxSLvWQE6nVZbSRF+FHXXRePSZpiRs2cqWw2VSKKG555xUY6VRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB2506 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/30/21 10:48 AM, Laszlo Ersek wrote: > I need to excuse myself for two items here, where your expectation was > justified: No worries, I'm flexible! Thanks, Tom > > On 04/28/21 21:43, Tom Lendacky wrote: >> On 4/28/21 12:51 PM, Laszlo Ersek via groups.io wrote: >>> I'm going to ask for v3 after all: >>> >>> On 04/27/21 18:21, Lendacky, Thomas wrote: > >>>> @@ -627,6 +627,7 @@ [Components] >>>> >>>> !if $(TPM_ENABLE) == TRUE >>>> OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf >>>> + OvmfPkg/Tcg/TpmMmioSevDecryptPei/TpmMmioSevDecryptPei.inf >>>> SecurityPkg/Tcg/TcgPei/TcgPei.inf >>>> SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf { >>>> >>> >>> (5) Functionally correct, but it reads more nicely (from a logical >>> dependency POV) if we place the new PEIM first. >>> >>> (Please apply to the rest of the DSC files, and the FDF files too.) >> >> Ok, I was going with the alphabetical placement. I'll switch it up. > > Well, you are not wrong; what I request for ordering between lib classes > and between FDF/DSC entries is indeed inconsistent. I guess for lib > classes, showing the construction order makes little, as that is > determined with respect to particular library instances, plus we wrangle > lib classes all the time, and keeping consistency is simplest with > alphabetical ordering. Dispatch order is *somewhat* more directly > visible in a FDF file... but yes, keeping INF references in alphabetical > order there too would certainly plausible > >>>> + DEBUG ((DEBUG_INFO, "%a: failed to map TPM MMIO address range unencrypted\n", __FUNCTION__)); >>> >>> (13) Overlong line. >> >> Ok, I'll change that. I though that was ok now since PatchCheck.py didn't >> complain. > > Sorry about my pickiness; this is a point where I strongly disagree with > the rest of the edk2 maintainers -- I really do insist on 80 chars per > line, as my eyesight isn't the greatest, I totally depend on two code > windows being shown side by side, and I *also* can't work with multiple > monitors (I've tried it, I just can't). So... one monitor, mid-size > fonts, two columns of text --> 80 chars per column. > > Thanks & sorry about the trouble, > Laszlo >