From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id A48EE202E53F8
 for <edk2-devel@lists.01.org>; Thu, 28 Jun 2018 06:15:52 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com
 [10.11.54.6])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id D9DCE40776E9;
 Thu, 28 Jun 2018 13:15:51 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-10.rdu2.redhat.com
 [10.10.120.10])
 by smtp.corp.redhat.com (Postfix) with ESMTP id D534D213ED6A;
 Thu, 28 Jun 2018 13:15:50 +0000 (UTC)
To: "Zeng, Star" <star.zeng@intel.com>, Brijesh Singh
 <brijesh.singh@amd.com>, "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Tom Lendacky <Thomas.Lendacky@amd.com>, "Dong, Eric"
 <eric.dong@intel.com>, "Justen, Jordan L" <jordan.l.justen@intel.com>
References: <1530042365-9979-1-git-send-email-brijesh.singh@amd.com>
 <a8e85ecf-48ef-4e21-7841-e008828abb6a@redhat.com>
 <f25a7635-8a50-ca5d-42e2-1d665482a94d@amd.com>
 <272c4a0f-fcc1-2899-e31d-a3207feb51ed@redhat.com>
 <2a662245-bb03-e742-1403-4d0a47bffda7@amd.com>
 <0C09AFA07DD0434D9E2A0C6AEB0483103BB5E096@shsmsx102.ccr.corp.intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <e505b448-16cf-bac4-7bc4-10f7124e65d2@redhat.com>
Date: Thu, 28 Jun 2018 15:15:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BB5E096@shsmsx102.ccr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.7]); Thu, 28 Jun 2018 13:15:51 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]);
 Thu, 28 Jun 2018 13:15:51 +0000 (UTC) for IP:'10.11.54.6'
 DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jun 2018 13:15:52 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 06/28/18 08:25, Zeng, Star wrote:
> My understanding is MMIO is not managed by UEFI memory services, but GCD services.
> PI spec says " If the memory range specified by BaseAddress and Length is of type EfiGcdMemoryTypeSystemMemory or EfiGcdMemoryTypeMoreReliable, then the memory range may be automatically *allocated* for use by the *UEFI memory services*." in AddMemorySpace() description.
> 
> For MMIO, the code needs to use AddMemorySpace() + AllocateMemorySpace().

Right, after seeing today the (updated) AllocatePages() failure,
reported by Brijesh, I came to the same conclusion. Thank you for
correcting my initial suggestion! It's not easy to keep this details in
mind :)

Laszlo