From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9E4AE211BD612 for ; Wed, 30 Jan 2019 07:49:10 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 07:49:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="134455878" Received: from linux.intel.com ([10.54.29.200]) by orsmga001.jf.intel.com with ESMTP; 30 Jan 2019 07:49:09 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 93198580550; Wed, 30 Jan 2019 07:49:07 -0800 (PST) Message-ID: From: Ryszard Knop To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com Date: Wed, 30 Jan 2019 16:49:05 +0100 In-Reply-To: <20181115023353.20159-4-ard.biesheuvel@linaro.org> References: <20181115023353.20159-1-ard.biesheuvel@linaro.org> <20181115023353.20159-4-ard.biesheuvel@linaro.org> Organization: Intel Corporation User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Subject: Re: [PATCH edk2-staging 03/20] IntelUndiPkg/XGigUndiDxe: consistently use forward slashes as path separators X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:49:10 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Reviewed-by: Ryszard Knop On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote: > Replace backslashes in paths with forward slashes to be compatible > with > non-Windows OSes. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/XGigUndiDxe/Decode.c | 2 +- > IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 14 +++++++------- > IntelUndiPkg/XGigUndiDxe/Xgbe.h | 2 +- > IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h | 4 ++-- > 4 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/IntelUndiPkg/XGigUndiDxe/Decode.c > b/IntelUndiPkg/XGigUndiDxe/Decode.c > index 70fbce64c64f..5f37ce254872 100644 > --- a/IntelUndiPkg/XGigUndiDxe/Decode.c > +++ b/IntelUndiPkg/XGigUndiDxe/Decode.c > @@ -28,7 +28,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE > POSSIBILITY OF SUCH DAMAGE. > ******************************************************************** > *******/ > > #include "Xgbe.h" > -#include > +#include > > // Forward declarations for UNDI function table > /** This routine determines the operational state of the UNDI. It > updates the state flags in the > diff --git a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > index 7ccc52bc9869..beee8aa8134e 100644 > --- a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > +++ b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > @@ -110,13 +110,13 @@ GCC:*_*_*_CC_FLAGS = -DEFI32 > Version.h > HiiInternalLib.c > HiiInternalLib.h > - wol\wol.c > - wol\wol.h > - wol\wolfamily.c > - wol\wolimpl.c > - wol\wolimpl.h > - wol\wolinfo.c > - wol\wol_10G.c > + wol/wol.c > + wol/wol.h > + wol/wolfamily.c > + wol/wolimpl.c > + wol/wolimpl.h > + wol/wolinfo.c > + wol/wol_10G.c > > [Packages] > MdePkg/MdePkg.dec > diff --git a/IntelUndiPkg/XGigUndiDxe/Xgbe.h > b/IntelUndiPkg/XGigUndiDxe/Xgbe.h > index 5ab088362f90..4472cfb4fa31 100644 > --- a/IntelUndiPkg/XGigUndiDxe/Xgbe.h > +++ b/IntelUndiPkg/XGigUndiDxe/Xgbe.h > @@ -69,7 +69,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE > POSSIBILITY OF SUCH DAMAGE. > #include > #include > #include > -#include > +#include > > #include > > diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h > b/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h > index 368f40811904..e324b0539782 100644 > --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h > +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h > @@ -39,8 +39,8 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE > POSSIBILITY OF SUCH DAMAGE. > > #include > #include > -#include > -#include > +#include > +#include > #include > > #define CHAR CHAR8