From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.zytor.com (terminus.zytor.com [65.50.211.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 93D9020945BF9 for ; Thu, 7 Sep 2017 20:35:05 -0700 (PDT) Received: from [IPv6:2804:7f4:c480:9cd0::2] ([IPv6:2804:7f4:c480:9cd0:0:0:0:2]) (authenticated bits=0) by mail.zytor.com (8.15.2/8.15.2) with ESMTPSA id v883ZZ8g008378 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 7 Sep 2017 20:35:37 -0700 To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Cc: Laszlo Ersek , "Justen, Jordan L" , Andrew Fish , "Kinney, Michael D" , "Gao, Liming" , "Zeng, Star" , "Dong, Eric" , "Doran, Mark" , "Wu, Hao A" References: <734D49CCEBEEF84792F5B80ED585239D5BA27FD3@SHSMSX104.ccr.corp.intel.com> From: Paulo Alcantara Message-ID: Date: Fri, 8 Sep 2017 00:35:34 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BA27FD3@SHSMSX104.ccr.corp.intel.com> Subject: Re: [PATCH v5 0/6] read-only UDF file system support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2017 03:35:05 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 07/09/2017 23:41, Ni, Ruiyu wrote: > Paulo, > Did you mix the usage of "\r\n" and "\n"? because I saw a ^M in your diff. > However, the diff content looks good to me. No, I didn't. My local repo just lacked the 'git config core.whitespace cr-at-eol' setting so 'git diff' showed the CRLFs as whitespace errors. Just ignore them :-) Thanks! Paulo > > Thanks/Ray > >> -----Original Message----- >> From: Paulo Alcantara [mailto:pcacjr@zytor.com] >> Sent: Friday, September 8, 2017 8:56 AM >> To: edk2-devel@lists.01.org >> Cc: Laszlo Ersek ; Justen, Jordan L >> ; Andrew Fish ; Kinney, >> Michael D ; Gao, Liming >> ; Zeng, Star ; Dong, Eric >> ; Doran, Mark ; Ni, Ruiyu >> ; Wu, Hao A >> Subject: Re: [PATCH v5 0/6] read-only UDF file system support >> >> Ray, >> >> On 07/09/2017 20:13, Paulo Alcantara wrote: >>> v5: >>> - Fixed OVMF IA32 build. >>> - Fixed a typo in UdfDriveBindingStop() ("This" -> "SimpleFs") which >>> broke retrieval of private fs data from SimpleFs protocol -- >>> identified by 'reconnect -r' command in UEFI shell. >> >> Follow the diff between v4 and v5 for Mde*Pkg changes (forgot to include it >> when resending): >> >> diff --git a/MdeModulePkg/Universal/Disk/UdfDxe/File.c >> b/MdeModulePkg/Universal/Disk/UdfDxe/File.c >> index 8ad14fe594..2dbcff0be4 100644 >> --- a/MdeModulePkg/Universal/Disk/UdfDxe/File.c >> +++ b/MdeModulePkg/Universal/Disk/UdfDxe/File.c >> @@ -372,7 +372,7 @@ UdfRead ( >> PrivFileData->FileSize, >> &PrivFileData->FilePosition, >> Buffer, >> - BufferSize >> + (UINT64 *)(UINTN)BufferSize^M >> ); >> } else if (IS_FID_DIRECTORY_FILE (Parent->FileIdentifierDesc)) { >> if (ReadDirInfo->FidOffset == 0 && PrivFileData->FilePosition > 0) { diff -- >> git a/MdeModulePkg/Universal/Disk/UdfDxe/Udf.c >> b/MdeModulePkg/Universal/Disk/UdfDxe/Udf.c >> index 9f10c78ca9..49dc7077b7 100644 >> --- a/MdeModulePkg/Universal/Disk/UdfDxe/Udf.c >> +++ b/MdeModulePkg/Universal/Disk/UdfDxe/Udf.c >> @@ -264,7 +264,7 @@ UdfDriverBindingStop ( >> EFI_OPEN_PROTOCOL_GET_PROTOCOL >> ); >> if (!EFI_ERROR (Status)) { >> - PrivFsData = PRIVATE_UDF_SIMPLE_FS_DATA_FROM_THIS (This); >> + PrivFsData = PRIVATE_UDF_SIMPLE_FS_DATA_FROM_THIS >> (SimpleFs);^M >> >> // >> // Uninstall child handle >> >> >> Thanks, >> Paulo >