public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Vladimir Olovyannikov" <vladimir.olovyannikov@broadcom.com>
To: Laszlo Ersek <lersek@redhat.com>,
	"Rabeda, Maciej" <maciej.rabeda@linux.intel.com>,
	 "Gao, Zhichao" <zhichao.gao@intel.com>,
	devel@edk2.groups.io
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
	"Wu, Jiaxin" <jiaxin.wu@intel.com>,
	 "Fu, Siyuan" <siyuan.fu@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
	 "Gao, Liming" <liming.gao@intel.com>, Nd <nd@arm.com>
Subject: Re: [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
Date: Mon, 17 Aug 2020 11:29:01 -0700	[thread overview]
Message-ID: <e54b0c6993110e2797db951ee4028187@mail.gmail.com> (raw)
In-Reply-To: <2a710789-bfdd-dd80-386a-04fbd46d4835@redhat.com>

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Monday, August 17, 2020 11:01 AM
> To: Rabeda, Maciej <maciej.rabeda@linux.intel.com>; Vladimir Olovyannikov
> <vladimir.olovyannikov@broadcom.com>; Gao, Zhichao
> <zhichao.gao@intel.com>; devel@edk2.groups.io
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Gao, Liming <liming.gao@intel.com>; Nd
> <nd@arm.com>
> Subject: Re: [PATCH v5 1/1] ShellPkg/DynamicCommand: add
> HttpDynamicCommand
>
> On 08/17/20 19:15, Rabeda, Maciej wrote:
> > Hi Vladimir,
> >
> > I cannot apply the patch via 'git am'.
> > Is your git configured in a manner described here?
> > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt
> > -git-guide-for-edk2-contributors-and-maintainers
Hi Rabeda,
Yes, I followed the page. I did not run the SetupGit.py though.
> >
> >
> > Laszlo,
> >
> > Were you able to apply this patch from .eml file?
>
> Yes, but I had to use some tricks (implemented by my colleague Paolo in a
> python script) to undo the damage caused by the "quoted-printable"
> content-transfer-encoding on the posting.
>
> Our recommended Content-Transfer-Encoding (that is,
> "sendemail.transferEncoding") is "8bit", or even "base64".
> quoted-printable is practically impossible to get functional, with the
> hard
> CRLF line endings in edk2.
>
> "BaseTools/Scripts/SetupGit.py" does set "8bit".
Thank you for notice Laszlo,
So, should I run this script and re-send the patch as v6?

Thank you,
Vladimir
>
> Thanks
> Laszlo

  reply	other threads:[~2020-08-17 18:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27 16:48 [PATCH v5 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand Vladimir Olovyannikov
2020-07-27 16:48 ` [PATCH v5 1/1] " Vladimir Olovyannikov
2020-07-27 22:08   ` [edk2-devel] " Laszlo Ersek
2020-08-04 17:43     ` Vladimir Olovyannikov
2020-08-03  5:42   ` Liming Gao
2020-08-17  1:47   ` Gao, Zhichao
2020-08-17 15:46     ` Vladimir Olovyannikov
2020-08-17 17:15       ` Maciej Rabeda
2020-08-17 18:00         ` Laszlo Ersek
2020-08-17 18:29           ` Vladimir Olovyannikov [this message]
2020-08-17 20:44             ` Laszlo Ersek
2020-08-17 22:52               ` Vladimir Olovyannikov
2020-08-18 16:54                 ` Maciej Rabeda
2020-08-18 18:33                   ` Vladimir Olovyannikov
2020-08-19  9:47                     ` Laszlo Ersek
2020-08-19 17:43                       ` Maciej Rabeda
2020-08-19 18:06                         ` Vladimir Olovyannikov
2020-07-27 17:39 ` [PATCH v5 0/1] " Laszlo Ersek
2020-07-27 18:45   ` Vladimir Olovyannikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e54b0c6993110e2797db951ee4028187@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox