public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Michael Kinney <michael.d.kinney@intel.com>, edk2-devel@lists.01.org
Cc: Liming Gao <liming.gao@intel.com>,
	Yonghong Zhu <yonghong.zhu@intel.com>,
	 Kevin W Shaw <kevin.w.shaw@intel.com>
Subject: Re: [edk2-InfSpecification PATCH] Add LIB to supported file types in [Binaries] section
Date: Mon, 29 May 2017 13:27:46 +0200	[thread overview]
Message-ID: <e55c7297-c123-1e43-951e-244cd291153e@redhat.com> (raw)
In-Reply-To: <1495846169-37664-2-git-send-email-michael.d.kinney@intel.com>

On 05/27/17 02:49, Michael Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=463
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
> ---
>  2_inf_overview/27_[binaries]_section.md            | 7 ++++++-
>  3_edk_ii_inf_file_format/315_[binaries]_section.md | 2 +-
>  README.md                                          | 3 ++-
>  3 files changed, 9 insertions(+), 3 deletions(-)

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo

> 
> diff --git a/2_inf_overview/27_[binaries]_section.md b/2_inf_overview/27_[binaries]_section.md
> index f117340..993b836 100644
> --- a/2_inf_overview/27_[binaries]_section.md
> +++ b/2_inf_overview/27_[binaries]_section.md
> @@ -74,7 +74,7 @@ The formats for entries in this section are:
>  ```
>  FileType|Relative/path/and/filename.ext|DEBUG|GCC|UNIXGCC|TRUE
>  FileType|Filename.ext|*|GCC
> -FIleType|Relative/path/and/filename.ext|RELEASE
> +FileType|Relative/path/and/filename.ext|RELEASE
>  FileType|Filename.ext|RELEASE
>  FileType|Filename.ext
>  ```
> @@ -170,6 +170,11 @@ This binary is an `EFI_SECTION_COMPATIBILTY16 leaf` section.
>  
>  This binary is an `EFI_SECTION_FIRMWARE_VOLUME_IMAGE` leaf section.
>  
> +**_LIB_**
> +
> +This binary is a pre-built library instance that provides the library class
> +defined in the `LIBRARY_CLASS` statement in the `[Defines]` section.
> +
>  **********
>  **Note:** The section names listed above refer to leaf section type values
>  rather than the name of the data structure.
> diff --git a/3_edk_ii_inf_file_format/315_[binaries]_section.md b/3_edk_ii_inf_file_format/315_[binaries]_section.md
> index 7a03547..d6d57f2 100644
> --- a/3_edk_ii_inf_file_format/315_[binaries]_section.md
> +++ b/3_edk_ii_inf_file_format/315_[binaries]_section.md
> @@ -110,7 +110,7 @@ included in any one `[Binaries]` section.
>  <Edk2FileType>       ::= {"ACPI"} {"ASL"} {"PE32"} {"PIC"} {"FV"}
>                           {"PEI_DEPEX"} {"DXE_DEPEX"} {"SMM_DEPEX"}
>                           {"TE"} {"BIN"} {"RAW"} {"COMPAT16"}
> -                         {"DISPOSABLE"}
> +                         {"DISPOSABLE"} {"LIB"}
>  ```
>  
>  #### Parameters
> diff --git a/README.md b/README.md
> index 57e05d2..e2ffcb9 100644
> --- a/README.md
> +++ b/README.md
> @@ -192,4 +192,5 @@ Copyright (c) 2007-2017, Intel Corporation. All rights reserved.
>  |            | Updated other sections to specify how the build system will evaluate the Feature Flag Expression                                                                                                                                                                                    |               |
>  |            | Prohibit using #include statements in UNI files specified in the MODULE_UNI_FILE entry                                                                                                                                                                                              |               |
>  | 1.25       | Revised WORKSPACE wording for updated build system that can handle packages located outside of the WORKSPACE directory tree (refer to the TianoCore.org/EDKII website for additional instructions on setting up a development environment).                                         | January 2016  |
> -| 1.26       | Convert to GitBooks                                                                                                                                                                                                                                                                 | March 2017    |
> +| 1.26       | Convert to GitBooks                                                                                                                                                                                                                                                                 | May 2017      |
> +|            | [#463](https://bugzilla.tianocore.org/show_bug.cgi?id=463) INF spec: document the LIB file type under the [Binaries] Section                                                                                                                                                        |               |
> 




  reply	other threads:[~2017-05-29 11:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-27  0:49 [edk2-InfSpecification PATCH] Add LIB to supported file types in [Binaries] section Michael Kinney
2017-05-27  0:49 ` Michael Kinney
2017-05-29 11:27   ` Laszlo Ersek [this message]
2017-05-31  1:50   ` Zhu, Yonghong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e55c7297-c123-1e43-951e-244cd291153e@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox