From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mx.groups.io with SMTP id smtpd.web12.9405.1631789132607838595 for ; Thu, 16 Sep 2021 03:45:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=WBWzwwKW; spf=pass (domain: nuviainc.com, ip: 209.85.210.170, mailfrom: rebecca@nuviainc.com) Received: by mail-pf1-f170.google.com with SMTP id y17so5440764pfl.13 for ; Thu, 16 Sep 2021 03:45:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=OasUs5/16UgNFNp92foG6w+nqvjcyl8LFndjF1d3/ec=; b=WBWzwwKWRI7zbUf2EaciOxQ/kCalNIzkmjIL0puZNnb036Nu9RFJnJB36SX1ry96m2 3Kv6D4OsG5aLEw7a5UseEh6xMb316so0OWFjcIszQwtzyhdXOXzcs8B47NqHNMfTzC3v gkTWw5ooVmM7SUotSPTwxY1bD3zIV/0rCIl2/VH6iAzCB9a9+0Els2CaTPX19JDJtx7H QD4RYsBxSxXpA2ieYHv+HJIOGKEUauInMs26SwxkKVS3ZnPismLIbo5cOJHn5nLgZV4n QVvR5s5OeFGHZpDQxrIZsox6zsaDAfE6zMBjigNegW05Av0xYvSCj2ItdDmJbwTS4WcE SeJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=OasUs5/16UgNFNp92foG6w+nqvjcyl8LFndjF1d3/ec=; b=maLGGgxd50oFThLIynS5kZ6oDOgi4T4viTPrRAyVkftPYEzLhAmW1Q7GixbVB2djIa EcWAkxBuM3w+9iwJszz91LN9/VJXH1p44z8bOT/8VbGo8z2+v/5/JpRbtvix01tAnjgT ZI+IoTNs8jRab2F+yO1JZ8nVyb/i0cv0SWAX6FDv3P2nGiJU6MS3dP7fH5TBAEFsQ6I7 T/A8pdjGJkxodQ4qJjuBfAsybD7Reyo2lDpqkYePjTW/4dkfoNH6n9knQYnXVfxhNpO2 Aj5DP+khj2QtZlll7nPGXwxoTNiy/EPv8TD0N1j9jowREDf4+hySUjODfIsDHhcnvG0H KW0w== X-Gm-Message-State: AOAM530CAuvJvxQ69HmcGU1iFJ/gV87GBs7Ld2KqZD5OSeuiMp4ud3kd r1Tt/L545yN8OY/O+QipUWwItg== X-Google-Smtp-Source: ABdhPJyNFD3hfynIJrr1cVSf1wqkQ+JqGI47vjLXBMsm/xPPQdUHQ9sl7OIgKmbx8NMDcWQLY4irGg== X-Received: by 2002:a05:6a00:1686:b0:413:d52a:1d37 with SMTP id k6-20020a056a00168600b00413d52a1d37mr4547705pfc.26.1631789132184; Thu, 16 Sep 2021 03:45:32 -0700 (PDT) Return-Path: Received: from linbox.int.bluestop.org (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id e19sm2552209pfi.139.2021.09.16.03.45.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Sep 2021 03:45:31 -0700 (PDT) Subject: Re: [PATCH 1/1] ArmPkg/ProcessorSubClassDxe: Fix the format of ProcessorId To: Nhi Pham , devel@edk2.groups.io Cc: patches@amperecomputing.com, Leif Lindholm , Ard Biesheuvel References: <20210915135532.3465-1-nhi@os.amperecomputing.com> From: "Rebecca Cran" Message-ID: Date: Thu, 16 Sep 2021 04:45:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210915135532.3465-1-nhi@os.amperecomputing.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Reviewed-by: Rebecca Cran -- Rebecca Cran On 9/15/21 7:55 AM, Nhi Pham wrote: > According to SMBIOS 3.4, section 7.5.3.3 ARM64-class CPUs, if > SMCCC_ARCH_SOC_ID is supported, the first DWORD is the JEP-106 code and > the second DWORD is the SoC revision value. But in the current > implementation, they are set in reverse. This patch is to correct it. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Rebecca Cran > Signed-off-by: Nhi Pham > --- > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c > index 292f10bf97eb..d644cd33d249 100644 > --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c > +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c > @@ -2,6 +2,7 @@ > Functions for processor information common to ARM and AARCH64. > > Copyright (c) 2021, NUVIA Inc. All rights reserved.
> + Copyright (c) 2021, Ampere Computing LLC. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -171,7 +172,7 @@ SmbiosGetProcessorId ( > > if (HasSmcArm64SocId ()) { > SmbiosGetSmcArm64SocId (&Jep106Code, &SocRevision); > - ProcessorId = ((UINT64)Jep106Code << 32) | SocRevision; > + ProcessorId = ((UINT64)SocRevision << 32) | Jep106Code; > } else { > ProcessorId = ArmReadMidr (); > }