From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A059EAC0AAF for ; Wed, 3 Jan 2024 09:52:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wipHqDsv1qFP7qFdTwK+Vl2wsM/fhCUTea0ehhNWIdY=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1704275572; v=1; b=kupElNXKr6MNoMsROKDFHi7XFL4CcyrJrYa+oGqF92UVhFzzlRXHSXIpxvjTiSKa7lm08ua6 xIb/CGD6xjh/rwaIDZbop1T53v5TLuxpdxX8nS4g/YSkU/8NsLdDlyCazEbLfWPWOWHSd6vg7SQ D1B1MUWZ36EJPEBPf1vkslQE= X-Received: by 127.0.0.2 with SMTP id MXkXYY7687511x0Jr8BLguRb; Wed, 03 Jan 2024 01:52:52 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.81]) by mx.groups.io with SMTP id smtpd.web10.14450.1704275571563757137 for ; Wed, 03 Jan 2024 01:52:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FxLlriZzOt5OjhwZZ3xHMqEMo3Y/ZLqCUzdbnTfE+68KoZMev05Fv6GRtPLLLD8VVnv3EFnm8peBg9MU5+UBPbf5GnlcUXamLJHbQq4aJIX+2RnTfaQr6KSs6sn1wRvCpgkzh8DqsI1NXh99V2aNuvDwOH4MZX3Fg8lPJb1rfINgkkov07a4nVfFYSEriNb9cHKyvt4RSz77PpwP974i5Qbyqdk4YuYmdgxP+hr+ldQTWYto476eGP2aLOy4+XN8GjSKZmnCx7x92Q8Red2lXji0v5JQ7ugyW7aidA2TpWYToBwnCZNv8rsVMCnY9maeeJpxoRFanjvk9evm/ufRhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hRZQSGGEpyzaH6iSWrihT511XtmJgYtwzYPYTYpdVY8=; b=PFqyzs5GbOUsCcO+FeoFCH7ImcweAufsk0dHo+z03FPyyshk5N0DtEyCm0XxyYqOjgPs4GWZDrTWKK7Dey/spjHRZ1+HIvdo0MF2HJT5gteNjDoO0P27EGOgAhfZLyHd8trjub7H7F1XvFYbRtkjEWbKHaAb80n9VceaBPa0W+BTQ2PyCbA9kgi0UpodQHJCPVl9Ck4OvpURewIqDWdCvloQWlotg0LdwxPmrhGe5Qo2natOsQGM9OXJFzS2o/F/1GIUfqECuHZ2bIgx2oj6yfkMZNT9GxIU6CEI+kWI0tKga777YjtiIE7yV0dlq6r2SbNEwcNGka8YCMtdgPL9qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from SA9PR13CA0081.namprd13.prod.outlook.com (2603:10b6:806:23::26) by SA3PR12MB7921.namprd12.prod.outlook.com (2603:10b6:806:320::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.25; Wed, 3 Jan 2024 09:52:49 +0000 X-Received: from SN1PEPF0002636E.namprd02.prod.outlook.com (2603:10b6:806:23:cafe::2f) by SA9PR13CA0081.outlook.office365.com (2603:10b6:806:23::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.13 via Frontend Transport; Wed, 3 Jan 2024 09:52:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF0002636E.mail.protection.outlook.com (10.167.241.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7159.9 via Frontend Transport; Wed, 3 Jan 2024 09:52:49 +0000 X-Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 3 Jan 2024 03:52:47 -0600 X-Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 3 Jan 2024 03:52:46 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Wed, 3 Jan 2024 03:52:45 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [PATCH v2 2/2] DynamicTablesPkg: Fix IA32 compilation errors Date: Wed, 3 Jan 2024 15:22:39 +0530 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636E:EE_|SA3PR12MB7921:EE_ X-MS-Office365-Filtering-Correlation-Id: baef91c9-c151-4089-43a8-08dc0c41bf02 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 7kW7DGdtHUHtIu0jmpQafaZLv1muCAtoe0HBMrcM+iCBJlXIzHleJGAmVvhv6LCqKJ2i35yRQDyUJwYQ+y4pvdJFhWCezNizJOQnLLF92ZonVbgYqiedTZ64NsOSlq2rYynwEtxNB8ZyplnOtiRZjOSD/hm68us8lZ6IyO0lhBTQrJFtbZVw99jWxe86EhMvIgZ94N5g4NucWWUI1L0C9n4IVEOwUmg+IAsonVZ546bjqFv4ZdfQjsx1dCd0IGPNbcZkj3Mrv+dDCw7epGZnBFNHkTYLyxw01JQNsZ9CcRKkjclsjG87WAiEyFOMMvyaiMb2+A1GJm8HlK8fapdiIhwovIvraqy5656GROO6+DMEWSHcS6m7CHcbS6N4zsmi2oqD8xlCogTmXASEqMstnIPpofiGbKm615gFUgTbcmm5GDBZCfpyPDX7OoUNCilx2K8B/9bPBk05Xl/SRomG0dPADCdxZZgxf7NoyycL5khM/3vjJ/21R4oP9W/0i3VYpa6p3qZ0Cm9lTt2nK79Mxcl5wC1bwFgFbkwwGrUzfSeDCFaDUkewLIsvRCBSYm+B4DjKkEZqqFMUW7ACqC75sygI7LMF53BGaTldYqTzen3n34rS9M4YipSBcBPUCH4DN1KFKNkcX8/slAQ5Z45tEtOk0pkY58fKJMatbjBd+yQFV/vW6kyyXS1Dk6DASXxeNHih5b4tc9df1hFfJb0Vre9mqNqDE1JQW7xFiK1WU96s6QwjGwAn6AE+oaX8kpe+DQYoKhvO8kB7JGFjINqfc5bmFTkuzWVNjeoneIIhQLJXiUSzYcbZqMU2oI9Wom2x X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 09:52:49.5990 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: baef91c9-c151-4089-43a8-08dc0c41bf02 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002636E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7921 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8xrgjuBdW6KxJOheFXHPjJH2x7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=kupElNXK; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: Abdul Lateef Attar Add the support for X64 compilation to the CI. - Fix the signed and unsigned variable comparision. warning C4018: '>': signed/unsigned mismatch - Fix the NOOPT build error for IA32 by replacing 64bit shift operator with LShiftU64. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar --- DynamicTablesPkg/DynamicTablesPkg.dsc | 2 +- .../Common/TableHelperLib/ConfigurationManagerObjectParser.c | 2 +- DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/Dynam= icTablesPkg.dsc index a2db14efaf..2f35ac82f2 100644 --- a/DynamicTablesPkg/DynamicTablesPkg.dsc +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc @@ -15,7 +15,7 @@ PLATFORM_VERSION =3D 0.1 DSC_SPECIFICATION =3D 0x0001001a OUTPUT_DIRECTORY =3D Build/DynamicTables - SUPPORTED_ARCHITECTURES =3D ARM|AARCH64|X64 + SUPPORTED_ARCHITECTURES =3D ARM|AARCH64|IA32|X64 BUILD_TARGETS =3D DEBUG|RELEASE|NOOPT SKUID_IDENTIFIER =3D DEFAULT =20 diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationMa= nagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/Config= urationManagerObjectParser.c index ce494816ed..c1a7528419 100644 --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerOb= jectParser.c +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerOb= jectParser.c @@ -1130,7 +1130,7 @@ ParseCmObjDesc ( &RemainingSize, 1 ); - if ((RemainingSize > CmObjDesc->Size) || + if ((RemainingSize > (INTN)CmObjDesc->Size) || (RemainingSize < 0)) { ASSERT (0); diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c b= /DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c index e33d6e656b..12c67b9811 100644 --- a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c @@ -170,7 +170,7 @@ AddAcpiHeader ( CfgMfrInfo->OemId[2], CfgMfrInfo->OemId[3] ) | - ((UINT64)Generator->AcpiTableSignature << 32)= ; + LShiftU64 ((UINT64)Generator->AcpiTableSignat= ure, 32); } =20 // UINT32 OemRevision @@ -257,7 +257,7 @@ AddSsdtAcpiHeader ( CfgMfrInfo->OemId[2], CfgMfrInfo->OemId[3] ) | - ((UINT64)Generator->AcpiTableSignature << 32); + LShiftU64 ((UINT64)Generator->AcpiTableSignature, 32); } =20 if (AcpiTableInfo->OemRevision !=3D 0) { --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113064): https://edk2.groups.io/g/devel/message/113064 Mute This Topic: https://groups.io/mt/103499170/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-