From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web11.20228.1574166343255593498 for ; Tue, 19 Nov 2019 04:25:43 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=f24IR/go; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.66, mailfrom: pete@akeo.ie) Received: by mail-wr1-f66.google.com with SMTP id l7so23584768wrp.6 for ; Tue, 19 Nov 2019 04:25:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3yuuOHeOiBf+pfFgGxid23+VQBCcgLR2fJbAXNybHlI=; b=f24IR/go0hFNS5tAKJmG6vu0vknb8vwYp5tpE2mFTVHFvUEZDleaOEm/0VpQTbiEqP FttvZDgdNVYr1zHK938C8obKcpgROEytzPoufbRhsa+GCdiRcvkfZtvUZsg3ChHvqQju hZ2AxbQZlaII6JT2THKp7eAsOWST1/uw1+z3giaLZeFfMZKGr6d4pzqc6AgHevkW2tqv Rw86G7EhI2qnVkJpCW+FZOQ5XSsabWPxalgGyljd9AzKO5O/q/djfO211mZMnB9zR/2K pE3mXfvRNkOG1A8hr/pGM5U6DULUzK5LNUnuQtgOKiFYnOPwaoWQwuC8eDfFk6EBPsfw XzGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3yuuOHeOiBf+pfFgGxid23+VQBCcgLR2fJbAXNybHlI=; b=ldxuBFgXp1AxLqjpyMATneHt0IBWxV8rDhCz+roBDBkd70FwqW01nJ1ynkfn3MpC6Q Pvb7yQiI8XZwcXqSCSOUXA9H7mcDhYFKfyOPrZ1090u1elFefOwvqzZ8+Ddz0UpE+4zr 7Dilpw6el62d3J3cnYueCF4EI9cZoVtCovj0ZpFUJjp9J9Lj/XXJ5OhJrpRtFIg8xwur YBGXrA3BnioHVEdig6Z+VHdRA2h70tMDlGogyLZK268yKzNuxFl4iBnSRo34SgkPR0vG Tr3h1jFiW/B/jBVy4UZOYQr+VGDN93MwjPJxmgAZ7MfibxAdENgODk7SvuzPw6pUYvZa yyrA== X-Gm-Message-State: APjAAAUfgNB1+TWCW6O8Av+WGO/bw9jyd5GF1V6yAg/D6+DwaEW1ycSC B0mKPfT1m28KfK4aDzTjRagZDA== X-Google-Smtp-Source: APXvYqyAb+cwKLKgQU7yZRdFyfJmbgqfrvdB7NMK2u0W9uf7WzoQPjnG3fM0IZ+Pf/fynpJXxBNYwA== X-Received: by 2002:adf:979a:: with SMTP id s26mr37700196wrb.92.1574166341527; Tue, 19 Nov 2019 04:25:41 -0800 (PST) Return-Path: Received: from [10.0.0.122] ([84.203.67.47]) by smtp.googlemail.com with ESMTPSA id m16sm2777695wml.47.2019.11.19.04.25.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Nov 2019 04:25:40 -0800 (PST) Subject: Re: [edk2-platforms][PATCH v2 1/7] Platform/RPi: Add missing model name To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, samer.el-haj-mahmoud@arm.com References: <20191119113809.2472-1-pete@akeo.ie> <20191119113809.2472-2-pete@akeo.ie> <23bdf10d-77fd-542e-2e99-65827d09a4ba@redhat.com> From: "Pete Batard" Message-ID: Date: Tue, 19 Nov 2019 12:25:39 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <23bdf10d-77fd-542e-2e99-65827d09a4ba@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 2019.11.19 12:02, Philippe Mathieu-Daudé wrote: > On 11/19/19 12:38 PM, Pete Batard wrote: >> From: Samer El-Haj-Mahmoud >> >> Add a missing entry for the "Raspberry Pi Compute Module 3+" in >> RpiFirmwareGetModelName (). >> >> Signed-off-by: Leif Lindholm > > I feel really lost with how the S-o-b are handled. If you look at the thread, you'll see that Leif provided a patch (he basically split a patch from the existing), which he signed of. I therefore included it as is. Hence the S-o-b being Leif here. But yeah, I agree this whole business is confusing. Regards, /Pete > > I'd have expected, Samer as the author, signs it. Pete forwards it, then > Leif refactors a bit by extracting a part of the previous bigger patch. > So: > > Signed-off-by: Samer El-Haj-Mahmoud > Signed-off-by: Pete Batard > Signed-off-by: Leif Lindholm > > Anyway, back to the technical content: > Reviewed-by: Philippe Mathieu-Daude > >> --- >>   Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 3 +++ >>   1 file changed, 3 insertions(+) >> >> diff --git >> a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c >> b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c >> index 9b4aa068857c..dcb434fabefe 100644 >> --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c >> +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c >> @@ -1,5 +1,6 @@ >>   /** @file >>    * >> + *  Copyright (c) 2019, ARM Limited. All rights reserved. >>    *  Copyright (c) 2017-2018, Andrei Warkentin >> >>    *  Copyright (c) 2016, Linaro, Ltd. All rights reserved. >>    * >> @@ -595,6 +596,8 @@ RpiFirmwareGetModelName ( >>       return "Raspberry Pi 3 Model B+"; >>     case 0x0E: >>       return "Raspberry Pi 3 Model A+"; >> +  case 0x10: >> +    return "Raspberry Pi Compute Module 3+"; >>     case 0x11: >>       return "Raspberry Pi 4 Model B"; >>     default: >> >