[Patch 1/1] EmulatorPkg/PlatformCI: stick with "ubuntu-18.04" for now

[Patch 1/1] EmulatorPkg/PlatformCI: stick with "ubuntu-18.04" for now

[Bob Feng]

"vm_image: 'ubuntu-latest'" now refers to Ubuntu Focal (20.04LTS), not
Ubuntu Bionic (18.04LTS), according to
<https://github.com/actions/virtual-environments/issues/1816>.

In Focal, the "qemu" package is a dummy package with no dependencies, and
so the actual emulators are not pulled in. Compare:

  https://packages.ubuntu.com/bionic/qemu
  https://packages.ubuntu.com/focal/qemu

This causes CI runs to fail.

It would be best to switch to the "qemu-system" package name, which
continues to depend on the emulators:

  https://packages.ubuntu.com/bionic/qemu-system
  https://packages.ubuntu.com/focal/qemu-system

However, while that package does make the emulators available, the
emulators crash. So for now, stick with the previous Ubuntu environment,
which continues to be supported, per
<https://github.com/actions/virtual-environments/issues/1816>.

Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
---
 EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
index 0e5f4d9961e3..17d62bb69ec5 100644
--- a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
+++ b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
@@ -15,11 +15,11 @@ pr:
   - master
 jobs:
   - job: Platform_CI
     variables:
       package: 'EmulatorPkg'
-      vm_image: 'ubuntu-latest'
+      vm_image: 'ubuntu-18.04'
       should_run: false
       run_flags: "MAKE_STARTUP_NSH=TRUE"
 
     #Use matrix to speed up the build process
     strategy:
-- 
2.29.1.windows.1

Re: [edk2-devel] [Patch 1/1] EmulatorPkg/PlatformCI: stick with "ubuntu-18.04" for now

[Laszlo Ersek]

On 12/21/20 04:19, Bob Feng wrote:
> "vm_image: 'ubuntu-latest'" now refers to Ubuntu Focal (20.04LTS), not
> Ubuntu Bionic (18.04LTS), according to
> <https://github.com/actions/virtual-environments/issues/1816>.
> 
> In Focal, the "qemu" package is a dummy package with no dependencies, and
> so the actual emulators are not pulled in. Compare:
> 
>   https://packages.ubuntu.com/bionic/qemu
>   https://packages.ubuntu.com/focal/qemu
> 
> This causes CI runs to fail.
> 
> It would be best to switch to the "qemu-system" package name, which
> continues to depend on the emulators:
> 
>   https://packages.ubuntu.com/bionic/qemu-system
>   https://packages.ubuntu.com/focal/qemu-system
> 
> However, while that package does make the emulators available, the
> emulators crash. So for now, stick with the previous Ubuntu environment,
> which continues to be supported, per
> <https://github.com/actions/virtual-environments/issues/1816>.
> 
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> index 0e5f4d9961e3..17d62bb69ec5 100644
> --- a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> @@ -15,11 +15,11 @@ pr:
>    - master
>  jobs:
>    - job: Platform_CI
>      variables:
>        package: 'EmulatorPkg'
> -      vm_image: 'ubuntu-latest'
> +      vm_image: 'ubuntu-18.04'
>        should_run: false
>        run_flags: "MAKE_STARTUP_NSH=TRUE"
>  
>      #Use matrix to speed up the build process
>      strategy:
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

I'm going to merge this at once, because it's blocking other pull
requests.

I can see that this patch reuses the commit message from my commits
90683caedf1e ("ArmVirtPkg/PlatformCI: stick with "ubuntu-18.04" for
now", 2020-12-18) and c487970ac89d ("OvmfPkg/PlatformCI: stick with
"ubuntu-18.04" for now", 2020-12-18).

When I wrote those patches, I obviously did *not* miss EmulatorPkg.
However, EmulatorPkg does not use QEMU in CI -- that's the reason my
series did not cover EmulatorPkg. I did not foresee any reason for
EmulatorPkg's CI tasks to fail with Ubuntu 20.04LTS.

And now that I'm actually checking such an (unexpected) failure, it's
not QEMU-related. Instead, it's a GCC issue:

https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=17230&view=logs&j=7cda4867-6a98-5508-f20e-3046bf80e19c&t=9a255493-65b4-5c45-e228-bf6eb3567b30&l=1150

> INFO - "gcc" -o /home/vsts/work/1/s/Build/EmulatorIA32/DEBUG_GCC5/IA32/Host -m32 -L/usr/X11R6/lib -Wl,--start-group,@/home/vsts/work/1/s/Build/EmulatorIA32/DEBUG_GCC5/IA32/EmulatorPkg/Unix/Host/Host/OUTPUT/static_library_files.lst,--end-group -lpthread -ldl -lXext -lX11
> INFO - /usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-linux-gnu/9/libgcc.a when searching for -lgcc
> INFO - /usr/bin/ld: cannot find -lgcc
> INFO - /usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-linux-gnu/9/libgcc.a when searching for -lgcc
> INFO - /usr/bin/ld: cannot find -lgcc
> INFO - collect2: error: ld returned 1 exit status
> INFO - make: *** [GNUmakefile:421: /home/vsts/work/1/s/Build/EmulatorIA32/DEBUG_GCC5/IA32/EmulatorPkg/Unix/Host/Host/DEBUG/Host] Error 1

Therefore, when I merge this patch, I will update the commit message to
refer to a GCC linking issue rather than to QEMU.

Thanks
Laszlo

Re: [edk2-devel] [Patch 1/1] EmulatorPkg/PlatformCI: stick with "ubuntu-18.04" for now

[Laszlo Ersek]

On 12/21/20 14:47, Laszlo Ersek wrote:
> On 12/21/20 04:19, Bob Feng wrote:
>> "vm_image: 'ubuntu-latest'" now refers to Ubuntu Focal (20.04LTS), not
>> Ubuntu Bionic (18.04LTS), according to
>> <https://github.com/actions/virtual-environments/issues/1816>.
>>
>> In Focal, the "qemu" package is a dummy package with no dependencies, and
>> so the actual emulators are not pulled in. Compare:
>>
>>   https://packages.ubuntu.com/bionic/qemu
>>   https://packages.ubuntu.com/focal/qemu
>>
>> This causes CI runs to fail.
>>
>> It would be best to switch to the "qemu-system" package name, which
>> continues to depend on the emulators:
>>
>>   https://packages.ubuntu.com/bionic/qemu-system
>>   https://packages.ubuntu.com/focal/qemu-system
>>
>> However, while that package does make the emulators available, the
>> emulators crash. So for now, stick with the previous Ubuntu environment,
>> which continues to be supported, per
>> <https://github.com/actions/virtual-environments/issues/1816>.
>>
>> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> ---
>>  EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>> index 0e5f4d9961e3..17d62bb69ec5 100644
>> --- a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>> +++ b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>> @@ -15,11 +15,11 @@ pr:
>>    - master
>>  jobs:
>>    - job: Platform_CI
>>      variables:
>>        package: 'EmulatorPkg'
>> -      vm_image: 'ubuntu-latest'
>> +      vm_image: 'ubuntu-18.04'
>>        should_run: false
>>        run_flags: "MAKE_STARTUP_NSH=TRUE"
>>  
>>      #Use matrix to speed up the build process
>>      strategy:
>>
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> I'm going to merge this at once, because it's blocking other pull
> requests.
> 
> I can see that this patch reuses the commit message from my commits
> 90683caedf1e ("ArmVirtPkg/PlatformCI: stick with "ubuntu-18.04" for
> now", 2020-12-18) and c487970ac89d ("OvmfPkg/PlatformCI: stick with
> "ubuntu-18.04" for now", 2020-12-18).
> 
> When I wrote those patches, I obviously did *not* miss EmulatorPkg.
> However, EmulatorPkg does not use QEMU in CI -- that's the reason my
> series did not cover EmulatorPkg. I did not foresee any reason for
> EmulatorPkg's CI tasks to fail with Ubuntu 20.04LTS.
> 
> And now that I'm actually checking such an (unexpected) failure, it's
> not QEMU-related. Instead, it's a GCC issue:
> 
> https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=17230&view=logs&j=7cda4867-6a98-5508-f20e-3046bf80e19c&t=9a255493-65b4-5c45-e228-bf6eb3567b30&l=1150
> 
>> INFO - "gcc" -o /home/vsts/work/1/s/Build/EmulatorIA32/DEBUG_GCC5/IA32/Host -m32 -L/usr/X11R6/lib -Wl,--start-group,@/home/vsts/work/1/s/Build/EmulatorIA32/DEBUG_GCC5/IA32/EmulatorPkg/Unix/Host/Host/OUTPUT/static_library_files.lst,--end-group -lpthread -ldl -lXext -lX11
>> INFO - /usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-linux-gnu/9/libgcc.a when searching for -lgcc
>> INFO - /usr/bin/ld: cannot find -lgcc
>> INFO - /usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-linux-gnu/9/libgcc.a when searching for -lgcc
>> INFO - /usr/bin/ld: cannot find -lgcc
>> INFO - collect2: error: ld returned 1 exit status
>> INFO - make: *** [GNUmakefile:421: /home/vsts/work/1/s/Build/EmulatorIA32/DEBUG_GCC5/IA32/EmulatorPkg/Unix/Host/Host/DEBUG/Host] Error 1
> 
> Therefore, when I merge this patch, I will update the commit message to
> refer to a GCC linking issue rather than to QEMU.

I have also filed:

https://github.com/actions/virtual-environments/issues/2324

Thanks
Laszlo

Re: [edk2-devel] [Patch 1/1] EmulatorPkg/PlatformCI: stick with "ubuntu-18.04" for now

[Laszlo Ersek]

On 12/21/20 04:19, Bob Feng wrote:
> "vm_image: 'ubuntu-latest'" now refers to Ubuntu Focal (20.04LTS), not
> Ubuntu Bionic (18.04LTS), according to
> <https://github.com/actions/virtual-environments/issues/1816>.
> 
> In Focal, the "qemu" package is a dummy package with no dependencies, and
> so the actual emulators are not pulled in. Compare:
> 
>   https://packages.ubuntu.com/bionic/qemu
>   https://packages.ubuntu.com/focal/qemu
> 
> This causes CI runs to fail.
> 
> It would be best to switch to the "qemu-system" package name, which
> continues to depend on the emulators:
> 
>   https://packages.ubuntu.com/bionic/qemu-system
>   https://packages.ubuntu.com/focal/qemu-system
> 
> However, while that package does make the emulators available, the
> emulators crash. So for now, stick with the previous Ubuntu environment,
> which continues to be supported, per
> <https://github.com/actions/virtual-environments/issues/1816>.
> 
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> index 0e5f4d9961e3..17d62bb69ec5 100644
> --- a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> @@ -15,11 +15,11 @@ pr:
>    - master
>  jobs:
>    - job: Platform_CI
>      variables:
>        package: 'EmulatorPkg'
> -      vm_image: 'ubuntu-latest'
> +      vm_image: 'ubuntu-18.04'
>        should_run: false
>        run_flags: "MAKE_STARTUP_NSH=TRUE"
>  
>      #Use matrix to speed up the build process
>      strategy:
> 

Merged as commit 3ce3274a5ea4, via
<https://github.com/tianocore/edk2/pull/1255>.

Thanks,
Laszlo

Re: [edk2-devel] [Patch 1/1] EmulatorPkg/PlatformCI: stick with "ubuntu-18.04" for now

[Bob Feng]

Thank you Laszlo.

Thanks,
Bob

-----Original Message-----
From: Laszlo Ersek <lersek@redhat.com> 
Sent: Monday, December 21, 2020 10:53 PM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>
Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
Subject: Re: [edk2-devel] [Patch 1/1] EmulatorPkg/PlatformCI: stick with "ubuntu-18.04" for now

On 12/21/20 04:19, Bob Feng wrote:
> "vm_image: 'ubuntu-latest'" now refers to Ubuntu Focal (20.04LTS), not 
> Ubuntu Bionic (18.04LTS), according to 
> <https://github.com/actions/virtual-environments/issues/1816>.
> 
> In Focal, the "qemu" package is a dummy package with no dependencies, 
> and so the actual emulators are not pulled in. Compare:
> 
>   https://packages.ubuntu.com/bionic/qemu
>   https://packages.ubuntu.com/focal/qemu
> 
> This causes CI runs to fail.
> 
> It would be best to switch to the "qemu-system" package name, which 
> continues to depend on the emulators:
> 
>   https://packages.ubuntu.com/bionic/qemu-system
>   https://packages.ubuntu.com/focal/qemu-system
> 
> However, while that package does make the emulators available, the 
> emulators crash. So for now, stick with the previous Ubuntu 
> environment, which continues to be supported, per 
> <https://github.com/actions/virtual-environments/issues/1816>.
> 
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml 
> b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> index 0e5f4d9961e3..17d62bb69ec5 100644
> --- a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> @@ -15,11 +15,11 @@ pr:
>    - master
>  jobs:
>    - job: Platform_CI
>      variables:
>        package: 'EmulatorPkg'
> -      vm_image: 'ubuntu-latest'
> +      vm_image: 'ubuntu-18.04'
>        should_run: false
>        run_flags: "MAKE_STARTUP_NSH=TRUE"
>  
>      #Use matrix to speed up the build process
>      strategy:
> 

Merged as commit 3ce3274a5ea4, via
<https://github.com/tianocore/edk2/pull/1255>.

Thanks,
Laszlo

Re: [edk2-devel] [Patch 1/1] EmulatorPkg/PlatformCI: stick with "ubuntu-18.04" for now

[Sean]

Looks like the switch to Ubuntu 20.04 was pretty negatively impactful. 
Thanks Laszlo for tracking this down.

Question to the community (especially those using a Linux environment) 
is what priority should it be to go resolve these and update CI to run 
on Ubuntu 20.04?  General premise is we should stay current without 
being bleeding edge but I want to understand other perspectives.

Thanks
Sean



On 12/21/2020 6:53 AM, Laszlo Ersek wrote:
> On 12/21/20 04:19, Bob Feng wrote:
>> "vm_image: 'ubuntu-latest'" now refers to Ubuntu Focal (20.04LTS), not
>> Ubuntu Bionic (18.04LTS), according to
>> <https://github.com/actions/virtual-environments/issues/1816>.
>>
>> In Focal, the "qemu" package is a dummy package with no dependencies, and
>> so the actual emulators are not pulled in. Compare:
>>
>>    https://packages.ubuntu.com/bionic/qemu
>>    https://packages.ubuntu.com/focal/qemu
>>
>> This causes CI runs to fail.
>>
>> It would be best to switch to the "qemu-system" package name, which
>> continues to depend on the emulators:
>>
>>    https://packages.ubuntu.com/bionic/qemu-system
>>    https://packages.ubuntu.com/focal/qemu-system
>>
>> However, while that package does make the emulators available, the
>> emulators crash. So for now, stick with the previous Ubuntu environment,
>> which continues to be supported, per
>> <https://github.com/actions/virtual-environments/issues/1816>.
>>
>> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> ---
>>   EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>> index 0e5f4d9961e3..17d62bb69ec5 100644
>> --- a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>> +++ b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>> @@ -15,11 +15,11 @@ pr:
>>     - master
>>   jobs:
>>     - job: Platform_CI
>>       variables:
>>         package: 'EmulatorPkg'
>> -      vm_image: 'ubuntu-latest'
>> +      vm_image: 'ubuntu-18.04'
>>         should_run: false
>>         run_flags: "MAKE_STARTUP_NSH=TRUE"
>>   
>>       #Use matrix to speed up the build process
>>       strategy:
>>
> 
> Merged as commit 3ce3274a5ea4, via
> <https://github.com/tianocore/edk2/pull/1255>.
> 
> Thanks,
> Laszlo
> 
> 
> 
> 
> 
> 

Re: [edk2-devel] [Patch 1/1] EmulatorPkg/PlatformCI: stick with "ubuntu-18.04" for now

[Rebecca Cran]

On 1/8/21 11:01 AM, Sean wrote:

> Question to the community (especially those using a Linux environment) 
> is what priority should it be to go resolve these and update CI to run 
> on Ubuntu 20.04?  General premise is we should stay current without 
> being bleeding edge but I want to understand other perspectives.

 From previous discussions, it sounds like we did want to be on the 
bleeding edge - which I personally think is a bad idea, since breaking 
changes can come in at the worst time.

Instead, we should stay on a stable release but watch out for newer 
versions and move forward to them after applying any fixes.

-- 
Rebecca Cran

Re: [edk2-devel] [Patch 1/1] EmulatorPkg/PlatformCI: stick with "ubuntu-18.04" for now

[Laszlo Ersek]

On 01/08/21 19:14, Rebecca Cran wrote:
> On 1/8/21 11:01 AM, Sean wrote:
> 
>> Question to the community (especially those using a Linux environment)
>> is what priority should it be to go resolve these and update CI to run
>> on Ubuntu 20.04?  General premise is we should stay current without
>> being bleeding edge but I want to understand other perspectives.
> 
> From previous discussions, it sounds like we did want to be on the
> bleeding edge - which I personally think is a bad idea, since breaking
> changes can come in at the worst time.
> 
> Instead, we should stay on a stable release but watch out for newer
> versions and move forward to them after applying any fixes.
> 

I'm all for sticking with stable artifacts, but:

- we don't know *how long* the github.com/actions organization intends
to support the 18.04 LTS image

- the breakage with 20.04 LTS indeed hit us at a bad time, but at least
we had something to fall back to. If we switch to the oldest supported
VM image, as a permanent choice, then, when that image loses support,
we'll only be able to escape *forward* -- and *that* is an even worse
experience.

It's always the same problem -- production users always want *someone
else* to test out the new release for them.

Instead, what I would really welcome here is if we exempted edk2 patches
that tweaked the CI configuration from the usual patch review process.
Delaying an actual edk2 patch because its review is not complete --
that's fine, that's how development works. On the other hand, blocking
the *merging* of an otherwise reviewed patch, just because the CI system
is broken again, is an *outrage*. Having to submit *further patches to
review* -- this time for the CI config itself --, in order to mitigate
the CI breakage, is a completely broken workflow.

Laszlo

Re: [edk2-devel] [Patch 1/1] EmulatorPkg/PlatformCI: stick with "ubuntu-18.04" for now

[Rebecca Cran]

[-- Attachment #1: Type: text/plain, Size: 2181 bytes --]

Given they still support Ubuntu 16.04 (https://github.com/actions/virtual-environments), I suspect 18.04 will be supported until the upstream EOL in 2023.

— 
Rebeca Cran 

> On Jan 8, 2021, at 11:35 AM, Laszlo Ersek <lersek@redhat.com> wrote:
> 
> On 01/08/21 19:14, Rebecca Cran wrote:
>>> On 1/8/21 11:01 AM, Sean wrote:
>>> 
>>> Question to the community (especially those using a Linux environment)
>>> is what priority should it be to go resolve these and update CI to run
>>> on Ubuntu 20.04?  General premise is we should stay current without
>>> being bleeding edge but I want to understand other perspectives.
>> 
>> From previous discussions, it sounds like we did want to be on the
>> bleeding edge - which I personally think is a bad idea, since breaking
>> changes can come in at the worst time.
>> 
>> Instead, we should stay on a stable release but watch out for newer
>> versions and move forward to them after applying any fixes.
>> 
> 
> I'm all for sticking with stable artifacts, but:
> 
> - we don't know *how long* the github.com/actions organization intends
> to support the 18.04 LTS image
> 
> - the breakage with 20.04 LTS indeed hit us at a bad time, but at least
> we had something to fall back to. If we switch to the oldest supported
> VM image, as a permanent choice, then, when that image loses support,
> we'll only be able to escape *forward* -- and *that* is an even worse
> experience.
> 
> It's always the same problem -- production users always want *someone
> else* to test out the new release for them.
> 
> Instead, what I would really welcome here is if we exempted edk2 patches
> that tweaked the CI configuration from the usual patch review process.
> Delaying an actual edk2 patch because its review is not complete --
> that's fine, that's how development works. On the other hand, blocking
> the *merging* of an otherwise reviewed patch, just because the CI system
> is broken again, is an *outrage*. Having to submit *further patches to
> review* -- this time for the CI config itself --, in order to mitigate
> the CI breakage, is a completely broken workflow.
> 
> Laszlo
> 


[-- Attachment #2: Type: text/html, Size: 3719 bytes --]

Re: [edk2-devel] [Patch 1/1] EmulatorPkg/PlatformCI: stick with "ubuntu-18.04" for now

[Rebecca Cran]

Well, at least Github have said they will only support LTS versions, so 
we'll only run into problems every couple of years with ubuntu-latest.

-- 
Rebecca Cran

On 1/8/21 11:54 AM, Rebecca Cran wrote:
> Given they still support Ubuntu 16.04 
> (https://github.com/actions/virtual-environments 
> <https://github.com/actions/virtual-environments>), I suspect 18.04 will 
> be supported until the upstream EOL in 2023.
> 
> —
> Rebeca Cran
> 
>> On Jan 8, 2021, at 11:35 AM, Laszlo Ersek <lersek@redhat.com> wrote:
>>
>> On 01/08/21 19:14, Rebecca Cran wrote:
>>> On 1/8/21 11:01 AM, Sean wrote:
>>>
>>>> Question to the community (especially those using a Linux environment)
>>>> is what priority should it be to go resolve these and update CI to run
>>>> on Ubuntu 20.04?  General premise is we should stay current without
>>>> being bleeding edge but I want to understand other perspectives.
>>>
>>> From previous discussions, it sounds like we did want to be on the
>>> bleeding edge - which I personally think is a bad idea, since breaking
>>> changes can come in at the worst time.
>>>
>>> Instead, we should stay on a stable release but watch out for newer
>>> versions and move forward to them after applying any fixes.
>>>
>>
>> I'm all for sticking with stable artifacts, but:
>>
>> - we don't know *how long* the github.com/actions organization intends
>> to support the 18.04 LTS image
>>
>> - the breakage with 20.04 LTS indeed hit us at a bad time, but at least
>> we had something to fall back to. If we switch to the oldest supported
>> VM image, as a permanent choice, then, when that image loses support,
>> we'll only be able to escape *forward* -- and *that* is an even worse
>> experience.
>>
>> It's always the same problem -- production users always want *someone
>> else* to test out the new release for them.
>>
>> Instead, what I would really welcome here is if we exempted edk2 patches
>> that tweaked the CI configuration from the usual patch review process.
>> Delaying an actual edk2 patch because its review is not complete --
>> that's fine, that's how development works. On the other hand, blocking
>> the *merging* of an otherwise reviewed patch, just because the CI system
>> is broken again, is an *outrage*. Having to submit *further patches to
>> review* -- this time for the CI config itself --, in order to mitigate
>> the CI breakage, is a completely broken workflow.
>>
>> Laszlo
>>
> 
> 
> 
> 
> 

Re: [edk2-devel] [Patch 1/1] EmulatorPkg/PlatformCI: stick with "ubuntu-18.04" for now

[Laszlo Ersek]

On 01/08/21 21:20, Rebecca Cran wrote:
> Well, at least Github have said they will only support LTS versions, so
> we'll only run into problems every couple of years with ubuntu-latest.
> 

Both of your points seem valid; the one in support of sticking with
18.04 for longer, and the other in support of moving to 20.04 soon.

At this point I'm "less" certain about having to move to 20.04 *soon* --
but, I'm still "quite" certain that's the safer way. We tend to forget
about stuff like this, and it accumulates.

Thanks
Laszlo

Re: [edk2-devel] [Patch 1/1] EmulatorPkg/PlatformCI: stick with "ubuntu-18.04" for now

[Laszlo Ersek]

On 01/08/21 19:01, Sean Brogan wrote:
> Looks like the switch to Ubuntu 20.04 was pretty negatively impactful.
> Thanks Laszlo for tracking this down.
> 
> Question to the community (especially those using a Linux environment)
> is what priority should it be to go resolve these and update CI to run
> on Ubuntu 20.04?  General premise is we should stay current without
> being bleeding edge but I want to understand other perspectives.

Yes, we should stay current.

We discussed the topic this Tuesday, on the stewards' meeting.
Subsequently -- two days ago --, I filed the following ticket (and CC'd
you and Bret on it):

  https://bugzilla.tianocore.org/show_bug.cgi?id=3156

It's basically a request to track down & compensate for the specifics of
the Ubuntu 20.04 breakage, and then advance to "ubuntu-latest" again.

Mike's advice was to ask you guys to work out the issues with the Ubuntu
image, interactively; mainly because (if I understood correctly) the
Azure environment may layer additional smarts onto the VM image that's
offered by <https://github.com/actions/virtual-environments>.

Also, as I said in the BZ, I'm not an Ubuntu user, so interactively
tweaking an Ubuntu installation (VM image or otherwise), to make the CI
tasks happy, is not my cup of tea. (Fedora would be different -- but
such an image is not available yet:
<https://github.com/actions/virtual-environments/issues/2307>.)

Mike, please correct any mistakes in the above.

Thanks
Laszlo


> On 12/21/2020 6:53 AM, Laszlo Ersek wrote:
>> On 12/21/20 04:19, Bob Feng wrote:
>>> "vm_image: 'ubuntu-latest'" now refers to Ubuntu Focal (20.04LTS), not
>>> Ubuntu Bionic (18.04LTS), according to
>>> <https://github.com/actions/virtual-environments/issues/1816>.
>>>
>>> In Focal, the "qemu" package is a dummy package with no dependencies,
>>> and
>>> so the actual emulators are not pulled in. Compare:
>>>
>>>    https://packages.ubuntu.com/bionic/qemu
>>>    https://packages.ubuntu.com/focal/qemu
>>>
>>> This causes CI runs to fail.
>>>
>>> It would be best to switch to the "qemu-system" package name, which
>>> continues to depend on the emulators:
>>>
>>>    https://packages.ubuntu.com/bionic/qemu-system
>>>    https://packages.ubuntu.com/focal/qemu-system
>>>
>>> However, while that package does make the emulators available, the
>>> emulators crash. So for now, stick with the previous Ubuntu environment,
>>> which continues to be supported, per
>>> <https://github.com/actions/virtual-environments/issues/1816>.
>>>
>>> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>> Cc: Andrew Fish <afish@apple.com>
>>> Cc: Ray Ni <ray.ni@intel.com>
>>> ---
>>>   EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>>> b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>>> index 0e5f4d9961e3..17d62bb69ec5 100644
>>> --- a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>>> +++ b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>>> @@ -15,11 +15,11 @@ pr:
>>>     - master
>>>   jobs:
>>>     - job: Platform_CI
>>>       variables:
>>>         package: 'EmulatorPkg'
>>> -      vm_image: 'ubuntu-latest'
>>> +      vm_image: 'ubuntu-18.04'
>>>         should_run: false
>>>         run_flags: "MAKE_STARTUP_NSH=TRUE"
>>>         #Use matrix to speed up the build process
>>>       strategy:
>>>
>>
>> Merged as commit 3ce3274a5ea4, via
>> <https://github.com/tianocore/edk2/pull/1255>.
>>
>> Thanks,
>> Laszlo
>>
>>
>>
>> 
>>
>>
>