From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 75C177803CE for ; Wed, 6 Mar 2024 21:09:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=cQsxC4xUIo/TQGk1OKvrKszg33Hvbzb3AH3QJfQC0X8=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1709759392; v=1; b=wbsH9ugx3iJ6+YmidrEAUJRc0eE8tHoedauSlftJ+oDMD9yVE4tKB8vKHzSAeCRb73QLa6hY 2EI39bjyV5u4Rklq+V4CVzfoYqeJsazqQobxvexKS4YGoTVGyXld44klwrC9+PejXRZDnwSyvVF oAWDBMQlx99eLgSK2P4mo8+ixxdVrTBOt0Abk63g7VdpJ9F3r5XnF68RRITkw9fjnuGEiD8QyGG kzJLsemIpLitUCQGbYysZFrpBYz5Lxfe3pctPhu81F0FUHwl+NiDNyJA3c0LyUHR4IbUULcgCWs q6mdt0UTGl+ugQrsZOasgixQLnvSNlK+pbIUR0Y7bSaVg== X-Received: by 127.0.0.2 with SMTP id yLtZYY7687511x3XsPeuRr9r; Wed, 06 Mar 2024 13:09:52 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.7356.1709759391425472993 for ; Wed, 06 Mar 2024 13:09:51 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-iLbaHLlFOlaBRelS2gmI8g-1; Wed, 06 Mar 2024 16:09:45 -0500 X-MC-Unique: iLbaHLlFOlaBRelS2gmI8g-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C0C91920708; Wed, 6 Mar 2024 21:09:44 +0000 (UTC) X-Received: from [10.39.192.14] (unknown [10.39.192.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 94674111DCFF; Wed, 6 Mar 2024 21:09:43 +0000 (UTC) Message-ID: Date: Wed, 06 Mar 2024 13:09:51 -0800 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2 08/10] IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ashraf Ali S , Chasel Chiu , Duggapu Chinni B , Nate DeSimone , Star Zeng , Susovan Mohapatra , Ted Kuo Reply-To: devel@edk2.groups.io,lersek@redhat.com References: <20240305113843.68812-1-lersek@redhat.com> <20240305113843.68812-9-lersek@redhat.com> In-Reply-To: <20240305113843.68812-9-lersek@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0h2YTJTDfCtbQxEjE2OoQ3mrx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=wbsH9ugx; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Can I please get a quick R-b for this patch -- it's urgent because of . Thank you, Laszlo On 3/5/24 12:38, Laszlo Ersek wrote: > Rely on AutoGen for declaring ProcessLibraryConstructorList(). >=20 > Build-tested with: >=20 > build -a X64 -b DEBUG -m IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf \ > -p IntelFsp2Pkg/IntelFsp2Pkg.dsc -t GCC5 >=20 > build -a X64 -b DEBUG -m IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf \ > -p IntelFsp2Pkg/IntelFsp2Pkg.dsc -t GCC5 >=20 > Cc: Ashraf Ali S > Cc: Chasel Chiu > Cc: Duggapu Chinni B > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Susovan Mohapatra > Cc: Ted Kuo > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D990 > Signed-off-by: Laszlo Ersek > --- > IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf | 2 +- > IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 2 +- > IntelFsp2Pkg/FspSecCore/SecMain.h | 12 ------------ > 3 files changed, 2 insertions(+), 14 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf b/IntelFsp2Pkg/Fsp= SecCore/Fsp24SecCoreM.inf > index cb011f99f964..7d60e2283e26 100644 > --- a/IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf > +++ b/IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf > @@ -8,7 +8,7 @@ > ## > =20 > [Defines] > - INF_VERSION =3D 0x00010005 > + INF_VERSION =3D 1.30 > BASE_NAME =3D Fsp24SecCoreM > FILE_GUID =3D C5BC0719-4A23-4F6E-94DA-05FB6A0DFA9= C > MODULE_TYPE =3D SEC > diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf b/IntelFsp2Pkg/FspSe= cCore/FspSecCoreM.inf > index 8029832235ec..d496f3957d1b 100644 > --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf > +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf > @@ -8,7 +8,7 @@ > ## > =20 > [Defines] > - INF_VERSION =3D 0x00010005 > + INF_VERSION =3D 1.30 > BASE_NAME =3D FspSecCoreM > FILE_GUID =3D C2F9AE46-3437-4FEF-9CB1-9A568B282FE= E > MODULE_TYPE =3D SEC > diff --git a/IntelFsp2Pkg/FspSecCore/SecMain.h b/IntelFsp2Pkg/FspSecCore/= SecMain.h > index 023deb7e2bda..eb1458d19773 100644 > --- a/IntelFsp2Pkg/FspSecCore/SecMain.h > +++ b/IntelFsp2Pkg/FspSecCore/SecMain.h > @@ -110,18 +110,6 @@ SecStartup ( > IN UINT32 ApiIdx > ); > =20 > -/** > - Autogenerated function that calls the library constructors for all of = the module's > - dependent libraries. This function must be called by the SEC Core onc= e a stack has > - been established. > - > -**/ > -VOID > -EFIAPI > -ProcessLibraryConstructorList ( > - VOID > - ); > - > /** > =20 > Return value of esp. >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116456): https://edk2.groups.io/g/devel/message/116456 Mute This Topic: https://groups.io/mt/104742530/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-