From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.groups.io with SMTP id smtpd.web12.7064.1572883328924480839 for ; Mon, 04 Nov 2019 08:02:09 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 326FB60A8A for ; Mon, 4 Nov 2019 16:02:08 +0000 (UTC) Received: by mail-wm1-f71.google.com with SMTP id z5so6295133wma.5 for ; Mon, 04 Nov 2019 08:02:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lLTThXIcYg6rB6MAhu3PeUPXubg4UIejY74AlaNrhVU=; b=ZFUhxSvAGpeV15XZcx5tAwO6xFOT7WiHwGwKLqJKeDrd5ETW330gmodCECJnGSvQ1b 7EAJ53jERciSVrmL2S2lss717z6yKLKAO8pqoz/xOzpt/OxrZvnGgwKpbHMRms8HVFeQ rsWFJMXVwiB8jlkjehECwsyjuvLC/qJRXJdvoIv9evRp2BjLA94PdjWPFj6w1TP4JSwe z/ABxu25WVyEYBhHodV3El/Pq4Ch4q3A+fWuhEx4QCS1lkDko+H18amfkdUgHEiLTzxX 54xsGh+g3mplhZnvwebHV1c0C/EKMnXbcmvWlY4R63Yj91EtEmXs8V3GiCfBRHyTJH8l nptQ== X-Gm-Message-State: APjAAAXDA5GuUXSZAvq1i88odggPuUCuiyHb+wvHHI7VRXrNJ4IfAdzM l+v1Quy+B8PIU3DC3lkq/qy67fNqQzNJkDVGuZyohdbGBrQY4N5zll8XAxi5k2iQ1Tmvdh3cN1h mV/BMTvO5U6zFYQ== X-Received: by 2002:a7b:c302:: with SMTP id k2mr24316592wmj.81.1572883326402; Mon, 04 Nov 2019 08:02:06 -0800 (PST) X-Google-Smtp-Source: APXvYqz4SaI+DzTY01Gu87jskvIbHubBbYF6HMHtC4okBP8pvpNMGbLOoYVQoFoM5igFRe0lkc5lVg== X-Received: by 2002:a7b:c302:: with SMTP id k2mr24316563wmj.81.1572883326191; Mon, 04 Nov 2019 08:02:06 -0800 (PST) Received: from [192.168.1.24] (lfbn-1-7864-228.w92-167.abo.wanadoo.fr. [92.167.33.228]) by smtp.gmail.com with ESMTPSA id l22sm32039309wrb.45.2019.11.04.08.02.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Nov 2019 08:02:05 -0800 (PST) Subject: Re: [edk2-devel] [Patch v3 02/22] .gitignore: Ignore python compiled files, extdeps, and vscode To: devel@edk2.groups.io, lersek@redhat.com, "Kinney, Michael D" , Leif Lindholm Cc: Sean Brogan , Andrew Fish References: <20191029195517.20028-1-michael.d.kinney@intel.com> <20191029195517.20028-3-michael.d.kinney@intel.com> <20191030022939.GT16820@bivouac.eciton.net> <2cc7ef74-771d-0a71-bb94-094b8b1b5b86@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Mon, 4 Nov 2019 17:02:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <2cc7ef74-771d-0a71-bb94-094b8b1b5b86@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/31/19 10:02 AM, Laszlo Ersek wrote: > On 10/31/19 05:43, Kinney, Michael D wrote: >> Leif, >> >> Thanks. I agree. I will split it out. > > I would further suggest alphabetical sorting for the .gitignore lines. Reviewed-by: Philippe Mathieu-Daude >>> -----Original Message----- >>> From: Leif Lindholm >>> Sent: Tuesday, October 29, 2019 7:30 PM >>> To: Kinney, Michael D >>> Cc: devel@edk2.groups.io; Sean Brogan >>> ; Andrew Fish >>> ; Laszlo Ersek >>> Subject: Re: [Patch v3 02/22] .gitignore: Ignore python >>> compiled files, extdeps, and vscode >>> >>> On Tue, Oct 29, 2019 at 12:54:57PM -0700, Michael D >>> Kinney wrote: >>>> From: Sean Brogan >>>> >>>> https://bugzilla.tianocore.org/show_bug.cgi?id=2315 >>>> >>>> Update .gitignore to ignore .pyc files and __pycache__ >>> directories. >>>> Python based plugins can be added to any package or >>> platform, so these >>>> files and directories may be present outside of >>> BaseTools. >>>> >>>> Ignore _extdep directories that are generated by the >>> pytool external >>>> dependency feature. >>>> >>>> Ignore .vscode directories generated by the VS Code >>> editor. >>>> >>>> Cc: Andrew Fish >>>> Cc: Laszlo Ersek >>>> Cc: Leif Lindholm >>>> Signed-off-by: Kinney >>> >>> Reviewed-by: Leif Lindholm >>> >>> (This one could be merged independently of rest of set, >>> it's useful on its own.) >>> >>>> --- >>>> .gitignore | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/.gitignore b/.gitignore >>>> index 97f22c348c..71679478ac 100644 >>>> --- a/.gitignore >>>> +++ b/.gitignore >>>> @@ -1,3 +1,8 @@ >>>> Build/ >>>> tags/ >>>> .DS_Store >>>> +*.pyc >>>> +__pycache__/ >>>> +*_extdep/ >>>> + >>>> +.vscode/ >>>> -- >>>> 2.21.0.windows.1 >>>> > > > >