From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::543; helo=mail-pg1-x543.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B63FD21A02937 for ; Mon, 19 Nov 2018 22:55:22 -0800 (PST) Received: by mail-pg1-x543.google.com with SMTP id y4so459744pgc.12 for ; Mon, 19 Nov 2018 22:55:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6pN4yLW0GJX9fhvPht2QqQWfKsm0mw059/DuAfhxuXQ=; b=XzJ0tZgR9dBSQZMT3b/IV4WM1d3sOnA6BQ93j0k1UYwe9hNyrSXhzPWlNoNXovGzaB MAjmlS1rTkatsUIe3Z/j2wGmfUnR/md3RebVS4Lnimy3od0ivrllcm8RisXVfbv3ywcV 12KEuw1jWXEVtS/MmlzHei4tgR7pVpKrBForo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6pN4yLW0GJX9fhvPht2QqQWfKsm0mw059/DuAfhxuXQ=; b=BdwJIpnK27+8nAdz3/EHtbG6wen+Br+SVT5j8rpBn39HfORhE4WlvQmaZj9oRHkUGy jLDkXo61w6hOk7/zQFggPc6I6cKAJNYol40lOL0P9B4q5feda6Ftsdt8V36NQAA1jE8T 9bacVFbdMfClmr8qIZ7EDPi/8VFeZYou9khQdTMtLEk1agngpUG1Y+JDKFexcfGHUNH0 UVNj+MojsMsO6ZpZp8aXAzpubRYxgk095sPfnFTybFKazH+K6B2xi6xvkVOrXgtbeIsH Pf/diMFLcUrY7KjXGm+BhnAfpkinSeLU1Xd/MgeJryFu81L39mFfp/H9lP+CG7YpWSfS JtOw== X-Gm-Message-State: AGRZ1gIDmbfYTOQmuxa+SWZfshHnQZvh7chmMHwuprW5YnIhlco8ewrF qAfsb25Ijxevblv0XD767trWBg== X-Google-Smtp-Source: AJdET5e81Z0r92GJrmN70PVgXhLaJNaVU8j7n71SudIkiuQ+7sb23dxKUBpZqlGlDyF34rGjiFUcHg== X-Received: by 2002:a62:1095:: with SMTP id 21-v6mr929873pfq.227.1542696922098; Mon, 19 Nov 2018 22:55:22 -0800 (PST) Received: from [10.139.0.118] ([64.64.108.162]) by smtp.gmail.com with ESMTPSA id p21-v6sm17030165pfk.186.2018.11.19.22.55.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Nov 2018 22:55:21 -0800 (PST) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com References: <20181116065702.30559-1-ming.huang@linaro.org> <20181116065702.30559-11-ming.huang@linaro.org> <20181119182021.7o4o6wvd25tpava3@bivouac.eciton.net> From: Ming Huang Message-ID: Date: Tue, 20 Nov 2018 14:55:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20181119182021.7o4o6wvd25tpava3@bivouac.eciton.net> Subject: Re: [PATCH edk2-platforms v2 10/15] Hisilicon/D06: Modify Gic base X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 06:55:22 -0000 X-List-Received-Date: Tue, 20 Nov 2018 06:55:22 -0000 X-List-Received-Date: Tue, 20 Nov 2018 06:55:22 -0000 X-List-Received-Date: Tue, 20 Nov 2018 06:55:22 -0000 X-List-Received-Date: Tue, 20 Nov 2018 06:55:22 -0000 X-List-Received-Date: Tue, 20 Nov 2018 06:55:22 -0000 X-List-Received-Date: Tue, 20 Nov 2018 06:55:22 -0000 X-List-Received-Date: Tue, 20 Nov 2018 06:55:22 -0000 X-List-Received-Date: Tue, 20 Nov 2018 06:55:22 -0000 X-List-Received-Date: Tue, 20 Nov 2018 06:55:22 -0000 X-List-Received-Date: Tue, 20 Nov 2018 06:55:22 -0000 X-List-Received-Date: Tue, 20 Nov 2018 06:55:22 -0000 X-List-Received-Date: Tue, 20 Nov 2018 06:55:22 -0000 X-List-Received-Date: Tue, 20 Nov 2018 06:55:22 -0000 X-List-Received-Date: Tue, 20 Nov 2018 06:55:22 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/20/2018 2:20 AM, Leif Lindholm wrote: > You said in reply to my comment on v1: > > --- > The PcdGicInterruptInterfaceBase(0xFE000000) is wrong, it just copy > from D05/D03, > maybe somewhere will need the right value of Pcd. > --- > > Please split that out as a separate change, with the above mentioned > in the commit message. OK > > But if I understand correctly, the remainder of the patch will be > incorrect until the other changes to book from TA have been applied > (in the subsequent patch). > So please move the MADT change to the other patch. D06 had been boot from TA from last series (Upload for D06 platform). Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot and Hisilicon/D06: Modify Gic base are tow important patches missed by last series. > > / > Leif > > On Fri, Nov 16, 2018 at 02:56:57PM +0800, Ming Huang wrote: >> The values of PcdGicInterruptInterfaceBase and GICD are wrong, so modify it. >> Fix SBSA test case 21: >> 21 : Check GIC version >> GIC version is 0 >> Failed on PE - 0 for Level= 3 : Result: --FAIL-- 2 >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> --- >> Platform/Hisilicon/D06/D06.dsc | 2 +- >> Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc >> index b6ef9fedf0a7..ac35564f4ac6 100644 >> --- a/Platform/Hisilicon/D06/D06.dsc >> +++ b/Platform/Hisilicon/D06/D06.dsc >> @@ -183,7 +183,7 @@ [PcdsFixedAtBuild.common] >> gHisiTokenSpaceGuid.PcdArmPrimaryCoreTemp|0x80010000 >> gArmTokenSpaceGuid.PcdGicDistributorBase|0xAE000000 >> gArmTokenSpaceGuid.PcdGicRedistributorsBase|0xAE100000 >> - gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0xFE000000 >> + gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x9B000000 >> >> >> >> diff --git a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc >> index 43b43142aff4..d3de69a3ef6c 100644 >> --- a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc >> +++ b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc >> @@ -361,7 +361,7 @@ EFI_ACPI_MULTIPLE_APIC_DESCRIPTION_TABLE Madt = { >> 0x0, 0x0, 25, 0x4000AA000000 + 0x6C0000 /* GicRBase */, 0), >> }, >> >> - EFI_ACPI_6_1_GIC_DISTRIBUTOR_INIT(0, 0xAA000000, 0, 0x4), >> + EFI_ACPI_6_1_GIC_DISTRIBUTOR_INIT(0, 0xAE000000, 0, 0x4), >> { >> EFI_ACPI_6_1_GIC_ITS_INIT(0,0x202100000), //peri a >> // EFI_ACPI_6_1_GIC_ITS_INIT(1,0x400202100000), //peri a >> -- >> 2.9.5 >>