From: "Laszlo Ersek" <lersek@redhat.com>
To: Anthony PERARD <anthony.perard@citrix.com>, devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Julien Grall <julien.grall@arm.com>
Subject: Re: [PATCH] OvmfPkg/XenBusDxe: Don't call DisconnectController in Stop()
Date: Mon, 1 Jul 2019 16:56:00 +0200 [thread overview]
Message-ID: <e5d0ba4e-4e52-e2a2-2ebd-db20bb0ab7af@redhat.com> (raw)
In-Reply-To: <20190701111403.7007-1-anthony.perard@citrix.com>
On 07/01/19 13:14, Anthony PERARD wrote:
> Calling DisconnectController() on children isn't part of the job of
> EFI_DRIVER_BINDING_PROTOCOL.Stop() as it only needs to deallocate
> resources allocated in Start(). The disconnection will happen when
> both DevicePath and XenBus protocols gets uninstalled.
>
> Reported-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>
> Notes:
> Please apply this patch after:
> "OvmfPkg/XenBusDxe: Close XenIoProtocol openned by children"
>
> OvmfPkg/XenBusDxe/XenBusDxe.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/OvmfPkg/XenBusDxe/XenBusDxe.c b/OvmfPkg/XenBusDxe/XenBusDxe.c
> index 7c07a96650..634c7b71eb 100644
> --- a/OvmfPkg/XenBusDxe/XenBusDxe.c
> +++ b/OvmfPkg/XenBusDxe/XenBusDxe.c
> @@ -446,12 +446,6 @@ XenBusDxeDriverBindingStop (
> continue;
> }
> ChildData = XENBUS_PRIVATE_DATA_FROM_THIS (XenBusIo);
> - Status = gBS->DisconnectController (ChildData->Handle, NULL, NULL);
> - if (EFI_ERROR (Status)) {
> - DEBUG ((EFI_D_ERROR, "XenBusDxe: error disconnecting child: %r\n",
> - Status));
> - continue;
> - }
>
> Status = gBS->CloseProtocol (Dev->ControllerHandle, &gXenIoProtocolGuid,
> Dev->This->DriverBindingHandle, ChildData->Handle);
>
Commit 6a1f06fadb26.
Thanks
Laszlo
prev parent reply other threads:[~2019-07-01 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 11:14 [PATCH] OvmfPkg/XenBusDxe: Don't call DisconnectController in Stop() Anthony PERARD
2019-07-01 14:39 ` Laszlo Ersek
2019-07-01 14:56 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5d0ba4e-4e52-e2a2-2ebd-db20bb0ab7af@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox