From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web11.36288.1610988534198448266 for ; Mon, 18 Jan 2021 08:48:54 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=R7fL9Cm+; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610988533; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bx64badGKrhdUaa3lffM6BKoHQWuoWyZbDSDlZ2+QtI=; b=R7fL9Cm+gX4/MxD63JI51AoDGi6KVe8xQM2RGjFIhFkCozwEsIoQ31qE8/wOrLfgN40pe4 k4ARdL+P17JT00C8FfobcGNdZNmXcUJgEHFKUj0TgQFjZijirieFrHRqGW6dyPqI3t6SF1 X9zicV0OttFzcz08GYXtUal69gxZnVQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-486-yv9o5W2YN6eO7Stq8dx7KA-1; Mon, 18 Jan 2021 11:48:51 -0500 X-MC-Unique: yv9o5W2YN6eO7Stq8dx7KA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3233D107ACE4; Mon, 18 Jan 2021 16:48:50 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-48.ams2.redhat.com [10.36.112.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 12D7260861; Mon, 18 Jan 2021 16:48:48 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 05/10] UefiPayloadPkg: add OrderedCollectionLib class resolution From: "Laszlo Ersek" To: devel@edk2.groups.io Cc: Benjamin You , Guo Dong , Maurice Ma , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <20210113085453.10168-1-lersek@redhat.com> <20210113085453.10168-6-lersek@redhat.com> Message-ID: Date: Mon, 18 Jan 2021 17:48:48 +0100 MIME-Version: 1.0 In-Reply-To: <20210113085453.10168-6-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Ping -- Benjamin, Guo, Maurice, this is a one-liner for UefiPayloadPkg; please approve. Thanks Laszlo On 01/13/21 09:54, Laszlo Ersek wrote: > A subsequent patch in the series will make the > > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf > > instance dependent on the OrderedCollectionLib class. Because the shell > binary in this platform consumes the above UefiShellCommandLib instance, > resolve OrderedCollectionLib. > > Cc: Benjamin You > Cc: Guo Dong > Cc: Maurice Ma > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3151 > Signed-off-by: Laszlo Ersek > --- > > Notes: > v2: > - new patch > > UefiPayloadPkg/UefiPayloadPkg.dsc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc > index ae62a9c4d66b..24dab157f1ef 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > @@ -556,6 +556,7 @@ [Components.X64] > DebugLib|MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf > ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf >