Re: [PATCH 0/3] MdeModulePkg/TerminalDxe: TtyTerm improvements

[Laszlo Ersek <lersek@redhat.com>]

Roy, Ryan,

On 10/07/16 16:53, Brian J. Johnson wrote:
> This patch series implements some improvements to the TtyTerm terminal
> type in the TerminalDxe driver.  It fixes an end case with cursor
> position tracking, and uses that to optimize cursor motion escape
> sequences.  It also adds support for the page up, page down, insert,
> home, and end keys on some additional common terminal emulators.
> 
> The result is improved performance, especially at the shell prompt,
> and better compatibility with common terminal emulators.  In
> particular, as a side effect of the optimized cursor motion, terminal
> windows which are taller than the current mode setting (eg. 25 lines)
> work much better than before.
> 
> Most of these fixes have been in production in some form on SGI's
> servers for years.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Brian Johnson <bjohnson@sgi.com>
> Cc: Feng Tian <feng.tian@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> 
> Brian J. Johnson (3):
>   MdeModulePkg/TerminalDxe: Improve TtyTerm cursor position tracking
>   MdeModulePkg/TerminalDxe: Optimize TtyTerm cursor motion
>   MdeModulePkg/TerminalDxe: Handle more keys with TtyTerm
> 
>  .../Universal/Console/TerminalDxe/Terminal.h       |  2 +
>  .../Universal/Console/TerminalDxe/TerminalConIn.c  | 24 +++++++--
>  .../Universal/Console/TerminalDxe/TerminalConOut.c | 61 ++++++++++++++++++++--
>  3 files changed, 79 insertions(+), 8 deletions(-)
> 

can you please provide feedback (testing or otherwise) on this series?

Thanks
Laszlo