From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7CB941A1E05 for ; Fri, 7 Oct 2016 08:56:29 -0700 (PDT) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D1BE444828; Fri, 7 Oct 2016 15:56:28 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-25.phx2.redhat.com [10.3.116.25]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u97FuQUF010712; Fri, 7 Oct 2016 11:56:27 -0400 References: Cc: "Brian J. Johnson" , edk2-devel@ml01.01.org, Feng Tian , Star Zeng To: Roy Franz , Ryan Harkin From: Laszlo Ersek Message-ID: Date: Fri, 7 Oct 2016 17:56:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 07 Oct 2016 15:56:28 +0000 (UTC) Subject: Re: [PATCH 0/3] MdeModulePkg/TerminalDxe: TtyTerm improvements X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 15:56:29 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Roy, Ryan, On 10/07/16 16:53, Brian J. Johnson wrote: > This patch series implements some improvements to the TtyTerm terminal > type in the TerminalDxe driver. It fixes an end case with cursor > position tracking, and uses that to optimize cursor motion escape > sequences. It also adds support for the page up, page down, insert, > home, and end keys on some additional common terminal emulators. > > The result is improved performance, especially at the shell prompt, > and better compatibility with common terminal emulators. In > particular, as a side effect of the optimized cursor motion, terminal > windows which are taller than the current mode setting (eg. 25 lines) > work much better than before. > > Most of these fixes have been in production in some form on SGI's > servers for years. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Brian Johnson > Cc: Feng Tian > Cc: Star Zeng > > Brian J. Johnson (3): > MdeModulePkg/TerminalDxe: Improve TtyTerm cursor position tracking > MdeModulePkg/TerminalDxe: Optimize TtyTerm cursor motion > MdeModulePkg/TerminalDxe: Handle more keys with TtyTerm > > .../Universal/Console/TerminalDxe/Terminal.h | 2 + > .../Universal/Console/TerminalDxe/TerminalConIn.c | 24 +++++++-- > .../Universal/Console/TerminalDxe/TerminalConOut.c | 61 ++++++++++++++++++++-- > 3 files changed, 79 insertions(+), 8 deletions(-) > can you please provide feedback (testing or otherwise) on this series? Thanks Laszlo