Re: [PATCH v2 0/6] Add DSC/FDF include segment files for network stack

[Laszlo Ersek <lersek@redhat.com>]

On 11/22/18 06:21, Fu Siyuan wrote:
> There is a patch to remove the redudant IP4 only iSCSI/PXE/TCP drivers
> from MdeModulePkg, which has been reviewed before edk2-stable201811 tag.
> And we also have plan to move all network related libraries/modules to
> NetworkPkg. In order to make these change more smoothly, a set of fragment
> files (2 for DSC and 1 for FDF) are provided for platform to enable the 
> network stack support, without directly reference the INF module path.
> 
> Patch 1/6 adds centralized dsc/fdf include files to NetworkPkg, with
> a set of flags for feature set enable/disable.
> Patch 2~6 updates edk2 platform dsc/fdf files to use the new include
> files, instead of reference the module INF.
> 
> v2:
>   1. Split the "Network.dsc.inc" in to 4 files for different sections in DSC
>   file. This could provide more flexibility to platform owner to use the
>   include files.
>   2. Clarify the OpenSSL dependency of TLS, iSCSI and IPsec enable flag.
>   3. Use "!error" statement for incorrect flag value check.
>   4. Update platform DSC/FDF to use the new include files.
>   5. Other decoration work according to Laszlo's comments.

Thanks for v2! I'll need a bit more time for reviewing it. Also it seems
we'll have to come to an agreement with Liming and Ray first. So let's
continue those sub-threads on the design ideas before I start my full v2
review round.

Thanks for your patience,
Laszlo