From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E3A9C2194D3AE for ; Thu, 22 Nov 2018 08:12:14 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5BF4C3001921; Thu, 22 Nov 2018 16:12:14 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-200.rdu2.redhat.com [10.10.120.200]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0686B5DDFE; Thu, 22 Nov 2018 16:12:11 +0000 (UTC) To: Fu Siyuan Cc: edk2-devel@lists.01.org, Ruiyu Ni , Ting Ye , Jordan Justen , Hao Wu , Jiaxin Wu , Anthony Perard , David Wei References: <20181122052153.89464-1-siyuan.fu@intel.com> From: Laszlo Ersek Message-ID: Date: Thu, 22 Nov 2018 17:12:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181122052153.89464-1-siyuan.fu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 22 Nov 2018 16:12:14 +0000 (UTC) Subject: Re: [PATCH v2 0/6] Add DSC/FDF include segment files for network stack X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 16:12:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/22/18 06:21, Fu Siyuan wrote: > There is a patch to remove the redudant IP4 only iSCSI/PXE/TCP drivers > from MdeModulePkg, which has been reviewed before edk2-stable201811 tag. > And we also have plan to move all network related libraries/modules to > NetworkPkg. In order to make these change more smoothly, a set of fragment > files (2 for DSC and 1 for FDF) are provided for platform to enable the > network stack support, without directly reference the INF module path. > > Patch 1/6 adds centralized dsc/fdf include files to NetworkPkg, with > a set of flags for feature set enable/disable. > Patch 2~6 updates edk2 platform dsc/fdf files to use the new include > files, instead of reference the module INF. > > v2: > 1. Split the "Network.dsc.inc" in to 4 files for different sections in DSC > file. This could provide more flexibility to platform owner to use the > include files. > 2. Clarify the OpenSSL dependency of TLS, iSCSI and IPsec enable flag. > 3. Use "!error" statement for incorrect flag value check. > 4. Update platform DSC/FDF to use the new include files. > 5. Other decoration work according to Laszlo's comments. Thanks for v2! I'll need a bit more time for reviewing it. Also it seems we'll have to come to an agreement with Liming and Ray first. So let's continue those sub-threads on the design ideas before I start my full v2 review round. Thanks for your patience, Laszlo