From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B1E2C224C0F58 for ; Wed, 7 Mar 2018 01:04:54 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0FEAB76FBA; Wed, 7 Mar 2018 09:11:09 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-143.rdu2.redhat.com [10.10.120.143]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2978F2144B20; Wed, 7 Mar 2018 09:11:07 +0000 (UTC) To: "Gao, Liming" , edk2-devel-01 Cc: Paolo Bonzini , Cole Robinson , Ard Biesheuvel References: <20180302180924.4312-1-lersek@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E1D785E@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E1D89D1@SHSMSX104.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: Date: Wed, 7 Mar 2018 10:11:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1D89D1@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 07 Mar 2018 09:11:09 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 07 Mar 2018 09:11:09 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 0/3] BaseTools: let the C-language build utils compile with gcc-8 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 09:04:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/07/18 07:43, Gao, Liming wrote: > Laszlo: > We just find this change causes XCODE5 build failure, because XCODE compiler doesn't know these two options. So, could you provide the patch to remove the change in BUILD_CFLAGS for MAC? Yep, I was a bit concerned about that. Ultimately I assumed that - clang would either recognize these warnings options (because it does recognize most -W options of gcc), - or, similarly to gcc, clang would simply ignore -Wno-* flags that it does not recognize. Neither appears to be the case, then. I'll send a patch soon. Thanks, and sorry about the regression. Laszlo > ifeq ($(DARWIN),Darwin) > # assume clang or clang compatible flags on OS X > BUILD_CFLAGS = > else > > Thanks > Liming >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gao, Liming >> Sent: Monday, March 5, 2018 10:14 PM >> To: Laszlo Ersek ; edk2-devel-01 >> Cc: Paolo Bonzini ; Cole Robinson ; Ard Biesheuvel >> Subject: Re: [edk2] [PATCH 0/3] BaseTools: let the C-language build utils compile with gcc-8 >> >> Reviewed-by: Liming Gao >> >>> -----Original Message----- >>> From: Laszlo Ersek [mailto:lersek@redhat.com] >>> Sent: Saturday, March 03, 2018 2:09 AM >>> To: edk2-devel-01 >>> Cc: Ard Biesheuvel ; Cole Robinson >>> ; Gao, Liming ; Paolo Bonzini >>> ; Zhu, Yonghong >>> Subject: [PATCH 0/3] BaseTools: let the C-language build utils compile with >>> gcc-8 >>> >>> Repo: https://github.com/lersek/edk2.git >>> Branch: basetools_gcc8 >>> >>> Once these patches are applied to the build flags and the source code of >>> the build utilities themselves, OVMF builds fine with gcc-8, using the >>> GCC5 toolchain settings without any changes. >>> >>> Regression-tested with gcc-4.8 / x86_64. >>> >>> Cc: Ard Biesheuvel >>> Cc: Cole Robinson >>> Cc: Liming Gao >>> Cc: Paolo Bonzini >>> Cc: Yonghong Zhu >>> >>> Thanks >>> Laszlo >>> >>> Laszlo Ersek (3): >>> BaseTools/header.makefile: add "-Wno-stringop-truncation" >>> BaseTools/header.makefile: add "-Wno-restrict" >>> BaseTools/GenVtf: silence false "stringop-overflow" warning with >>> memcpy() >>> >>> BaseTools/Source/C/Makefiles/header.makefile | 4 ++-- >>> BaseTools/Source/C/GenVtf/GenVtf.c | 4 ++-- >>> 2 files changed, 4 insertions(+), 4 deletions(-) >>> >>> -- >>> 2.14.1.3.gb7cf6e02401b >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel