public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, ard.biesheuvel@arm.com
Cc: leif@nuviainc.com
Subject: Re: [edk2-devel] [PATCH edk2-platforms 2/2] Platform/Overdrive: enable BAR resizing
Date: Thu, 14 Jan 2021 20:07:15 +0100	[thread overview]
Message-ID: <e68a9661-8651-51e7-5389-db283583c519@redhat.com> (raw)
In-Reply-To: <20210114124615.8132-2-ard.biesheuvel@arm.com>

On 01/14/21 13:46, Ard Biesheuvel wrote:
> Add support for BAR resizing at PCI resource allocation time: this removes
> the need for the OS to grow BARs of PCIe devices such as GPU controllers,
> which typically use small BARs by default for compatibility with 32-bit
> systems with small PCI resource windows, but perform better when the BAR
> can cover all of its onboard memory.
> 
> Usually, the OS should be capable of performing the BAR resize as well,
> but it is more constrained, and so doing this earlier is better on
> systems such as Overdrive where the MMIO root window is huge.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
> ---
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> index adc92af080f1..17600a58112d 100644
> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> @@ -404,6 +404,8 @@ [PcdsFixedAtBuild.common]
>    gArmTokenSpaceGuid.PcdPciMmio64Size|0x7F00000000
>    gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
>  
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|TRUE
> +
>    ## ACPI (no tables < 4GB)
>    gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
>  
> 

... this is exactly the kind of documentation that I wished for (in
retrospect) in the original edk2 feature addition.


  reply	other threads:[~2021-01-14 19:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 12:46 [PATCH edk2-platforms 1/2] Platform/Overdrive: drop commented out reference to bogus PCD Ard Biesheuvel
2021-01-14 12:46 ` [PATCH edk2-platforms 2/2] Platform/Overdrive: enable BAR resizing Ard Biesheuvel
2021-01-14 19:07   ` Laszlo Ersek [this message]
2021-01-15  9:10 ` [edk2-devel] [PATCH edk2-platforms 1/2] Platform/Overdrive: drop commented out reference to bogus PCD Philippe Mathieu-Daudé
2021-01-15 22:09 ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e68a9661-8651-51e7-5389-db283583c519@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox