From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web10.195.1582676276746203464 for ; Tue, 25 Feb 2020 16:17:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ao5BPLtl; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582676275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yq/ZODtAqAZx8ltkxORM+DPAMEO3pn+CoOpcqMRC0QM=; b=Ao5BPLtlSqwKDVPjIv6d259NPfNMwf8lrv7aCnUbR4Sc+H4CgOOolE2slSVIDUkjuxDoTa qZ4Ut9XABq5FdEUDzTv0VlgiURSWedu7h+rvtiy63zsRjZtohQPhcLvNlvoh+7fD4ItF9g HHRJa9LWbFub3tT4yZaOcXKGpODTt24= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-414-7EvqDHviNE-BzlJ2ovA5YA-1; Tue, 25 Feb 2020 19:17:48 -0500 X-MC-Unique: 7EvqDHviNE-BzlJ2ovA5YA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2C0BA800D5C; Wed, 26 Feb 2020 00:17:47 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-104.ams2.redhat.com [10.36.117.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id AB1F0393; Wed, 26 Feb 2020 00:17:40 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 0/5] ArmVirtPkg: implement measured boot for ArmVirtQemu To: devel@edk2.groups.io, ard.biesheuvel@linaro.org Cc: eric.auger@redhat.com, philmd@redhat.com, marcandre.lureau@redhat.com, stefanb@linux.ibm.com, leif@nuviainc.com References: <20200225104449.22453-1-ard.biesheuvel@linaro.org> From: "Laszlo Ersek" Message-ID: Date: Wed, 26 Feb 2020 01:17:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200225104449.22453-1-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 02/25/20 11:44, Ard Biesheuvel wrote: > Wire up the various existing pieces so that we can implement measured > boot on ArmVirtQemu based on the TPM support in QEMU, just like it has > been implemented for x86 in OvmfPkg. > > The main difference is that on ARM, we first need to discover the TPM base > address from the device tree provided by QEMU, as well as the PSCI method > used to perform a cold reset. > > Changes since v1: > - use a separate ResetSystemLib instance based on on-demand parsing of the > DT, and expose it via the ResetSystem PPI to other client PEIMs > - add Laszlo's ack to #1 > - incorporate Laszlo's review feedback across the board Can you please file a new tianocore feature request BZ for this, and hook the BZ ref into all of the commit messages? Also, in the BZ, can you please reference both versions posted thus far: * [edk2-devel] [PATCH 0/4] ArmVirtPkg: implement measured boot for ArmVirtQemu https://edk2.groups.io/g/devel/message/52972 http://mid.mail-archive.com/20200107094800.4488-1-ard.biesheuvel@linaro.org * [edk2-devel] [PATCH v2 0/5] ArmVirtPkg: implement measured boot for ArmVirtQemu https://edk2.groups.io/g/devel/message/54779 http://mid.mail-archive.com/20200225104449.22453-1-ard.biesheuvel@linaro.org Thanks! Laszlo