[edk2-devel] ArmPkg,ArmPlatformPkg: Adding nasm files to allow builds with VS2022

[edk2-devel] ArmPkg,ArmPlatformPkg: Adding nasm files to allow builds with VS2022

[Rebecca Cran]

I've been wondering if it might be worth adding nasm files to ArmPkg, 
ArmPlatformPkg etc. to allow platforms to be built with VS2022 - mainly 
because different compilers can detect different issues with the code.

What do people think: would it be worthwhile, or should we stick with 
GCC and CLANG and avoid the maintenance overhead of another set of 
assembly files?


-- 
Rebecca



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120675): https://edk2.groups.io/g/devel/message/120675
Mute This Topic: https://groups.io/mt/109181847/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] ArmPkg,ArmPlatformPkg: Adding nasm files to allow builds with VS2022

[Sami Mujawar]

[-- Attachment #1: Type: text/plain, Size: 2131 bytes --]

Hi Rebecca,

Thank you for bringing up this topic.

I agree we should get Visual Studio compiler support for Arm in edk2. The Visual Studio static analysis has helped to detect issues in DynamicTablesPkg in the past (when we did not have any dependency on assembly code).

I can see that Visual Studio Compiler support is already available in Project Mu. Would it be good to pull in the changes from there?
We would need to:

  *   look at the compatibility of the licenses.
  *   review and align any changes with the latest edk2 code base (Note this effort would be significantly less than starting from scratch).

@Oliver Smith-Denny<mailto:osde@linux.microsoft.com> is this something you can help with, please?

Regards,

Sami Mujawar


From: Rebecca Cran <rebecca@bsdio.com>
Date: Thursday, 24 October 2024 at 00:49
To: devel@edk2.groups.io <devel@edk2.groups.io>, Leif Lindholm <quic_llindhol@quicinc.com>, Sami Mujawar <Sami.Mujawar@arm.com>
Subject: ArmPkg,ArmPlatformPkg: Adding nasm files to allow builds with VS2022
I've been wondering if it might be worth adding nasm files to ArmPkg,
ArmPlatformPkg etc. to allow platforms to be built with VS2022 - mainly
because different compilers can detect different issues with the code.

What do people think: would it be worthwhile, or should we stick with
GCC and CLANG and avoid the maintenance overhead of another set of
assembly files?


--
Rebecca
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120680): https://edk2.groups.io/g/devel/message/120680
Mute This Topic: https://groups.io/mt/109181847/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 10710 bytes --]

Re: [edk2-devel] ArmPkg,ArmPlatformPkg: Adding nasm files to allow builds with VS2022

[Oliver Smith-Denny]

On 10/24/2024 2:08 AM, Sami Mujawar wrote:
> Hi Rebecca,
> 
> Thank you for bringing up this topic.
> 
> I agree we should get Visual Studio compiler support for Arm in edk2. 
> The Visual Studio static analysis has helped to detect issues in 
> DynamicTablesPkg in the past (when we did not have any dependency on 
> assembly code).
> 
> I can see that Visual Studio Compiler support is already available in 
> Project Mu. Would it be good to pull in the changes from there?
> 
> We would need to:
> 
>   * look at the compatibility of the licenses.
>   * review and align any changes with the latest edk2 code base (Note
>     this effort would be significantly less than starting from scratch).
> 
> @Oliver Smith-Denny <mailto:osde@linux.microsoft.com> is this something 
> you can help with, please?
> 

Yes, we have been wanting to upstream our ARM VS2022 build support,
including the nasm files, but we also weren't sure what the upstream
appetite was. I will help coordinate that from our side.

License-wise, we use the same BSD-2-Clause-Patent license as edk2
so there should be no issue.

I'll deal with any changes with the latest edk2 codebase, we are
updated to the edk2-stable202405 tag, so the delta shouldn't
be huge.

Thanks,
Oliver


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120681): https://edk2.groups.io/g/devel/message/120681
Mute This Topic: https://groups.io/mt/109181847/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] ArmPkg,ArmPlatformPkg: Adding nasm files to allow builds with VS2022

[Rebecca Cran]

Awesome, thanks!

On Thu, Oct 24, 2024, at 9:48 AM, Oliver Smith-Denny wrote:
> On 10/24/2024 2:08 AM, Sami Mujawar wrote:
>> Hi Rebecca,
>> 
>> Thank you for bringing up this topic.
>> 
>> I agree we should get Visual Studio compiler support for Arm in edk2. 
>> The Visual Studio static analysis has helped to detect issues in 
>> DynamicTablesPkg in the past (when we did not have any dependency on 
>> assembly code).
>> 
>> I can see that Visual Studio Compiler support is already available in 
>> Project Mu. Would it be good to pull in the changes from there?
>> 
>> We would need to:
>> 
>>   * look at the compatibility of the licenses.
>>   * review and align any changes with the latest edk2 code base (Note
>>     this effort would be significantly less than starting from scratch).
>> 
>> @Oliver Smith-Denny <mailto:osde@linux.microsoft.com> is this something 
>> you can help with, please?
>> 
>
> Yes, we have been wanting to upstream our ARM VS2022 build support,
> including the nasm files, but we also weren't sure what the upstream
> appetite was. I will help coordinate that from our side.
>
> License-wise, we use the same BSD-2-Clause-Patent license as edk2
> so there should be no issue.
>
> I'll deal with any changes with the latest edk2 codebase, we are
> updated to the edk2-stable202405 tag, so the delta shouldn't
> be huge.
>
> Thanks,
> Oliver
>
>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120682): https://edk2.groups.io/g/devel/message/120682
Mute This Topic: https://groups.io/mt/109181847/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] ArmPkg,ArmPlatformPkg: Adding nasm files to allow builds with VS2022

[Gerd Hoffmann]

On Wed, Oct 23, 2024 at 05:48:46PM -0600, Rebecca Cran wrote:
> I've been wondering if it might be worth adding nasm files to ArmPkg,
> ArmPlatformPkg etc. to allow platforms to be built with VS2022 - mainly
> because different compilers can detect different issues with the code.

What is nasm?  I suspect it is not referring to http://www.nasm.us/?

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120727): https://edk2.groups.io/g/devel/message/120727
Mute This Topic: https://groups.io/mt/109181847/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] ArmPkg,ArmPlatformPkg: Adding nasm files to allow builds with VS2022

[Rebecca Cran]

On 11/5/24 5:58 AM, Gerd Hoffmann wrote:
> On Wed, Oct 23, 2024 at 05:48:46PM -0600, Rebecca Cran wrote:
>> I've been wondering if it might be worth adding nasm files to ArmPkg,
>> ArmPlatformPkg etc. to allow platforms to be built with VS2022 - mainly
>> because different compilers can detect different issues with the code.
> What is nasm?  I suspect it is not referring to http://www.nasm.us/?

Yes, I'm referring to the assembler files used on Windows which are 
built with nasm from http://www.nasm.us .


-- 

Rebecca



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120730): https://edk2.groups.io/g/devel/message/120730
Mute This Topic: https://groups.io/mt/109181847/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] ArmPkg,ArmPlatformPkg: Adding nasm files to allow builds with VS2022

[Gerd Hoffmann]

On Tue, Nov 05, 2024 at 06:55:55AM -0700, Rebecca Cran wrote:
> On 11/5/24 5:58 AM, Gerd Hoffmann wrote:
> > On Wed, Oct 23, 2024 at 05:48:46PM -0600, Rebecca Cran wrote:
> > > I've been wondering if it might be worth adding nasm files to ArmPkg,
> > > ArmPlatformPkg etc. to allow platforms to be built with VS2022 - mainly
> > > because different compilers can detect different issues with the code.
> > What is nasm?  I suspect it is not referring to http://www.nasm.us/?
> 
> Yes, I'm referring to the assembler files used on Windows which are built
> with nasm from http://www.nasm.us .

Has nasm gained support for arm?  IIRC it's a x86-only assembler (and
the website says so too ...).

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120733): https://edk2.groups.io/g/devel/message/120733
Mute This Topic: https://groups.io/mt/109181847/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] ArmPkg,ArmPlatformPkg: Adding nasm files to allow builds with VS2022

[Rebecca Cran]

On 11/5/24 8:40 AM, Gerd Hoffmann wrote:
> Has nasm gained support for arm?  IIRC it's a x86-only assembler (and
> the website says so too ...).

Yup, you're right - I'd completely forgotten about that. I guess my 
point was that on Windows the .S files that we have for Arm don't get 
built, so we likely need to add a Windows specific set of files - maybe 
using Microsoft's ARM Assembler 
(https://learn.microsoft.com/en-us/cpp/assembler/arm/arm-assembler-command-line-reference?view=msvc-170)?


-- 
Rebecca



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120734): https://edk2.groups.io/g/devel/message/120734
Mute This Topic: https://groups.io/mt/109181847/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] ArmPkg,ArmPlatformPkg: Adding nasm files to allow builds with VS2022

[Oliver Smith-Denny]

On 11/5/2024 7:46 AM, Rebecca Cran wrote:
> On 11/5/24 8:40 AM, Gerd Hoffmann wrote:
>> Has nasm gained support for arm?  IIRC it's a x86-only assembler (and
>> the website says so too ...).
> 
> Yup, you're right - I'd completely forgotten about that. I guess my 
> point was that on Windows the .S files that we have for Arm don't get 
> built, so we likely need to add a Windows specific set of files - maybe 
> using Microsoft's ARM Assembler (https://learn.microsoft.com/en-us/cpp/ 
> assembler/arm/arm-assembler-command-line-reference?view=msvc-170)?
> 

Yes, that's what we've done in Project Mu, add MASM support so that
VS2022 can build ARM64. That's what Sami was referencing when he said
Project Mu had the support earlier in this thread.

We will put up a PR (or set of PRs) to upstream this. We need to do
a little review on our side as the MASM stuff was added a while back
and then see where it falls in the priority list.

Thanks,
Oliver



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120735): https://edk2.groups.io/g/devel/message/120735
Mute This Topic: https://groups.io/mt/109181847/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-