From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web09.8940.1608215529224272400
 for <devel@edk2.groups.io>;
 Thu, 17 Dec 2020 06:32:09 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IUzAsUvL;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1608215528;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=U0gzFQ7NU13FizkvEsWiPqdr0tlD8yQtxJTprsSVeyc=;
	b=IUzAsUvLYxIv9siLMAVeZkIw+xZ+ukZG5kjrVRmmNImCgqWJDpeLmgGFNhKuvXY+wSM8Qy
	vSROzZAGMjRG5RnRh8/2bqKgazpsDLGef3V6YJYgnKwndRMVhZHzYefKuFv++nBc7a48lx
	RAFg06API+Ba9NkfgSS0WpwBGN6TTvo=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-171-QnjnvcNbOne_ZrjGzLfT5A-1; Thu, 17 Dec 2020 09:32:05 -0500
X-MC-Unique: QnjnvcNbOne_ZrjGzLfT5A-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5963D800D53;
	Thu, 17 Dec 2020 14:32:04 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-40.ams2.redhat.com [10.36.115.40])
	by smtp.corp.redhat.com (Postfix) with ESMTP id E6A7D5D71D;
	Thu, 17 Dec 2020 14:32:02 +0000 (UTC)
Subject: Re: [Virtio-fs] [edk2 PATCH 06/48] OvmfPkg/VirtioFsDxe: introduce the basic FUSE request/response headers
From: "Laszlo Ersek" <lersek@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: devel@edk2.groups.io, virtio-fs@redhat.com,
 Jordan Justen <jordan.l.justen@intel.com>,
 =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@redhat.com>,
 Ard Biesheuvel <ard.biesheuvel@arm.com>
References: <20201216211125.19496-1-lersek@redhat.com>
 <20201216211125.19496-7-lersek@redhat.com> <20201217114950.GC4117@work-vm>
 <936ba94a-8226-8649-d9af-b5f6382ebbc2@redhat.com>
Message-ID: <e6b72ff0-187b-7711-d9bf-ef094df2d1c4@redhat.com>
Date: Thu, 17 Dec 2020 15:32:01 +0100
MIME-Version: 1.0
In-Reply-To: <936ba94a-8226-8649-d9af-b5f6382ebbc2@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 12/17/20 14:57, Laszlo Ersek wrote:

> So, as long as it's up to me, OVMF never "just takes" but "adds from
> zero", and I do stick with the absolute minimum needed.

... I mean this specific patch only adds the two most basic headers
really (VIRTIO_FS_FUSE_REQUEST, VIRTIO_FS_FUSE_RESPONSE), and the rest
of the structs are introduced gradually over the series -- only when an
actual FUSE request type needs to be sent for the desired functionality.
So it's not a "dump of definitions" at any point in the series.

The complete set of structures+flags, defined in the FUSE 7.31 interface
version, never lands in its entirety in "OvmfPkg/Include/IndustryStandard".

Thanks,
Laszlo