From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.4153.1622104154125830924 for ; Thu, 27 May 2021 01:29:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VJA1z5Jb; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622104153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MhBCnwayFPNsgVNGdBpHk4U6Qk69WeNeIY4wNl7fOL4=; b=VJA1z5Jbz3TJp8N82XFDQesiZ0GPnDktNvI1DA8g4XIhrQpP8cp77LCIgrVCwLAvTTPOfN zi2gaxDOgnSwyMxPiFaXaB3TpNHyNjZfRysC4GMIUlido4B74p3IReNAh+UypfcpKsrTBj UUqfBKsGXyqHDtPGP0t6cTJxWZdExNo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-zdXTYqPAMSWN_7zhr3Fdlg-1; Thu, 27 May 2021 04:29:11 -0400 X-MC-Unique: zdXTYqPAMSWN_7zhr3Fdlg-1 Received: by mail-wm1-f69.google.com with SMTP id x20-20020a1c7c140000b029018f49a7efb7so1227341wmc.1 for ; Thu, 27 May 2021 01:29:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MhBCnwayFPNsgVNGdBpHk4U6Qk69WeNeIY4wNl7fOL4=; b=StOnkt1SXQdwa79GQqP8C0eVjiCDc8J143YVh7kk9VX63r3C2dLzYtd6uMEsLf+OQO Bqfmw0j9dTkdhhrT/nqjBDHDxiRD5+013vqzslmjIqDSXNfSqOZi/48TeAYgH3uAhZ0j MnunMz3M/cbfGnG9gegk5h+bKjyW9gx89LMy56rLkhvreOplf0YLHqGZSci/R7dt8of8 qUFWSBlth0PltIarjbSX2o1sn0IStiV3Mk5NzgjuBfloJMCMOFKcfDEUXt94WCTe32ZY 7URpzOwx1rm0OUgCcOOfUGMRiHZf+IP2QQ/t1jue5EdN7bB81eN/SdILJEBK15T9ssx3 qg9A== X-Gm-Message-State: AOAM533e7+bVXskMRUceoGlAMgSCD3Yb+lpAiERY+WTzdBkTR8z6zSzb iBdW4JPYAHngEZruYO9n2kPZ05Y/oOMoD2DnfJ33mXYqI8ngfJlgESE/qpFN3XAhZly0hV1Cxy+ 0BC5igE2pcmyKtg== X-Received: by 2002:a1c:4b13:: with SMTP id y19mr7139562wma.102.1622104150597; Thu, 27 May 2021 01:29:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHHO0GegGNKB6Yegt2FW3D3OjTY2aO6Ec91oyxReO3ZWRZuID+Kip0DiR7gkatBm4pWKXH7Q== X-Received: by 2002:a1c:4b13:: with SMTP id y19mr7139551wma.102.1622104150480; Thu, 27 May 2021 01:29:10 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id s15sm2422557wrt.54.2021.05.27.01.29.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 01:29:10 -0700 (PDT) Subject: Re: [PATCH 22/43] OvmfPkg: drop PcdPciDisableBusEnumeration from the IA32, IA32X64, X64 DSCs To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-23-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Thu, 27 May 2021 10:29:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-23-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > With the Xen-dependent PcdSetBoolS() call removed from > OvmfPkg/PlatformPei, the "OvmfPkgIa32.dsc", "OvmfPkgIa32X64.dsc", > "OvmfPkgX64.dsc" platforms never write "PcdPciDisableBusEnumeration". This > means we don't need a dynamic default for the PCD in the DSC files; it > could be declared Fixed-at-Build. > > However, because the PCD's default value in "MdeModulePkg.dec" is FALSE, > remove the (same-value) platform defaults altogether. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/OvmfPkgIa32.dsc | 1 - > OvmfPkg/OvmfPkgIa32X64.dsc | 1 - > OvmfPkg/OvmfPkgX64.dsc | 1 - > 3 files changed, 3 deletions(-) Reviewed-by: Philippe Mathieu-Daude