public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Pete Batard <pete@akeo.ie>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: [PATCH v2 0/3] MdeModulePkg/EbcDxe: add EBC Debugger
Date: Mon, 14 Nov 2016 11:06:48 +0000	[thread overview]
Message-ID: <e6ddf917-c760-de14-33e3-115083614991@akeo.ie> (raw)

Hi,

This is v2 of a patchset to add the EBC Debugger back into EDK2.

Notes regarding this updated version are as follows:

0. You can find a github repo with this series of patch at:
https://github.com/pbatard/edk2/tree/EbcDebugger_v2 (patches at 
https://github.com/pbatard/edk2/commits/EbcDebugger_v2)

1. The series was broken down in 3 parts, with:
- changes that impact the existing driver code (1/3)
- changes that introduce the debugger code (2/3)
- changes related to factorizing and cleaning up the EBC headers (3/3)

2. This version introduces EbcDebuggerHook.c which contains the null 
version of the Debugger hooks, which enables keeping EBC driver 
compilation as it was, and avoids the use of a macro or Pcd for the 
debugger compilation. Note that I preferred to go with 
'EbcDebuggerHook.c' rather than 'EbcDebuggerHookNull.c', as I think it 
fits better with 'EbcDebuggerHook.h' and the comments in the header make 
it very explicit that this only contains the null version of the hooks.

3. Because a version is used by both the debugger and the driver, the 
prototype for EbcDebugSignalException() was also moved from EbcInt.h to 
EbcDebuggerHook.h

4. I chose to move the definitions that relate to the EBC VM into 
EbcVmTest.h and the rest (opcode related) to Ebc.h, as I think it made 
more sense.
On a semi related note, I think that, at some stage, we should rename 
(or split) EbcVmTest.h because it is confusing as it's not used for 
testing only (all the EBC VM implementations use that file for the 
private EBC VM structure).  But of course, that is something that is 
better done outside of this patch series.

Regards,

/Pete


             reply	other threads:[~2016-11-14 11:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 11:06 Pete Batard [this message]
2016-11-14 11:51 ` [PATCH v2 0/3] MdeModulePkg/EbcDxe: add EBC Debugger Laszlo Ersek
2016-11-14 11:53   ` Laszlo Ersek
2016-11-14 13:18     ` Pete Batard
2016-11-14 13:58       ` Yao, Jiewen
2016-11-14 14:11         ` Pete Batard
2016-11-14 14:39           ` Yao, Jiewen
2016-11-16  2:08             ` Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6ddf917-c760-de14-33e3-115083614991@akeo.ie \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox