From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F04F581E06 for ; Mon, 14 Nov 2016 03:06:46 -0800 (PST) Received: by mail-wm0-x242.google.com with SMTP id u144so14238656wmu.0 for ; Mon, 14 Nov 2016 03:06:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=from:subject:to:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=rSD5YEWNMQY5PLUFeUntxapKpO5li6f8SEqa+GhS1FE=; b=toAHlHG/yftLTfM2rCsNF6dJ/6nY2MyPXS5pBf+FXKlc1MGVHrv4NBoj0ELw3g48Lx K0Ps95sSuHe90ELHVjuNJgiPJacMJviJzrXvEB/hlws/oAxi4r9uoPl5srFH3M6ZZd2C 3bszgQK9r849Vjji2VuLqrc7YjzxP2D1hva1QJRp8r6nGvLP0BeicumkqbqZ2nHaHb1o VAmhO8EyfGXCNqyp/o1FIACRJVFAoi95AaQeFRFNgg60HzMsDEAsGfg+0j3vfjZea+vY iq6/G5DX3sPa0fHb4KjjkxjNRbDk1aqIDSHoGXwoZcjKLWDJXCzwDkwYIg30Gy6D7SSl rgpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=rSD5YEWNMQY5PLUFeUntxapKpO5li6f8SEqa+GhS1FE=; b=j1kwW6vs6/Yin2V4D5L8EJBjMNxZeVk5JgVhsNk/eWYjnghtl0ID+jXH2cM+zl91hc nAwqi4dZc8Z1YumF5aRMujwYg26JWBxa89IoH2nrZqr+mAU1eQxGAqme1J/ujcEd3oCJ NZjFYKrQhcJWtgQejisRHz8rqVQXVGFzwEyR3UVf/e2ilEWyDJjYyvxws6cdl07YqBV1 p2l/0UyiM0ZoTs4xyYto+RerLTWJizxUx9FUfNzF5OuDk3EH47Izz57bAFMBW7zwGypX kU+cprWOH1ZC89ki2wP+Kkyor5BkFp8CW9ZQmj/J9knLjMHOK5bOE53y89tD4f5uFXP3 4Wvw== X-Gm-Message-State: ABUngvfIo3llK0DTBxlFdltQ3seO/opF0M6+MrEBh3rTIkIS2zNJL7B+MWzHpvvpmBWi8A== X-Received: by 10.28.168.137 with SMTP id r131mr9693962wme.16.1479121609802; Mon, 14 Nov 2016 03:06:49 -0800 (PST) Received: from [10.0.0.101] ([84.203.71.247]) by smtp.googlemail.com with ESMTPSA id v202sm12559300wmv.8.2016.11.14.03.06.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Nov 2016 03:06:49 -0800 (PST) From: Pete Batard To: "edk2-devel@lists.01.org" Message-ID: Date: Mon, 14 Nov 2016 11:06:48 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 Subject: [PATCH v2 0/3] MdeModulePkg/EbcDxe: add EBC Debugger X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2016 11:06:47 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi, This is v2 of a patchset to add the EBC Debugger back into EDK2. Notes regarding this updated version are as follows: 0. You can find a github repo with this series of patch at: https://github.com/pbatard/edk2/tree/EbcDebugger_v2 (patches at https://github.com/pbatard/edk2/commits/EbcDebugger_v2) 1. The series was broken down in 3 parts, with: - changes that impact the existing driver code (1/3) - changes that introduce the debugger code (2/3) - changes related to factorizing and cleaning up the EBC headers (3/3) 2. This version introduces EbcDebuggerHook.c which contains the null version of the Debugger hooks, which enables keeping EBC driver compilation as it was, and avoids the use of a macro or Pcd for the debugger compilation. Note that I preferred to go with 'EbcDebuggerHook.c' rather than 'EbcDebuggerHookNull.c', as I think it fits better with 'EbcDebuggerHook.h' and the comments in the header make it very explicit that this only contains the null version of the hooks. 3. Because a version is used by both the debugger and the driver, the prototype for EbcDebugSignalException() was also moved from EbcInt.h to EbcDebuggerHook.h 4. I chose to move the definitions that relate to the EBC VM into EbcVmTest.h and the rest (opcode related) to Ebc.h, as I think it made more sense. On a semi related note, I think that, at some stage, we should rename (or split) EbcVmTest.h because it is confusing as it's not used for testing only (all the EBC VM implementations use that file for the private EBC VM structure). But of course, that is something that is better done outside of this patch series. Regards, /Pete