public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Wendy Liao <wendy.liao@insyde.com>
To: devel@edk2.groups.io
Cc: Leon Chen <leon.chen@insyde.com>, Tim Lewis <tim.lewis@insyde.com>
Subject: [PATCH] MdeModulePkg/Core/Pei: set AprioriCount=0 before walking through next FV
Date: Wed, 10 May 2023 14:22:56 +0800	[thread overview]
Message-ID: <e707fc9e-d801-c799-b041-c1d3be185a5c@insyde.com> (raw)


REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4438

The main dispatch loop in PeiDispatcher() goes through each FV and
calls DiscoverPeimsAndOrderWithApriori() to search Apriori file to
reorder all PEIMs then do the PEIM dispatched.

DiscoverPeimsAndOrderWithApriori() calculates Apriori file count for
every FV once and set Private->AprioriCount, but Private->AprioriCount
doesn't be set to 0 before dispatch loop walking through the next FV.

It causes the peim which sort on less than Private->AprioriCount and
depex is not satisfied would be dispatched when dispatch loop go through
to a scaned FV, even the peim is not set in APRIORI file.

Cc: Leon Chen <leon.chen@insyde.com>
Cc: Tim Lewis <tim.lewis@insyde.com>
Reported-by: Esther Lee <esther.lee@insyde.com>
Signed-off-by: Wendy Liao <wendy.liao@insyde.com>

---
  MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c 
b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
index d8284f9f4f..5f32ebb560 100644
--- a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
+++ b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
@@ -1630,6 +1630,7 @@ PeiDispatcher (
        Private->CurrentFileHandle    = NULL;
        Private->CurrentPeimCount     = 0;
        Private->CurrentFvFileHandles = NULL;
+      Private->AprioriCount         = 0;
      }

      //
-- 
2.29.2.windows.2



             reply	other threads:[~2023-05-10  6:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-10  6:22 Wendy Liao [this message]
2023-05-11  1:32 ` 回复: [edk2-devel] [PATCH] MdeModulePkg/Core/Pei: set AprioriCount=0 before walking through next FV gaoliming
2023-05-11  2:22   ` Wendy Liao
2023-05-11  2:53     ` 回复: " gaoliming
2023-05-15  5:18       ` Wendy Liao
2023-05-16  1:23         ` 回复: 回复: 回复: [edk2-stable202305] " gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e707fc9e-d801-c799-b041-c1d3be185a5c@insyde.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox