From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web12.6471.1588077851788585478 for ; Tue, 28 Apr 2020 05:44:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Lljeo/yj; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588077851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AEfsSWn//SpuNcQHnmvCl7I2jeKW8W6HcdhYa8OHdmY=; b=Lljeo/yjozn9GtB2wPmkiRNfazi65UzYrrIWD0Au8NydcngUmYU0/qxfCEoTYZLG3w1yXi eD7l6QBN5rcxsaDtTxNvKE0VyxMX1E2g4GbfHOwd8GXk5QqqaFSuxmtjEFI4ofM3TutoJt IMtiR9Wo7abqMBTbWyN//BJx7T2YVA8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-424-yKyBTiWaPcu5i_8SwJ24rQ-1; Tue, 28 Apr 2020 08:44:06 -0400 X-MC-Unique: yKyBTiWaPcu5i_8SwJ24rQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 018271937FDF; Tue, 28 Apr 2020 12:44:05 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-33.ams2.redhat.com [10.36.113.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 84516610AB; Tue, 28 Apr 2020 12:44:03 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , devel@edk2.groups.io, rebecca@bsdio.com Cc: Jordan Justen , Ard Biesheuvel References: <20200424221707.183492-1-rebecca@bsdio.com> <6969918a-0948-559e-7679-ba94e8f3bfd8@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 28 Apr 2020 14:44:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <6969918a-0948-559e-7679-ba94e8f3bfd8@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable On 04/27/20 10:56, Philippe Mathieu-Daud=E9 wrote: > On 4/25/20 12:17 AM, Rebecca Cran wrote: >> Signed-off-by: Rebecca Cran >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> --- >> =A0 OvmfPkg/AcpiPlatformDxe/EntryPoint.c=A0=A0=A0=A0=A0=A0=A0=A0=A0 |=A0= 8 +- >> =A0 OvmfPkg/AcpiPlatformDxe/PciDecoding.c=A0=A0=A0=A0=A0=A0=A0=A0 | 10 += -- >> =A0 OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c=A0=A0=A0=A0=A0=A0 | 32 ++++-= --- >> =A0 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c=A0=A0=A0 | 16 ++-- >> =A0 OvmfPkg/Csm/CsmSupportLib/LegacyInterrupt.c=A0=A0 |=A0 2 +- >> =A0 OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c=A0=A0=A0 |=A0 2 +- >> =A0 OvmfPkg/Csm/CsmSupportLib/LegacyRegion.c=A0=A0=A0=A0=A0 |=A0 2 +- >> =A0 OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c=A0=A0=A0=A0=A0=A0=A0 | 18 ++-= -- >> =A0 OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c | 80 +++++++++--------= -- >> =A0 OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c=A0=A0=A0=A0=A0=A0=A0=A0 | 62 += ++++++------- >> =A0 OvmfPkg/Csm/LegacyBiosDxe/LegacySio.c=A0=A0=A0=A0=A0=A0=A0=A0 |=A0 2= +- >> =A0 OvmfPkg/Csm/LegacyBiosDxe/Thunk.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0 |=A0 2 +- >> =A0 .../LegacyBootMaintUiLib/LegacyBootMaintUi.c=A0 |=A0 2 +- >> =A0 OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c=A0=A0 |=A0 6 +- >> =A0 OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c=A0=A0=A0=A0=A0=A0=A0 | 16 ++-= - >> =A0 .../IncompatiblePciDeviceSupport.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 = |=A0 2 +- >> =A0 .../Library/AcpiTimerLib/BaseAcpiTimerLib.c=A0=A0 |=A0 2 +- >> =A0 .../AcpiTimerLib/BaseRomAcpiTimerLib.c=A0=A0=A0=A0=A0=A0=A0 |=A0 4 += - >> =A0 .../Library/AcpiTimerLib/DxeAcpiTimerLib.c=A0=A0=A0 |=A0 2 +- >> =A0 OvmfPkg/Library/LoadLinuxLib/Linux.c=A0=A0=A0=A0=A0=A0=A0=A0=A0 |=A0= 8 +- >> =A0 OvmfPkg/Library/NvVarsFileLib/FsAccess.c=A0=A0=A0=A0=A0 | 16 ++-- >> =A0 .../PciHostBridgeLib/PciHostBridgeLib.c=A0=A0=A0=A0=A0=A0 | 18 ++--- >> =A0 .../PlatformBootManagerLib/BdsPlatform.c=A0=A0=A0=A0=A0 | 30 +++---- >> =A0 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c=A0=A0 |=A0 6 +- >> =A0 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c=A0=A0 |=A0 2 +- >> =A0 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPei.c=A0=A0 |=A0 6 +- >> =A0 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSec.c=A0=A0 |=A0 8 +- >> =A0 .../SerializeVariablesLib.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0 |=A0 2 +- >> =A0 .../SmbiosVersionLib/DetectSmbiosVersionLib.c |=A0 4 +- >> =A0 .../VirtioMmioDeviceLib/VirtioMmioDevice.c=A0=A0=A0 |=A0 2 +- >> =A0 .../Library/XenHypercallLib/XenHypercall.c=A0=A0=A0 |=A0 2 +- >> =A0 OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.c=A0=A0 |=A0 4 +- >> =A0 OvmfPkg/PlatformDxe/Platform.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 |=A0 6 +- >> =A0 OvmfPkg/PlatformPei/FeatureControl.c=A0=A0=A0=A0=A0=A0=A0=A0=A0 |=A0= 4 +- >> =A0 OvmfPkg/PlatformPei/Fv.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0 |=A0 2 +- >> =A0 OvmfPkg/PlatformPei/MemDetect.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0 | 10 +-- >> =A0 OvmfPkg/PlatformPei/Platform.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 | 22 ++--- >> =A0 OvmfPkg/PlatformPei/Xen.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0 |=A0 4 +- >> =A0 .../FwBlockService.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0 | 10 +-- >> =A0 .../FwBlockServiceDxe.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0 |=A0 4 +- >> =A0 .../FwBlockServiceSmm.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0 |=A0 2 +- >> =A0 .../QemuFlash.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 | 14 ++-- >> =A0 OvmfPkg/QemuVideoDxe/Driver.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 | 10 +-- >> =A0 OvmfPkg/QemuVideoDxe/Gop.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0 |=A0 4 +- >> =A0 OvmfPkg/QemuVideoDxe/Initialize.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0 |=A0 8 +- >> =A0 OvmfPkg/QemuVideoDxe/VbeShim.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 |=A0 4 +- >> =A0 OvmfPkg/SataControllerDxe/SataController.c=A0=A0=A0 | 12 +-- >> =A0 OvmfPkg/Sec/SecMain.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0 | 22 ++--- >> =A0 OvmfPkg/SmmAccess/SmmAccessPei.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0 |=A0 4 +- >> =A0 OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c=A0=A0=A0=A0=A0=A0 | 16 ++-- >> =A0 OvmfPkg/VirtioGpuDxe/Commands.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0 |=A0 8 +- >> =A0 OvmfPkg/VirtioGpuDxe/DriverBinding.c=A0=A0=A0=A0=A0=A0=A0=A0=A0 |=A0= 8 +- >> =A0 OvmfPkg/VirtioGpuDxe/VirtioGpu.h=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0 |=A0 2 +- >> =A0 OvmfPkg/XenBusDxe/EventChannel.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0 |=A0 2 +- >> =A0 OvmfPkg/XenBusDxe/GrantTable.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 |=A0 8 +- >> =A0 OvmfPkg/XenBusDxe/XenBus.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0 | 14 ++-- >> =A0 OvmfPkg/XenBusDxe/XenBusDxe.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 |=A0 4 +- >> =A0 OvmfPkg/XenBusDxe/XenStore.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0 | 28 +++---- >> =A0 OvmfPkg/XenIoPciDxe/XenIoPciDxe.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0 |=A0 2 +- >> =A0 OvmfPkg/XenPvBlkDxe/BlockFront.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0 | 50 ++++++------ >> =A0 OvmfPkg/XenPvBlkDxe/BlockIo.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 |=A0 6 +- >> =A0 OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0 |=A0 2 +- >> =A0 62 files changed, 335 insertions(+), 335 deletions(-) >=20 > Reviewed-by: Philippe Mathieu-Daude >=20 Thanks Phil, I will take your word on this one. I was ready to reject this patch, in this "unstructured dump" form, but I trust your review. Hence: Acked-by: Laszlo Ersek Rebecca: thanks for the contribution. Personally I'd have preferred a finer-grained approach here, but Phil removed the review burden on me. Regarding the git history, edk2 unfortunately alreay carries a bunch of similarly large (even huge) coding style update patches, so I I can't hold that perspective against the patch. Thanks, Laszlo