From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fb.mail.gandi.net (spool8.mail.gandi.net [217.70.178.217]) by nmboxes7-ms7.sd4.0x35.net (Postfix) with ESMTPS id E82FE61930 for ; Tue, 16 Jan 2024 05:56:55 +0000 (UTC) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by fb.mail.gandi.net (Postfix) with ESMTPS id 598AB60376 for ; Tue, 16 Jan 2024 05:56:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=rWn612/5RZvS8jKOibUFDy2UTntOWFdlfG5ElnpsjUE=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:From:Subject:To:Cc:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705384614; v=1; b=thPy2MqGPpN6SQdUPWdIJZAJr/yPhG6aXd7eezJArbQBn38TGApZV3V5/sQLe/rB6DleFwHu F7fHx1F40C1HmTlyNK9OHE8/2KAo3JXjHLhapvM63+yM55S597700SOudJbwrO+UHF5RghSEMHu BAmb/Y4gS1NLc7iPuuBtDlbI= X-Received: by 127.0.0.2 with SMTP id taj5YY7687511x4KSS6MvfG1; Mon, 15 Jan 2024 21:56:54 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.76598.1705317013635812373 for ; Mon, 15 Jan 2024 03:10:13 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2C19F2F4; Mon, 15 Jan 2024 03:10:59 -0800 (PST) X-Received: from [10.34.100.129] (e126645.nice.arm.com [10.34.100.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E6F163F5A1; Mon, 15 Jan 2024 03:10:11 -0800 (PST) Message-ID: Date: Mon, 15 Jan 2024 12:10:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: "PierreGondois" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2 4/8] Platform/Sgi: Add ACPI tables for RD-Fremont platform To: devel@edk2.groups.io, prabin.ca@arm.com Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar References: <20240112154759.1222138-1-prabin.ca@arm.com> <20240112154759.1222138-5-prabin.ca@arm.com> In-Reply-To: <20240112154759.1222138-5-prabin.ca@arm.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: CWIGVnAeidtOIFuatdhVj6w4x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: fb.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=thPy2MqG; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (fb.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/12/24 16:47, Prabin CA via groups.io wrote: > From: Shriram K >=20 > RD-Fremont is the next platform in the Arm's reference design platform > series. This platform includes 32 CPUs but the fixed virtual platform > (FVP) simulates 16 CPUs of the platform. There is one CPU per cluster in > the system and so the FVP simulates 16 clusters. In preparation for > adding support for this platform, add the initial set of ACPI tables and > reuse existing ACPI tables as applicable to boot a operating system on > this platform. >=20 > Signed-off-by: Shriram K I think this should be replaced with: 'Co-authored-by', cf: - https://gcc.gnu.org/dco.html - https://edk2.groups.io/g/devel/topic/82627064#74861 Same remark for: - [PATCH V2 1/8] Platform/Sgi: Update the datatype of PcdSmmuBase from u32 = to u64 > Signed-off-by: Prabin CA > --- > Platform/ARM/SgiPkg/AcpiTables/RdFremontAcpiTables.inf | 73 ++++++++ > Platform/ARM/SgiPkg/AcpiTables/RdFremont/Dsdt.asl | 196 ++++++++++= ++++++++++ > Platform/ARM/SgiPkg/AcpiTables/RdFremont/Madt.aslc | 138 ++++++++++= ++++ > Platform/ARM/SgiPkg/AcpiTables/RdFremont/Pptt.aslc | 167 ++++++++++= +++++++ > 4 files changed, 574 insertions(+) >=20 [snip] > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdFremont/Madt.aslc b/Platfor= m/ARM/SgiPkg/AcpiTables/RdFremont/Madt.aslc > new file mode 100644 > index 000000000000..e81ce86ae8fd > --- /dev/null > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdFremont/Madt.aslc > @@ -0,0 +1,138 @@ > +/** @file > +* Multiple APIC Description Table (MADT) > +* > +* Copyright (c) 2024, Arm Limited. All rights reserved. > +* > +* SPDX-License-Identifier: BSD-2-Clause-Patent > +* > +**/ > + > +#include > +#include > +#include > + > +#include "SgiAcpiHeader.h" > +#include "SgiPlatform.h" > + > +#define CORE_CNT (FixedPcdGet32 (PcdClusterCount) * \ > + FixedPcdGet32 (PcdCoreCount)) > + > +// Multiple APIC Description Table > +#pragma pack (1) > + > +typedef struct { > + EFI_ACPI_6_4_MULTIPLE_APIC_DESCRIPTION_TABLE_HEADER Header; > + EFI_ACPI_6_4_GIC_STRUCTURE GicInterfaces[CO= RE_CNT]; > + EFI_ACPI_6_4_GIC_DISTRIBUTOR_STRUCTURE GicDistributor; > + EFI_ACPI_6_4_GICR_STRUCTURE GicRedistributor= ; > + EFI_ACPI_6_4_GIC_ITS_STRUCTURE GicIts[6]; > +} EFI_ACPI_6_4_MULTIPLE_APIC_DESCRIPTION_TABLE; > + > +#pragma pack () > + > +STATIC EFI_ACPI_6_4_MULTIPLE_APIC_DESCRIPTION_TABLE Madt =3D { > + { > + ARM_ACPI_HEADER ( > + EFI_ACPI_6_4_MULTIPLE_APIC_DESCRIPTION_TABLE_SIGNATURE, > + EFI_ACPI_6_4_MULTIPLE_APIC_DESCRIPTION_TABLE, > + EFI_ACPI_6_4_MULTIPLE_APIC_DESCRIPTION_TABLE_REVISION > + ), > + // MADT specific fields > + 0, // LocalApicAddress > + 0 // Flags > + }, > + { > + // Format: EFI_ACPI_6_4_GICC_STRUCTURE_INIT(GicId, AcpiCpuUid, Mpidr= , Flags, > + // PmuIrq, GicBase, GicVBas= e, > + // GicHBase, GsivId, GicRBa= se, > + // Efficiency, > + // SpeOverflowInterrupt) > + // Note: The GIC Structure of the primary CPU must be the first entr= y > + // (see note in 5.2.12.14 GICC Structure of ACPI v6.4). > + EFI_ACPI_6_4_GICC_STRUCTURE_INIT( // Neoverse Poseidon core0 > + 0, 0, GET_MPID(0x0, 0x0), EFI_ACPI_6_4_GIC_ENABLED, 23, > + FixedPcdGet32 (PcdGicDistributorBase), > + 0x2c020000, 0x2c010000, 25, 0, 0, 0), This seems to be generic to all other platforms, so this is just a remark, but it is curious the GICH/GICV addresses are hard-coded for all platforms. (Again, this is just a remark, nothing to be changed). > + EFI_ACPI_6_4_GICC_STRUCTURE_INIT( // Neoverse Poseidon core1 > + 0, 1, GET_MPID(0x100, 0x0), EFI_ACPI_6_4_GIC_ENABLED, 23, > + FixedPcdGet32 (PcdGicDistributorBase), > + 0x2c020000, 0x2c010000, 25, 0, 0, 0), > + EFI_ACPI_6_4_GICC_STRUCTURE_INIT( // Neoverse Poseidon core2 > + 0, 2, GET_MPID(0x200, 0x0), EFI_ACPI_6_4_GIC_ENABLED, 23, > + FixedPcdGet32 (PcdGicDistributorBase), > + 0x2c020000, 0x2c010000, 25, 0, 0, 0), > + EFI_ACPI_6_4_GICC_STRUCTURE_INIT( // Neoverse Poseidon core3 > + 0, 3, GET_MPID(0x300, 0x0), EFI_ACPI_6_4_GIC_ENABLED, 23, > + FixedPcdGet32 (PcdGicDistributorBase), > + 0x2c020000, 0x2c010000, 25, 0, 0, 0), [snip] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113815): https://edk2.groups.io/g/devel/message/113815 Mute This Topic: https://groups.io/mt/103685116/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-