From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web11.9240.1589385165405738059 for ; Wed, 13 May 2020 08:52:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FbqLNesa; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589385164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u7DHmKQxSTbzmLNEBGj7SEQ7nVsKE/uSPG+x2U/i9yA=; b=FbqLNesaH/VMRocKHu/fo7eHqe932UA51vru+MBVJbpE/la2pjwoYLFZXxi3GEmrbhth3O 3LH+pFYREAQvIU+1RpQSByIkohut6hZgSWnQ7PXTqps+6IzByVjHSKL+NvOr7Hawy6Ugdz F1+jw9PjISCUW+YcsQyppW6JM3mGQHM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-369-9jCd4u6kPy2vLDfX0_FOCg-1; Wed, 13 May 2020 11:52:40 -0400 X-MC-Unique: 9jCd4u6kPy2vLDfX0_FOCg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 39E9D846376; Wed, 13 May 2020 15:52:36 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-95.ams2.redhat.com [10.36.115.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 06F02196AE; Wed, 13 May 2020 15:52:34 +0000 (UTC) Subject: Re: [EXTERNAL] Re: [edk2-devel] [PATCH V5 24/27] UefiCpuPkg: Add support for DebugCommonLib To: devel@edk2.groups.io, bret.barkelew@microsoft.com, "cheptsov@ispras.ru" Cc: "Dong, Eric" , "Ni, Ray" References: <20200512170237.19796-1-cheptsov@ispras.ru> <20200512170237.19796-25-cheptsov@ispras.ru> From: "Laszlo Ersek" Message-ID: Date: Wed, 13 May 2020 17:52:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8bit On 05/13/20 16:43, Bret Barkelew via groups.io wrote: > Having only ever used PRs, what does that mean? He should have copied the “R-b” text and amended that commit message in this version? ... not that it matters much at this point (as we're transitioning to github.com-based reviews), but (just for the record) I explained it in my "unkempt git guide", in step#28 of the "Contributor workflow": https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-28 Thanks Laszlo