From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 95FC521B02822 for ; Tue, 6 Nov 2018 06:34:18 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E430A2D7E0; Tue, 6 Nov 2018 14:34:17 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-95.rdu2.redhat.com [10.10.120.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2661860146; Tue, 6 Nov 2018 14:34:15 +0000 (UTC) To: Leif Lindholm Cc: "Fu, Siyuan" , "edk2-devel@lists.01.org" References: <20181030073328.62924-1-siyuan.fu@intel.com> <20181030105036.sz6opnxgvt4amg75@bivouac.eciton.net> <20181031105911.wr3x4crlu2fnfcti@bivouac.eciton.net> <20181106110235.thk7hzjk5eackqe2@bivouac.eciton.net> From: Laszlo Ersek Message-ID: Date: Tue, 6 Nov 2018 15:34:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181106110235.thk7hzjk5eackqe2@bivouac.eciton.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 06 Nov 2018 14:34:18 +0000 (UTC) Subject: Re: [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 14:34:18 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/06/18 12:02, Leif Lindholm wrote: > On Mon, Nov 05, 2018 at 11:12:20PM +0100, Laszlo Ersek wrote: >>> Ming Huang (cc) has also had issues with this in his latest set (but >>> not before). Can you guys work together to try to figure out what is >>> going wrong? >>> >>> Can you start by testing with an older version of git? >> >> this is indeed a git regression. I ran into it myself recently, when I >> upgraded git from v2.14.1 to v2.19.1. I dug a little into the git source >> code, but couldn't spend much time on it. Ultimately I rolled back the >> upgrade. > > Argh. > >> The diffstats are still well-formed (not truncated) in the individual >> patch emails, under v2.19.1, as long as the "recommended" options are >> used on the cmdline. However, the cumulative diffstat is truncated >> regardless. I couldn't convince git v2.19.1 to keep the previous >> (desired) behavior. >> >> "Documentation/RelNotes/2.17.0.txt" has some words on "diffstat". > > Thanks for tracking this down. I've submitted a patch here: > https://public-inbox.org/git/20181106104811.14625-1-leif.lindholm@linaro.org/T/#u Awesome, I'll test it and report back on the git list. Thanks! Laszlo