From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 042C7AC1296 for ; Tue, 16 Jan 2024 14:41:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=yTP7WQ9SZk7D8vDGz7vxplz1n/y54dwLfnCRh1WqdcA=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705416114; v=1; b=sqe+s03tD8r1rnO3sSNmbWUgJ9Lga79IwiJemm+WbCm+ySd/i4OU/PGoQFNUK75syNYt0r/R AcTBLnx8/0mi27ea+SHGcx4HfGUoGggGhC4goG+/RYFIQF8FitZ9p6TyfOIrSRkiDrqndAK1N+w HNuhUFpJwyzzHq07PrIyV8tM= X-Received: by 127.0.0.2 with SMTP id hN5ZYY7687511xBbLfHcyKio; Tue, 16 Jan 2024 06:41:54 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.16125.1705416113733425101 for ; Tue, 16 Jan 2024 06:41:53 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-96-TWX5t9HXNWqkZdeT5Y-8Rw-1; Tue, 16 Jan 2024 09:41:50 -0500 X-MC-Unique: TWX5t9HXNWqkZdeT5Y-8Rw-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 79A8788CE19; Tue, 16 Jan 2024 14:41:48 +0000 (UTC) X-Received: from [10.39.194.248] (unknown [10.39.194.248]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B0DEC15E6C; Tue, 16 Jan 2024 14:41:47 +0000 (UTC) Message-ID: Date: Tue, 16 Jan 2024 15:41:46 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v7 25/37] ArmVirtPkg: Move PlatformBootManagerLib to OvmfPkg To: Chao Li , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Gerd Hoffmann , Jiewen Yao References: <20240112082153.3284189-1-lichao@loongson.cn> <20240112082534.3299238-1-lichao@loongson.cn> <29414777-a154-bd1c-95c8-6c4f4e01bbcb@redhat.com> <7a1627f4-ed0c-46f7-ac6e-6ab1f16393dd@loongson.cn> From: "Laszlo Ersek" In-Reply-To: <7a1627f4-ed0c-46f7-ac6e-6ab1f16393dd@loongson.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8ln6uj1jC3hOJNwPIqqnSwSix7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=sqe+s03t; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/16/24 12:54, Chao Li wrote: > On 2024/1/15 16:46, Laszlo Ersek wrote: >> On 1/12/24 09:25, Chao Li wrote: >>> @@ -29,7 +29,6 @@ >>> QemuKernel.c >>> =20 >>> [Packages] >>> - ArmVirtPkg/ArmVirtPkg.dec >>> MdeModulePkg/MdeModulePkg.dec >>> MdePkg/MdePkg.dec >>> OvmfPkg/OvmfPkg.dec >> Hmmm. This makes me wonder. >> >> If we can remove the ArmVirtPkg package dependency from the lib instance >> in *this patch*, then we should be able to remove it *earlier* too >> (i.e., independently), while the lib instance still exists under ArmVirt= Pkg. >> >> I don't see why the "ArmVirtPkg.dec" dep becomes superfluous *right here= *. >> >> If I look at this INF file, as of commit 4a443f73fd67, I see at least >> two "ArmVirtPkg.dec" dependencies: >> >> [FixedPcd] >> gArmVirtTokenSpaceGuid.PcdUninstallMemAttrProtocol >> >> [Pcd] >> gArmVirtTokenSpaceGuid.PcdTerminalTypeGuidBuffer >> >> In patch 24 ("ArmVirtPkg: Move two PCD variables into OvmfPkg"), you >> move these PCDs to OvmfPkg. >> >> Ah, I understand now. In brief: this particular hunk belongs to patch 24 >> (where you correctly modify "PlatformBootManagerLib.inf" anyway). The >> point is that, with the movement of both PCDs from the ArmVirt token >> space to the OVMF token space, "PlatformBootManagerLib.inf"'s dependency >> on "ArmVirtPkg.dec" disappears. Therefore the above hunk belongs to >> patch 24. >> >> ... When you implement that, please build-test both patches 24 and 25. >> >> More precisely, your patch set should build at every stage, considering >> both ArmVirt and OVMF platforms. >> >> The command "git rebase --exec" is useful for building a series at every >> stage. >=20 > Do you means this change should belong in patch 24 is better? Yes, please. >=20 > BTW, I did build and tested after applying patches 24 and 25(building > and testing with ArmVirtQemu.dec) and it works fine. Thank you. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113906): https://edk2.groups.io/g/devel/message/113906 Mute This Topic: https://groups.io/mt/103679477/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-