From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4FEBB210C0F45 for ; Mon, 23 Jul 2018 01:28:17 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4D9D387A71; Mon, 23 Jul 2018 08:28:16 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-232.rdu2.redhat.com [10.10.120.232]) by smtp.corp.redhat.com (Postfix) with ESMTP id 96A432026D65; Mon, 23 Jul 2018 08:28:15 +0000 (UTC) To: =?UTF-8?Q?Marvin_H=c3=a4user?= , "edk2-devel@lists.01.org" Cc: "eric.dong@intel.com" References: From: Laszlo Ersek Message-ID: Date: Mon, 23 Jul 2018 10:28:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 23 Jul 2018 08:28:16 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 23 Jul 2018 08:28:16 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH] UefiCpuPkg/CpuMpPei: Correct BIST PPI logic. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 08:28:18 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 07/22/18 00:17, Marvin Häuser wrote: > Currently, the SecPlatformInformation2 PPI is installed when either > there is none present or the present one doesn't lack data. > Update the logic to only install the SecPlatformInformation2 PPI when > it's not already installed so that an up-to-date PPI remains the only > one and unchanged. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marvin Haeuser > --- > UefiCpuPkg/CpuMpPei/CpuBist.c | 22 +++++++++++--------- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git a/UefiCpuPkg/CpuMpPei/CpuBist.c b/UefiCpuPkg/CpuMpPei/CpuBist.c > index 20728525e2d9..5312d9f01dc8 100644 > --- a/UefiCpuPkg/CpuMpPei/CpuBist.c > +++ b/UefiCpuPkg/CpuMpPei/CpuBist.c > @@ -275,18 +275,20 @@ CollectBistDataFromPpi ( > (UINTN) BistInformationSize > ); > > - if (SecPlatformInformation2 != NULL && NumberOfData < NumberOfProcessors) { > - // > - // Reinstall SecPlatformInformation2 PPI to include new BIST information > - // > - Status = PeiServicesReInstallPpi ( > - SecInformationDescriptor, > - &mPeiSecPlatformInformation2Ppi > - ); > - ASSERT_EFI_ERROR (Status); > + if (SecPlatformInformation2 != NULL) { > + if (NumberOfData < NumberOfProcessors) { > + // > + // Reinstall SecPlatformInformation2 PPI to include new BIST information > + // > + Status = PeiServicesReInstallPpi ( > + SecInformationDescriptor, > + &mPeiSecPlatformInformation2Ppi > + ); > + ASSERT_EFI_ERROR (Status); > + } > } else { > // > - // Install SecPlatformInformation2 PPI to include new BIST information > + // Install SecPlatformInformation2 PPI > // > Status = PeiServicesInstallPpi (&mPeiSecPlatformInformation2Ppi); > ASSERT_EFI_ERROR(Status); > Looks good to me: Reviewed-by: Laszlo Ersek but Eric should decide. Thanks Laszlo