From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.115]) by mx.groups.io with SMTP id smtpd.web10.21886.1683272832162253232 for ; Fri, 05 May 2023 00:47:12 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=QREOB5mk; spf=pass (domain: os.amperecomputing.com, ip: 40.107.223.115, mailfrom: minhnguyen1@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AlS5uUstuRnPmNYryA4eRpCHfR9VAe6YOvOFZSG4uy8jVB41ks7GtXySBSu25cGO9pxUlReQ38UWAbeAmXJFCYc7mDfFKhbWmjgbNi9Z2eqwz5yIS6pGLuer/24VrVSayTx5y4EkjY8Yt0pS9nmK4Ob4t3QVWrbtY4wYndnMX/FEY1cfn05ROeZ38CC1UhajipVzqxUrCi+0ySz6xLDghyHuKSJTYEWTtKwDIVGrbfhBzKyjezDG3vhVwuLnu7ms9EhXcOEqOOv9kT3k6V1pS4Lhjelvl8fbKBtGgYam7tmYwyuHIMYEsE3Z8RLix3i8oHQWskhXl31dAqMNHIJA/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6cJ86+QCAX5HCyTy/zkGHCX5fiX/aGZmNsdMauZWwLM=; b=Tte03NTZNSFXzP1I9GV7l8T6XtiBXsHwhwEzKdcczG2kGPiPv9r0iSokCQCPxOOQiaKGHe2e2pHEZXuZ8Rtx73/4YraMrNjP2Ku3lVDjBt/Sy8YLgtXrK8KrZp1LLq8eBKfw1nrlg0VwtTyvAAhQxzCUkDrN//B/s+S2fGYH6aGemb6aRjx5KyXON9HVm491GUuEea4xGoEsrWtuXd8joVl9dgZOmHAaYutz1FOgotFgkzzhOKxCd6vLwTaknFh3pe900ItP0RXKurdYh6OUAYyQDlNfDLVLOw/c/ic5jAsz2mICBBJBh5mhl3FSfDyoVA8wq2XB2VRcPGU/nuoA1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6cJ86+QCAX5HCyTy/zkGHCX5fiX/aGZmNsdMauZWwLM=; b=QREOB5mkYE/zBlFWhtko5q9sflUFM/RPLYBoCBM7KwLHI2pu/dGpVAgGV0lObjH8EWETxe4jqlTznbj1QbZtTzTUxVksorhqHMd3B0p0v+CwgqeW2G+fD8Eg4rzvQTbmtSVHuZ7R059aOhrKBTWU18GAv7f9mh6G91QHnNAqXS8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by DM6PR01MB5625.prod.exchangelabs.com (2603:10b6:5:178::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 07:47:09 +0000 Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Fri, 5 May 2023 07:47:08 +0000 Message-ID: Date: Fri, 5 May 2023 14:47:00 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH V3 0/5] Adding necessary changes for RedfishPkg To: "Chang, Abner" , minhnampere , "devel@edk2.groups.io" CC: "patches@amperecomputing.com" , "nicklew@nvidia.com" , "igork@ami.com" , "nhi@os.amperecomputing.com" , "tinhnguyen@os.amperecomputing.com" References: <20230505064600.1478461-1-minhnguyen1@os.amperecomputing.com> From: Minh Nguyen In-Reply-To: X-ClientProxiedBy: SG2PR06CA0239.apcprd06.prod.outlook.com (2603:1096:4:ac::23) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) Return-Path: minhnguyen1@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|DM6PR01MB5625:EE_ X-MS-Office365-Filtering-Correlation-Id: 75625327-1ef3-4708-acd6-08db4d3ceda3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O1XXvimXOrED4ph7scTV2QcdCUFf46X78SpLa1/EywJ3GV8j/vXesEKlskAhh+y5yW/8aafOG5zckUkeO2wbaor4DQjWDnlYJTQvGsHdnXLQ/44GyAZj9X76TWOy69iPzxFbQAMVXfQrg0vDkmEeDJWkr8jqTpv3D2slc2DmsB1W8VhtRKBvm2p6bZvoOpe8UdzLCY3S/+JMgqle6nsG4be7XwWITywyz5WxSbGDfutYr7M0iYD6/U0dbCxHj6CK4X8ZmNzyffpw9KKO2ECG2Ig3yE1JDzIXqBxqls1SII9Rhcvw+7USS1AQGqV9TSFSInF7r9YbIV6sG7TToVnxyJ4JZnjCGkpRPJRplrZJkaXid5D5nv7/K29BIvAxq26KRNUCQHmNH834KfsTNtkqEKPy9yrHd9snK+qUKWuj94hzKwmrHikc+DJaObd0wVoiUL8bhn9V9uRvob/x1DKwyO9Z/PmxdoaSpUTTeBEZAXildNy/EeEwMc8jgHyoQxVwOIhMcQUfo+f8MoRTlg8GTidpshCDXX/2ygcuMHeTWQVNncLlfqSK7af3srlHZL0l3thISKcsendkY5awnW+/sWQeJv+aI687eQqaUpBitoCXrkuNnw6RYzjae9ZIktty X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB8048.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39850400004)(136003)(366004)(376002)(396003)(346002)(451199021)(41300700001)(83380400001)(42882007)(316002)(2906002)(5660300002)(83170400001)(478600001)(66476007)(4326008)(38100700002)(66556008)(54906003)(110136005)(31696002)(6486002)(6666004)(186003)(53546011)(6506007)(6512007)(107886003)(26005)(31686004)(66946007)(2616005)(8936002)(8676002)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Q6r1d6ygLBCZPhSgLnKgz3jS3890O2U97ulvSku5E4vMrAwE0sSJQNJDeB2w?= =?us-ascii?Q?DnHRoihbFRsK1AlLRJtQV6260c9qE8jbEahx2CAwTogrKOCv/qf2ESfQTWCC?= =?us-ascii?Q?6TUwU8zYS2CscnvyKcROizVFPjnhpMJ2S9PR84ws3bPb0JbhvVR+LpurlXCV?= =?us-ascii?Q?SJakpbLRwMCD9y/be5jsAAVzawF4TCUurHN9MxDBzp2rJcq9v/7NzCQc16mt?= =?us-ascii?Q?G7gKR7GBOYucHrfgqu+7npQ8lhKbyOvzwTREVN52ANjRnguHtAKbQIpV5WoX?= =?us-ascii?Q?qaJwI4NnC+BuKkkuh2Pug193o3RfLclRD4kDOT+5nYBENe+aWK9kv8SO3hXz?= =?us-ascii?Q?VzclOt9rqsLEWK7glF3UJb7E4ikHI9w7mskASgiNW171qo6k0UqF+a0iS2gr?= =?us-ascii?Q?lm0MjEklDcXAe0Rq2JsdQx0rke8wYEgk1kDunlMffKQFuAcLMcgbZnqsajt3?= =?us-ascii?Q?1T3wX4p9k3Typ50FyOeKTbcKg9oJ/UcQ9XhGctJFLj3IYUy1uTpad2U2orWf?= =?us-ascii?Q?Ni/qyd+MQxk7VT9dw5TTLa1sAMa91SfdJtGYvq0jXLnCEF1OB2lw6UhmlYDG?= =?us-ascii?Q?bnRglU+9pfPquKKpJZ/CDX2DCo9cr3ShMq3WakQsGeVx6mfeA7QgC631ybmv?= =?us-ascii?Q?2YAwYEZTc1EOXrMGnZLLwjmPePgMMf1XvNoGU9EkNFwf81s5K3DS38xc2DgG?= =?us-ascii?Q?WU/mICxzhyXzCswrocYeeNGqSLSai9DDba82BDU2k0ajsc5SkUhRb9GbF5ZT?= =?us-ascii?Q?1ehalIWmf3Ar7LwFcB0z62KloEQChW02/JKml8cz4L6MMxj6w5OATizZCd8p?= =?us-ascii?Q?srd2D/PbiqrDJX1p70DAZxg41ECGRu3lu1Z/4vYFgDLezCGuVWNDn/uAbaGh?= =?us-ascii?Q?klFfPjuuFLvuUGJZR1XiVw3UJ8poSoWjchH1ym30QGi7NbPpFphP5k5TMZRc?= =?us-ascii?Q?aLdnp0BIIQLrEjWKZ1ZOjrGzsMj2s6JeD+0zTn3jjyoZIgo5jbGzcf8xk+4X?= =?us-ascii?Q?6iV1vMYDVyXndcYW8D6F5dy+7z7kdQF93E02ZpEYIpSr4lMpyP0y7AoOlRqm?= =?us-ascii?Q?s9LC5qlCVOoL2Mi1ZclNPXZZn4ZNpQsS+fC2sWEe+7if7/P0kF5qh8B8i8FU?= =?us-ascii?Q?OQ+iMH4gaozfHV/QBZmOD6CB2H8j8XI15IftBqMReeUrvCZMc//Hzri/Vx7a?= =?us-ascii?Q?ZGP08FJ6B7v9isa/s4dFV7pg3HkR52Zg/hGTOvQdba7reRPTzMOoIqCyhZ1N?= =?us-ascii?Q?djoiS0fYLBnFMnttDzgt1sFxURBo7hIsJGTrfRD5Iq4YuoFsqpHPHvzzgd0W?= =?us-ascii?Q?CvPl/ZmgfTJIBJJGVVhMEg4CTcf3a8dxRW1CHnWn4M8tNXPXhBxduUgLaI9V?= =?us-ascii?Q?Qvmxa4+CN3hyCazDdAAYqeVPIwuvAqNW77TuR/oNdnyyt4EaC9LXn5Jr2eSv?= =?us-ascii?Q?cTF5Qxd1f8G5Sjc8ZNjnaYjrcW6baz2AzSKIVWexj0oIVoaB/Nh8H14pOqRY?= =?us-ascii?Q?2SpVAQrxVbXO35qvsd/P+NzHGvL570MSMkSq/OtDbfdeVpnooIU4Jn5brlI9?= =?us-ascii?Q?MOUjmjiLc1f47oXoWQQQxiGbhaBVHHCMCDsKURijbN3qA8T6EGf/DStGvMI0?= =?us-ascii?Q?U9I5BoDrn+ASZOLQ+2/lgH7kQiQoJnCmXwiQ72/kG3KM?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75625327-1ef3-4708-acd6-08db4d3ceda3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 07:47:08.5577 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B+FVB3lsQErQJZt/ec72C6YHOrE/Qr0zuXUL52OnQBF0EUyDGR5jHG24BQcKTz4+fRVg+lLWByc4lPL1A3vtMEZH5KXdlohG4rDfat+Nztt7ZuRaEwDSc3+MK46d43+P X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB5625 Content-Language: en-CA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Abner, =C2=A0I've updated. Thanks for your review. Thanks, Minh Nguyen On 5/5/2023 2:38 PM, Chang, Abner wrote: > [AMD Official Use Only - General] > > Hi Minh, > Please add my RB for 3/5 in commit message and push to minhnampere:Adding= _necessary_changes_for_RedfishPkg again. I will check the PR and merge it= once it passes CI. > > Thank for your contribution. > Abner > >> -----Original Message----- >> From: minhnampere >> Sent: Friday, May 5, 2023 2:46 PM >> To: devel@edk2.groups.io >> Cc: patches@amperecomputing.com; Chang, Abner >> ; nicklew@nvidia.com; igork@ami.com; >> nhi@os.amperecomputing.com; tinhnguyen@os.amperecomputing.com; >> minhnampere >> Subject: [PATCH V3 0/5] Adding necessary changes for RedfishPkg >> >> Caution: This message originated from an External Source. Use proper >> caution when opening attachments, clicking links, or responding. >> >> >> This patchset adds necessary changes for RedfishPkg to avoid some >> unexpected cases and fix compilation. >> >> Changes since v3: >> + Replaced __FUNCTION__ with __func__ to be more C11 compliant. >> Changes since v2: >> + Added "Cc:" to maintainers in commit message. >> + Corrected patch format subject prefix. >> Changes since v1: >> + Removed redundant change and change the commit message for more >> precise in PATCH 2/5. >> >> Nhi Pham (1): >> RedfishPkg: Add missing newline character >> >> Vu Nguyen (4): >> RedfishPkg: Correct variable type to prevent memory corruption >> RedfishPkg: Fix condition checking of error status >> RedfishPkg: Create RestEx child on selected interface >> RedfishPkg: Fix compile issue on Linux >> >> RedfishPkg/Include/Library/RestExLib.h | 3 + >> RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 +- >> RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 +- >> RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c | 153 +++= +++++---- >> -------- >> RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 4 +- >> RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 +- >> 6 files changed, 73 insertions(+), 98 deletions(-) >> >> -- >> 2.39.0