From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web10.41048.1628881537291614480 for ; Fri, 13 Aug 2021 12:05:37 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@ibm.com header.s=pp1 header.b=oLj8himR; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: stefanb@linux.ibm.com) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17DJ5TUv006533; Fri, 13 Aug 2021 15:05:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=dbp2WG4x5iBMmYSqBCiPtolVySZ4KetOURSEK89dK5M=; b=oLj8himR3N5pwysVLiN8PZV6GyxOKwxUL6Fmrmdoi1wKVXXR1VwwyZqIoLkQIV+DNz1D HIFp2Dr5KNNYCkO5UA3iDJU1s26ND4qIRQelKw+GxhC8YjhyQ9PBFfqy0dysTt7BGCrL ubhFEDwQzSoXACQ4NGve3i9+WdQsraZGUkLUd23mngqacDLd2gGrtU7esYv1l7KEF1e4 QxOApgiKA7GchwvcdiwuclODTDmeR+UIz8FRM40m3Fxc2Rj7+FLvnab6D1nSMFNnsuzn cqNVbhoPTUonj/vATaKGMj9sij88hVodiXwcUr+mPjWtVBsZ2/lwUiGswivGiCbxiaDz MA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3adrp4t161-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Aug 2021 15:05:35 -0400 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 17DJ5ZA8007193; Fri, 13 Aug 2021 15:05:35 -0400 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0b-001b2d01.pphosted.com with ESMTP id 3adrp4t13m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Aug 2021 15:05:35 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 17DJ3oA1014373; Fri, 13 Aug 2021 19:03:57 GMT Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by ppma01dal.us.ibm.com with ESMTP id 3ackhs9sju-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Aug 2021 19:03:45 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 17DJ2TDa45416804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Aug 2021 19:02:29 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 69E6B6A047; Fri, 13 Aug 2021 19:02:29 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 049BB6A05D; Fri, 13 Aug 2021 19:02:28 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 13 Aug 2021 19:02:28 +0000 (GMT) Subject: Re: [edk2-devel] [PATCH v4 1/6] OvmfPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms To: Sean Brogan , devel@edk2.groups.io, stefanb@linux.vnet.ibm.com, jiewen.yao@intel.com Cc: marcandre.lureau@redhat.com, lersek@redhat.com, dick_wilkins@phoenix.com, James.Bottomley@HansenPartnership.com References: <20210812165931.3071083-1-stefanb@linux.vnet.ibm.com> <20210812165931.3071083-2-stefanb@linux.vnet.ibm.com> <649733db-0d37-326e-5f83-f6f8ad500cdd@linux.ibm.com> From: "Stefan Berger" Message-ID: Date: Fri, 13 Aug 2021 15:02:28 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: oDMaDqifaEjvucLAoTZf8OGLs7wugr8X X-Proofpoint-GUID: yo914GqJSVeVx0_foh28dqIzIaR2GsjA X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-08-13_06:2021-08-13,2021-08-13 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 bulkscore=0 impostorscore=0 phishscore=0 priorityscore=1501 spamscore=0 mlxscore=0 adultscore=0 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108130112 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0b-001b2d01.pphosted.com id 17DJ5TUv006533 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 8/13/21 2:47 PM, Sean Brogan wrote: > Thanks for the link as i missed that message. > > To me this just points out more problems with how OVMF is being=20 > managed in the edk2 project and the uselessness of edk2 platforms as=20 > anything more than just a dumping ground repo to hold sample code.=C2=A0= =20 > But that is a problem larger than this patchset. > > I guess if you are going doing option 2 can we rename the library=20 > interface you are defining in OvmfPkg so it doesn't conflict with the=20 > existing one in edk2-platforms/minplatform.=C2=A0 That would mean chang= e: I have now created v5 here with the latest code appearing in SecurityPkg=20 again:=20 https://github.com/stefanberger/edk2/commits/stefanberger/ovmf_disable_pl= atform_hierarchy.v5 I can probably post that pretty quickly but I'll be out for a while. If=20 it's urgent, someone else can pick it it up from there. I tested it on=20 QEMU for x86 and aarch64 and test-compiled on various platforms that I=20 touched (some didn't compile for me before the changes). What I wasn't sure about is whether edk2-platforms is a 'holding area'=20 for code to be imported ideally 1:1 into edk2. So I ended up making=20 those changes already in v1 to cut out a dependency. If what I have in=20 v5 (or also v4) is sufficient for general consumption, then let's put it=20 into SecurityPkg. =C2=A0=C2=A0 Stefan > > * name in OvmfPkg.dec file > * header file in OvmfPkg/Include/Library > * all references in DSC file for mapping an instance > * all references in your INFs for dependency > > Thanks > Sean > > > > > > > On 8/12/2021 3:19 PM, Stefan Berger wrote: >> >> On 8/12/21 4:59 PM, Sean Brogan wrote: >>> This seems like a bad place for a general purpose lib that many=20 >>> other platforms may take a dependency on. >>> >>> In v1 this was SecurityPkg.=C2=A0 OvmfPkg is a platform package and=20 >>> therefore not a good place to define broad interfaces. >>> >>> What caused this to move here? >> >> >> Option 2 from this message:=20 >> https://listman.redhat.com/archives/edk2-devel-archive/2021-August/msg= 00398.html=20 >> >> >> =C2=A0=C2=A0 Stefan >> >> >>> >>> Thanks >>> Sean >>> >>>