From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=pete@akeo.ie; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 836E1222CF1BA for ; Fri, 12 Jan 2018 03:05:42 -0800 (PST) Received: by mail-wm0-x242.google.com with SMTP id r78so11157027wme.0 for ; Fri, 12 Jan 2018 03:10:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AtAoJk197l8bbMph1wMqikFmR/7yEvWkeDMB7YxPDME=; b=LZglVxOJ+flvJMP4ScN8uDxq/BelUaZ0bIGgpHeIYMyi1QVsZrM0NuD2sCWCiIzAo2 c2k+3YzJ7d4XCbVwPxizZBchRA29Q8Nvh15Ub8Bb35b8diBYzJT4S6VA0wuXhzdxs5vF 1SxgHA4O65JjZE5tQYgBfxQvvhizH5a/9Zhxx3TSsT2P2rqKVylqkvwRYMe9MDJecGLe ZkVO73fti29fRkRIdAv4M6MurQwFw0yejfdNciJZws28IHw4deG6Y/TLQWYyRVVUlBJW YFsOg9sKxkn99hHKotKSDCXJBPqCAQ9k4wzDmtAN8mG/2nowDeMQYawUW0W07m2GV/9A GD3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AtAoJk197l8bbMph1wMqikFmR/7yEvWkeDMB7YxPDME=; b=eEOzMDErax/svEZ0YVmrZVF9sbAitmP5cxfadXR8vf2eBlUG3ELHnReNB4QlekVtM4 Q7uNhhTOCWsmnd8/L6h7IE9mYDNEPwkfEHVpdN5Wxg3Z6yFG1sB8KdMrIOvlGTHU9LW9 G2FnmSYZfYkJ+pVEwQEigeCo5sMITkzra8xnup/JvCneoczyt2zcEvciSR1GO78SaXWo WKSuQiW++3VM+45Kkvtz5X51vN0cXv2RTPKiELKMSIresbawNMqGS+TL7rcDOM55fZpu fePFRGvg2CfN9MJSYmsFhF+NA/tCpKUUiUwihlUYEa43ZxA6qlwjNiI762w/hb2W+MGj 9q5w== X-Gm-Message-State: AKGB3mJay7FFRmta5+b0Kp3K1OKtvA7ZWVJChCiaHzdYwomrHka9cYVs l6vFu+TPUrbnghREpJPLA/L4+w== X-Google-Smtp-Source: ACJfBoui7q18kMWP/uNgEnrLajTD/x8e+N20d5c5fsJ5qM/jWX97abrnBrW6l4ScmwCxF8BmUz7UnQ== X-Received: by 10.80.219.76 with SMTP id b12mr36665674edl.220.1515755455529; Fri, 12 Jan 2018 03:10:55 -0800 (PST) Received: from [10.0.0.101] ([84.203.42.225]) by smtp.googlemail.com with ESMTPSA id a33sm4724806ede.2.2018.01.12.03.10.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Jan 2018 03:10:53 -0800 (PST) To: Ard Biesheuvel , "Cohen, Eugene" Cc: "edk2-devel@lists.01.org" , "Gao, Liming" References: <20180110162644.11208-1-pete@akeo.ie> <20180110162644.11208-5-pete@akeo.ie> <5ccd6f32-ee75-57e2-75f0-1fe14cba6b05@akeo.ie> From: Pete Batard Message-ID: Date: Fri, 12 Jan 2018 11:10:51 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH v4 4/6] ArmPkg/Library/CompilerIntrinsicsLib: Enable VS2017/ARM builds X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 11:05:43 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2018.01.12 09:58, Ard Biesheuvel wrote: >>> So, to summarise, I would much prefer if we could keep most of the >>> current patch, and simply use the following where needed: >>> >>> AREA s___aeabi_ldivmod, CODE, READONLY, ARM AREA s___aeabi_llsr, >>> CODE, READONLY, ARM AREA s___aeabi_uldivmod, CODE, READONLY, >>> ARM >>> >> >> Agreed, this is fine so long as we agree on the definition of "where needed". In general I would expect each independent assembly function to have its own AREA directive (e.g. math functions). In some cases there will clearly be a collection of dependent functions that would be better served by a single area directive (e.g. MMU initialization functions). >> >> Much Thanks! >> >> Eugene >> > > Agreed. Okay. Introducing/grouping/reviewing the code areas goes beyond the scope of what I am planning to do for this proposal, especially as the current goal is to leave RVCT with as little disturbance as possible, even if some improvements might be applied... So the only thing I am planning to do with the AREA's right now is have them under the exact same name they would have used with the RVCT_... macros. I'll send a new patch to that effect in a couple hours. Regards, /Pete