From: Laszlo Ersek <lersek@redhat.com>
To: "Gao, Liming" <liming.gao@intel.com>,
"Fu, Siyuan" <siyuan.fu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>, "Ye, Ting" <ting.ye@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"Wu, Jiaxin" <jiaxin.wu@intel.com>,
Anthony Perard <anthony.perard@citrix.com>,
"Wei, David" <david.wei@intel.com>
Subject: Re: [PATCH v2 0/6] Add DSC/FDF include segment files for network stack
Date: Mon, 26 Nov 2018 12:34:39 +0100 [thread overview]
Message-ID: <e790855d-2cd9-1820-7187-0ec1dc52dabc@redhat.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E371E57@SHSMSX104.ccr.corp.intel.com>
Hi Liming,
On 11/26/18 04:31, Gao, Liming wrote:
> [...]
Thanks, I think I understand your points better.
That doesn't mean that I agree with all of your points. :)
My suggestion/request is that this series please drop the OvmfPkg &
ArmVirtPkg patches for now, as it's obvious that my preferences cannot
"drive" the NetworkPkg changes, let alone the general, future rules (of
which NetworkPkg is just the first example).
Thus, I'd like to spare Siyuan the repeated updates to OvmfPkg and
ArmVirtPkg.
Instead, once the NetworkPkg changes are mature enough to exemplify the
future rules, and they are merged, we should file TianoCore BZs for
ArmVirtPkg and OvmfPkg, to adopt the new config knobs from NetworkPkg.
These BZs should be assigned to their respective package maintainers,
and they should be considered "best effort". I.e. ArmVirtPkg and OvmfPkg
will consume those new settings from NetworkPkg that they easily can,
and fall back to the explicit configuration everywhere else.
My request is that the NetworkPkg changes please remain backward
compatible, so that existing platforms not break even until they are
updated to take advantage of the new PCDs.
Thanks!
Laszlo
next prev parent reply other threads:[~2018-11-26 11:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 5:21 [PATCH v2 0/6] Add DSC/FDF include segment files for network stack Fu Siyuan
2018-11-22 5:21 ` [PATCH v2 1/6] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg Fu Siyuan
2018-11-22 9:56 ` Ni, Ruiyu
2018-11-22 10:52 ` Fu, Siyuan
2018-11-23 10:56 ` Laszlo Ersek
2018-12-10 8:36 ` Ard Biesheuvel
2018-12-10 14:40 ` Laszlo Ersek
2018-12-10 16:39 ` Ard Biesheuvel
2018-11-22 5:21 ` [PATCH v2 2/6] Nt32Pkg: Update DSC/FDF to use NetworkPkg's include fragment file Fu Siyuan
2018-11-22 5:21 ` [PATCH v2 3/6] ArmVirtPkg: " Fu Siyuan
2018-11-23 12:29 ` Laszlo Ersek
2018-11-23 12:30 ` Laszlo Ersek
2018-11-23 16:50 ` Laszlo Ersek
2018-11-22 5:21 ` [PATCH v2 4/6] EmulatorPkg: " Fu Siyuan
2018-11-22 5:21 ` [PATCH v2 5/6] OvmfPkg: " Fu Siyuan
2018-11-23 12:00 ` Laszlo Ersek
2018-11-23 12:10 ` Laszlo Ersek
2018-11-23 12:19 ` Laszlo Ersek
2018-11-22 5:21 ` [PATCH v2 6/6] Vlv2TbltDevicePkg: " Fu Siyuan
2018-11-22 6:14 ` [PATCH v2 0/6] Add DSC/FDF include segment files for network stack Gao, Liming
2018-11-22 15:48 ` Laszlo Ersek
2018-11-23 16:02 ` Gao, Liming
2018-11-23 18:35 ` Laszlo Ersek
2018-11-26 3:31 ` Gao, Liming
2018-11-26 11:34 ` Laszlo Ersek [this message]
2018-11-22 16:12 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e790855d-2cd9-1820-7187-0ec1dc52dabc@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox