From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ED36820954B99 for ; Wed, 14 Mar 2018 20:18:49 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2018 20:25:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,308,1517904000"; d="scan'208";a="24655525" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.4]) ([10.239.9.4]) by fmsmga008.fm.intel.com with ESMTP; 14 Mar 2018 20:25:11 -0700 To: Guo Heyi Cc: Eric Dong , Ard Biesheuvel , edk2-devel@lists.01.org, Michael D Kinney , Laszlo Ersek , Star Zeng References: <1519887444-75510-1-git-send-email-heyi.guo@linaro.org> <1519887444-75510-5-git-send-email-heyi.guo@linaro.org> <20180306024440.GA90780@SZX1000114654> <71a21699-a1b3-155a-e743-ee5e6288ce20@Intel.com> <20180307060143.GB91936@SZX1000114654> <9f3e6241-e7fd-1178-ddc2-5b1cdd1b1153@Intel.com> <20180315025744.GA108227@SZX1000114654> From: "Ni, Ruiyu" Message-ID: Date: Thu, 15 Mar 2018 11:25:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180315025744.GA108227@SZX1000114654> Subject: Re: [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 03:18:50 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/15/2018 10:57 AM, Guo Heyi wrote: > Hi Ray, > > Sorry I never tried Ecc tool before, for there is few documents about it. When I > tried running python BaseTools/Source/Python/Ecc/Ecc.py -t -s xxxx, > it showed me with error message: > > ImportError: No module named Common.LongFilePathOs > > Then I found there was an executable named "Ecc" in > BaseTools/BinWrappers/PosixLike/, and change the place of "-t" and "-s" after it > prompted: > > : error 1003: Invalid value of option > Target [-s] does NOT exist > > However, it still failed with error: > > RuntimeError: ANTLR version mismatch: The recognizer has been generated with API > V0, but this runtime does not support this. > > I could not find the reason for this error, maybe it was caused by incompatible > version of python and antlr3 (mine is Ubuntu 16.04.3 LTS, python 2.7.12, > python-antlr3 3.5.2-1). > > Finally I downloaded prebuilt Win32 BaseTools and ran Ecc.exe on Windows. It > success and produced a "Report.csv" with only a titel line. I guess this means > there is no error in the coding style, isn't it? > > Please let me know if there is anything wrong with what I did. Sorry I provided the wrong command line. It should be "...Ecc.py -t -s". If you haven't add the function header comments as I pointed out. You should get at least one ECC error. Otherwise, the code change should be fine. Thanks for the try. > > Thanks and regards, > > Heyi >