From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5C6BC211B5A5E for ; Mon, 11 Jun 2018 09:35:40 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A71134002248 for ; Mon, 11 Jun 2018 16:35:39 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-125.rdu2.redhat.com [10.10.120.125]) by smtp.corp.redhat.com (Postfix) with ESMTP id 49B69112D195; Mon, 11 Jun 2018 16:35:35 +0000 (UTC) To: Gerd Hoffmann , edk2-devel@lists.01.org References: <20180608113942.17009-1-kraxel@redhat.com> From: Laszlo Ersek Message-ID: Date: Mon, 11 Jun 2018 18:35:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180608113942.17009-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Mon, 11 Jun 2018 16:35:39 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Mon, 11 Jun 2018 16:35:39 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 0/4] Add QemuRamfbDxe driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 16:35:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/08/18 13:39, Gerd Hoffmann wrote: > This is the efi driver for qemu ramfb, a simple boot framebuffer. > Qemu patches just have been posted to qemu-devel. > > Gerd Hoffmann (4): > OvmfPkg: add QEMU_RAMFB_GUID > OvmfPkg: add QemuRamfbDxe > OvmfPkg: add QemuRamfb to platform console > ArmVirtPkg: add QemuRamfbDxe > > OvmfPkg/Include/Guid/QemuRamfb.h | 25 ++ > .../Library/PlatformBootManagerLib/PlatformData.c | 44 +++ > OvmfPkg/QemuRamfbDxe/QemuRamfb.c | 308 +++++++++++++++++++++ > ArmVirtPkg/ArmVirtQemu.dsc | 2 + > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 1 + > ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 + > OvmfPkg/OvmfPkg.dec | 1 + > OvmfPkg/OvmfPkgIa32.dsc | 1 + > OvmfPkg/OvmfPkgIa32.fdf | 1 + > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > OvmfPkg/OvmfPkgIa32X64.fdf | 1 + > OvmfPkg/OvmfPkgX64.dsc | 1 + > OvmfPkg/OvmfPkgX64.fdf | 1 + > OvmfPkg/QemuRamfbDxe/QemuRamfbDxe.inf | 34 +++ > 14 files changed, 423 insertions(+) > create mode 100644 OvmfPkg/Include/Guid/QemuRamfb.h > create mode 100644 OvmfPkg/QemuRamfbDxe/QemuRamfb.c > create mode 100644 OvmfPkg/QemuRamfbDxe/QemuRamfbDxe.inf > Some testing related questions: - What happens in the UEFI shell if you do recursive connect/disconnect cycles for all handles in the system? (Preferably initiated from serial.) - What happens if you locate the parent handle (with the VenHw node) and/or the child handle (with the GOP on it), and try to disconnect them? - Have you tested mode changes with the MODE command? Expected results: - recursive connect / disconnect should not break, as far as the entire system is concerned; the procedure should simply skip ramfb. - targeted connect / disconnect for ramfb should fail (produce an error message), but nothing should crash or stop working. - mode changes should work. I expect the first two behaviors because the driver is a platform DXE driver, not a UEFI driver that conforms to the UEFI driver model -- we don't install an EFI_DRIVER_BINDING_PROTOCOL instance, hence the driver should be "invisible" to the connect / disconnect UEFI shell commands (they should fail gracefully). Thanks, Laszlo