From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, thomas.lendacky@amd.com
Cc: Brijesh Singh <brijesh.singh@amd.com>,
Allen Wynn <Allen_Wynn@Dell.com>, Eric Dong <eric.dong@intel.com>,
Ray Ni <ray.ni@intel.com>, Rahul Kumar <rahul1.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuExceptionHandler: Add missing comma to exception name array
Date: Fri, 14 May 2021 13:04:58 +0200 [thread overview]
Message-ID: <e7da1bd0-b4e8-a48a-22bb-7234f65a241b@redhat.com> (raw)
In-Reply-To: <40e55bf6563ed8ea4962a1219efbe1ab77a56cc4.1620919615.git.thomas.lendacky@amd.com>
On 05/13/21 17:26, Lendacky, Thomas wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3373
>
> An update to expand the mExceptionNameStr array failed to add a comma
> after original last entry, therefore causing the #CP name to have extra
> incorrect characters and the remaining entries to be indexed incorrectly
> (off by 1).
>
> Add a comma after the "#CP" entry to resolve this issue.
>
> Fixes: 5277540e37e88a1a69f9517c4ad895051b4b3ed3
> Cc: Allen Wynn <Allen_Wynn@Dell.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
> index c9003b10e552..49d0041e2ff3 100644
> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
> @@ -44,7 +44,7 @@ CONST CHAR8 *mExceptionNameStr[] = {
> "#MC - Machine-Check",
> "#XM - SIMD floating-point",
> "#VE - Virtualization",
> - "#CP - Control Protection"
> + "#CP - Control Protection",
> "Reserved",
> "Reserved",
> "Reserved",
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2021-05-14 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 15:26 [PATCH] UefiCpuPkg/CpuExceptionHandler: Add missing comma to exception name array Lendacky, Thomas
2021-05-14 11:04 ` Laszlo Ersek [this message]
2021-05-14 11:27 ` [edk2-devel] " Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7da1bd0-b4e8-a48a-22bb-7234f65a241b@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox