From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web08.9162.1608216527571583318 for ; Thu, 17 Dec 2020 06:48:47 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PItP/4FA; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608216526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JdtwT5BvHzSPhE7KJuoF8nymIckIq1j3WLjH7P+S+Ug=; b=PItP/4FAGjonIhKjNNWdnV7wXFcMvkI8uH+WUeibptfH3PmLykV6a9GINaOkfjJDsHp0yO PBDRDx00GPYhaB2TN7PjSh/wtRojsPYuBMO3aflpRnoDWfWa2bp8GAoibGJEueCtQiiAR7 vHAzNyKsuWzp5cAb4d+RmTjLSu6A/n0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-259-I7OXRkZrPH-DMT2tz2rhTQ-1; Thu, 17 Dec 2020 09:48:42 -0500 X-MC-Unique: I7OXRkZrPH-DMT2tz2rhTQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C0EFB800D55; Thu, 17 Dec 2020 14:48:40 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-40.ams2.redhat.com [10.36.115.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id BBABC57; Thu, 17 Dec 2020 14:48:39 +0000 (UTC) Subject: Re: [edk2-rfc] [RFC] UnitTestFrameworkPkg cmocka submodule alternatives To: rfc@edk2.groups.io, michael.d.kinney@intel.com, "devel@edk2.groups.io" , 'Bret Barkelew' References: From: "Laszlo Ersek" Message-ID: Date: Thu, 17 Dec 2020 15:48:38 +0100 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/16/20 19:45, Michael D Kinney wrote: > Hello, > > We have had at least three incidents in the last year where the link to the > cmocka submodule in the UnitTestFrameworkPkg has not been available, and this > impacted the EDK II CI system. The following submodule link is the one that > is not reliable: > > https://git.cryptomilk.org/projects/cmocka.git > > We have identified two potential mirrors of this repo: > > https://github.com/neverware-mirrors/cmocka.git > https://gitlab.com/cmocka/cmocka.git > > The following patch provided a temporary fix for the EDK II CI agents, but > does not help other consumers of the edk2 repository. > > https://github.com/tianocore/edk2/commit/be746104d1766a8c363e74d6063144657820d688 > > I have seen one suggestion that TianoCore create its own > mirror of cmocka. This does require monitoring and maintenance > by the TianoCore community. I would prefer to use a well > maintained mirror in github as long as we do not observe any > issues with the support of that mirror. > > I propose we update the submodule in the UnitTestFrameworkPkg > to use the https://github.com/neverware-mirrors/cmocka.git mirror. > By using a mirror in github, we remove one external dependency. > > Please provide feedback and comments on this proposal. If there > are no objections, then we will proceed with a patch review for > this update. We could create our own fork under the organization. It does not require much extra maintenance or monitoring, in my opinion. We only need to advance our fork to the actual master HEAD when we intend to advance our submodule reference in edk2 as well. As long as the submodule reference in edk2 does not move, the actual master HEAD of the cmocka project may very well be ahead of our fork (mirror), without causing issues. I don't know who or what the organization is, and I'd prefer not fetching code from them automatically. Thanks Laszlo