From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5CDF6941B3B for ; Fri, 1 Mar 2024 18:56:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9tSxZvuI7IRgfSQli+t5XlF+ekmmVjqGsVRRBnIT7Xo=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709319418; v=1; b=kqeDBmDo9ECiQ4OzvYzq+Q9cQEhha3ojPm53Oj0lcCldicnOS75zdskob5Dg0QfA5V2TAXxp bKdaxynZ+u+skYErHexvQYzPtzxNdC86U0MpvKKhawKaigwgu0SuHFrKGW7PDhBzqBegoHQ7/gg KsGf3aIctdfDYI/P3+OyBEFM= X-Received: by 127.0.0.2 with SMTP id QOo9YY7687511xZ8VzQ8CNuv; Fri, 01 Mar 2024 10:56:58 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.32211.1709319417336500755 for ; Fri, 01 Mar 2024 10:56:57 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-577-Be0ys5wMM3GwPGK09BvWgA-1; Fri, 01 Mar 2024 13:56:55 -0500 X-MC-Unique: Be0ys5wMM3GwPGK09BvWgA-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A68B73C0F19F; Fri, 1 Mar 2024 18:56:54 +0000 (UTC) X-Received: from [10.39.194.215] (unknown [10.39.194.215]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E2195400D295; Fri, 1 Mar 2024 18:56:52 +0000 (UTC) Message-ID: Date: Fri, 1 Mar 2024 19:56:51 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuPageTableLib: qualify page table accesses as volatile To: devel@edk2.groups.io, jianfeng.zhou@intel.com Cc: Ray Ni , Rahul Kumar , Gerd Hoffmann , Pedro Falcato , Zhang Di , Tan Dun , Michael Brown References: <20240301025447.41170-1-jianfeng.zhou@intel.com> From: "Laszlo Ersek" In-Reply-To: <20240301025447.41170-1-jianfeng.zhou@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: zR3QU0wdGxTTaoHqdUyDSVoWx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=kqeDBmDo; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 3/1/24 03:54, Zhou Jianfeng wrote: > Add volatile qualifier to page table related variable to prevent > compiler from optimizing away the variables which may lead to > unexpected result. >=20 > Signed-off-by: Zhou Jianfeng > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Cc: Pedro Falcato > Cc: Zhang Di > Cc: Tan Dun > Cc: Michael Brown > --- > .../Library/CpuPageTableLib/CpuPageTableMap.c | 36 +++++++++---------- > 1 file changed, 18 insertions(+), 18 deletions(-) Merged as 2 dcffad2491bc UefiCpuPkg/CpuPageTableLib: qualify page table accesse= s as volatile via . Unfortunately, the patch was formatted and/or posted incorrectly; git-am co= mplained about "corrupt patch", no matter what I did about the quoted-print= able encoding. Therefore I had to manually reconstruct the patch (I noted that fact on the= commit message). Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116281): https://edk2.groups.io/g/devel/message/116281 Mute This Topic: https://groups.io/mt/104661494/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-