From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (EUR02-AM5-obe.outbound.protection.outlook.com [40.107.0.73]) by mx.groups.io with SMTP id smtpd.web08.12395.1645199428304680453 for ; Fri, 18 Feb 2022 07:50:29 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=xcfXbLJx; spf=pass (domain: arm.com, ip: 40.107.0.73, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RXeISo1HGCCEcImbpIlzlEmS97aKAC7//Y4cQDq0bDQ=; b=xcfXbLJx9BWwf7c8WK4xgI02wtnFa/VP7voNaYBHVNJZIrSVjtSHf6CuCZwJMAZgF/TcD5EFO1ypjGjPYOQFORiPYQ7bYuXSTkGxH9AP9TYeoqu03hrJ1X7RV4UJpqjN3DBcUWQEwP6vWd52i0vu6WTRGED14JhHuowpJAGlD9Q= Received: from AS8PR04CA0011.eurprd04.prod.outlook.com (2603:10a6:20b:310::16) by AM6PR08MB3189.eurprd08.prod.outlook.com (2603:10a6:209:45::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Fri, 18 Feb 2022 15:50:18 +0000 Received: from VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:310:cafe::6c) by AS8PR04CA0011.outlook.office365.com (2603:10a6:20b:310::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.22 via Frontend Transport; Fri, 18 Feb 2022 15:50:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT037.mail.protection.outlook.com (10.152.19.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.20 via Frontend Transport; Fri, 18 Feb 2022 15:50:17 +0000 Received: ("Tessian outbound 31aeb3346a45:v113"); Fri, 18 Feb 2022 15:50:17 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a1398d79c0177f60 X-CR-MTA-TID: 64aa7808 Received: from 221f426c1ec1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2D898619-5117-47D5-864A-2DD4AF242B2F.1; Fri, 18 Feb 2022 15:50:10 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 221f426c1ec1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Feb 2022 15:50:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AhjAQQPUE9hsbizcfkd6MNaopmAj1MEEOl8Q4HyoDJ3z+pD+AhejxU/dABdgudXvwXl1NTX37I1541UuG6b7NJ1H3PtK1l3zrjLzcgoV7ZGvUxhu/weaPVYQeepRqvxHaH9vLIl+Say9VmwJNBMIZWdIjOEWV5FZ3MC2vcq82Gh8v77JloRr61nOcwBQERoOJAd+sT+PxEqALpcICgG04axq3GjBOEC0INx7fFjGWUKJHNp6kCuT3tp6lbBVZhX4qKeMxN/uy2p7A+cdShmjn4MJhKohWNgZ5UU4dA7YKk6UBN47YuQBdzpjJqiai31eC698X9nRG0tAq+luidnt+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RXeISo1HGCCEcImbpIlzlEmS97aKAC7//Y4cQDq0bDQ=; b=jzYQJele1XpOOeo2fDnJIFo2lpA1jRQr9/s6y64DoDhMNmmfnb4aQ07nZnWVrzec9ohBfvRD6p+7IlFPCV3Rx+872c9aPU1/staHk+Ax0dpZIS1nNpT4+JBGaLoJZF9rAwfGhs6meGSa8fIqkAeadUh9u14lf2sLExDezhz1PE+c44NuSb9/GAkFr4Daluj7HPTkvxVoeKymTL0z62yDQiG3CrYUUlgMFMxuk6R/4fuuxfj5tCyJlGgLF5mRK1fyp9RCFyf6x20P1qdr7Z5oZ847tzLO1QXiU02okVyL6MyV1/k8PRg9Eu3VcWwh0xRnkKL6DT0l+HiTVnXus5JunQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RXeISo1HGCCEcImbpIlzlEmS97aKAC7//Y4cQDq0bDQ=; b=xcfXbLJx9BWwf7c8WK4xgI02wtnFa/VP7voNaYBHVNJZIrSVjtSHf6CuCZwJMAZgF/TcD5EFO1ypjGjPYOQFORiPYQ7bYuXSTkGxH9AP9TYeoqu03hrJ1X7RV4UJpqjN3DBcUWQEwP6vWd52i0vu6WTRGED14JhHuowpJAGlD9Q= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB3574.eurprd08.prod.outlook.com (2603:10a6:20b:4e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 18 Feb 2022 15:50:08 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::34b6:4579:9e43:6b95]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::34b6:4579:9e43:6b95%7]) with mapi id 15.20.4975.019; Fri, 18 Feb 2022 15:50:08 +0000 Subject: Re: [PATCH v5 2/2] ShellPkg/AcpiView: PrintFormatter for FADT Flags field To: Abdul Lateef Attar , devel@edk2.groups.io Cc: Ray Ni , Zhichao Gao , nd References: <20220216111355.9801-1-abdattar@amd.com> <20220216111355.9801-3-abdattar@amd.com> From: "Sami Mujawar" Message-ID: Date: Fri, 18 Feb 2022 15:50:05 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20220216111355.9801-3-abdattar@amd.com> X-ClientProxiedBy: LO4P123CA0143.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:193::22) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 553b8338-373d-45cb-98a5-08d9f2f65c7f X-MS-TrafficTypeDiagnostic: AM6PR08MB3574:EE_|VE1EUR03FT037:EE_|AM6PR08MB3189:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:7219;OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zfUrwA+ZJiHNwlYNaaJSgqPBAVUs9H3vKJ6zEoGZxZCT2Ne/KBI1UFgkg7kmVZ266ZO80DqvWaWM41SDfUebyHK/wO9yKYi2hjmRdnC2D1DI3OePsULfdSiJK9HJCFIehEEVFm+27e0f0jyjxV5jyeQ6uJ9P5F+izzGrJB/Gk9XQkA3LhaVCHTy2yfZ9NN+WCWbEKaJEBu9FTxmmvW/2ac/IqOCm5KDWb29K5wK+09AyJGx5Aez8pWtB78VoLMRoiinRAzcnyTKsSssjS+bcr1LDFnxYpOh5SojCYjp5EXMZKREyJMzi4y7m2SklnKDJpaUxUttiGFhZJkqZVHewxeK8YML1am9KC9WZ3wQRvk2tdvJ++W10gyeyiuyPyV4cnjCmtJ9vhG9rbbZXwqh6Ce/I6uNrvvS4Zlm6ww5lvx9oLGBjr+MIBlTHU1I3p2sGY0fepVvKT1aVxj6fyLaKz3tmB2nYSBiS/w9eqi3tTFgVQZtqBYeasS4w0b8gwe0HRj9F/Xlf8nmz0gzsNVkQtTUE+bjndJHM6YukJyqfWA0oU/hCKUjKpr3ILGgGcA3S3ENNSljYXYRqhCz4zoqpW1eRd2w4yRvoE4fezpCCfhg/riE9CY3MqWKN6R+CJMG+XoWh0OtHsItqE/TLaziw3KZcvx3REisP7WlmAa0KaC8D7HOjC9lnxY0foXtPgJJ9W9ToSMC802py+BqvLhIwo3IhVlgku0zispSPppZrB/HY1CQuAX8cW+fHd5g7pGGq6coLAgmvcFaP+nPLZ3Iuux5nLKrDPcQJIuz6JfFPHAc57Lm10hZnRVJPVhEYN3vekytEkDtseYGbvwLzWrk15C87cxd9mFuHO/HLsi6jseI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(44832011)(66946007)(52116002)(66476007)(31686004)(2906002)(6666004)(508600001)(966005)(6486002)(31696002)(86362001)(36756003)(6512007)(54906003)(2616005)(316002)(26005)(38350700002)(38100700002)(83380400001)(186003)(8936002)(5660300002)(30864003)(66556008)(4326008)(8676002)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3574 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3b43af4d-9ffa-4bfe-b058-08d9f2f6568d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gNOTkBKmgQ4ZWf/yL1p/HPGBFrc7hU0p7PUd+AwqGgennjzMD5DRJE17c0VDC9CGyhFsLR4HStY11bo1W329w9O+1G5uiJ1AW6z1zk10uit9t7S43mGz9DfeIDpBRmOAaOM3XamUBh2Sy/KEp2Vs0az5eHRbQCanofeKBeoo++QoiF6u6aOJ0J+XBBnsdac40V9dEaDUDMCBOk38eUi+GOuDqatA0nKz3x1VyRa7VrcWGS/NHPsw7Bt77Z26NAgCqJIKUqP133/04nORmJ8vXA8pCZBtOBuiqaDmuffi4y9GDRTp66bZhQN46qjopZxcq+VJOMQ4ilTNAELQkms40lhVWB4No52E049wxHOiHzQCXV8Uza+GQS5loQ7jR6lObm15K/K//S5rnrDsAxfb2qDHnGxlmBnjFyPp6kAkSluJFSPE3Dvwji3v3bqKgbbd4lLCMoc+LhFQUNAzQGMKoZQUe5NerSb7hbxMai5AoD4T1CA869UVNTQRNTeTq8AzLLyE/vpI4hQoPeof6cG+Fq8cfhUxDIRZwsreZVirRDGWy0N4ZcUIh0zj4OWqDZCVl8HmC8IX9JDnDg7q1nxAipLzYd51d6WQrJwZ2t5yY5E08IKMWSHz/By4roIb+86gRU/yWHZOwwQFtJXkTzDQGxpTQ9hYm2Ec51qVKRX47zocZYvYkBZ+tqbq3x8J4bfAC0LgFrRG53P0q4/Xqydmx4sglowJzRLXPIUZWSNZLeMPYTGGAEEg/Hbdn6C4+VJe0Ie7+JDvIZDLtgRa2BUHg94mTeQ+2/WQWc7Cummyrto= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(36860700001)(53546011)(6512007)(6506007)(82310400004)(966005)(6486002)(8936002)(6666004)(2906002)(86362001)(31696002)(81166007)(356005)(336012)(508600001)(5660300002)(47076005)(83380400001)(4326008)(8676002)(2616005)(70206006)(70586007)(316002)(186003)(26005)(40460700003)(54906003)(36756003)(44832011)(30864003)(31686004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 15:50:17.5816 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 553b8338-373d-45cb-98a5-08d9f2f65c7f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3189 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Abdul, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/02/2022 11:13 AM, Abdul Lateef Attar wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3839 > > Adds PrintFormatter function to the FADT flags field. > Prints indivisual flag name along with flag value. > > Cc: Ray Ni > Cc: Zhichao Gao > Cc: Sami Mujawar > Signed-off-by: Abdul Lateef Attar > --- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 167 +++++++++++++------- > 1 file changed, 112 insertions(+), 55 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > index f8fbb4bcb8e9..abc58d65520e 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > @@ -2,6 +2,7 @@ > FADT table parser > > > > Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. > > + Copyright (c) 2022, AMD Incorporated. All rights reserved. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @par Reference(s): > > @@ -130,69 +131,125 @@ ValidateFlags ( > #endif > > } > > > > +STATIC CONST ACPI_PARSER FadtFlagParser[] = { > > + { L"WBINVD", 1, 0, L"%d", NULL, NULL, NULL, NULL }, > > + { L"WBINVD_FLUSH", 1, 1, L"%d", NULL, NULL, NULL, NULL }, > > + { L"PROC_C1", 1, 2, L"%d", NULL, NULL, NULL, NULL }, > > + { L"P_LVL2_UP", 1, 3, L"%d", NULL, NULL, NULL, NULL }, > > + { L"PWR_BUTTON", 1, 4, L"%d", NULL, NULL, NULL, NULL }, > > + { L"SLP_BUTTON", 1, 5, L"%d", NULL, NULL, NULL, NULL }, > > + { L"FIX_RTC", 1, 6, L"%d", NULL, NULL, NULL, NULL }, > > + { L"RTC_S4", 1, 7, L"%d", NULL, NULL, NULL, NULL }, > > + { L"TMR_VAL_EXT", 1, 8, L"%d", NULL, NULL, NULL, NULL }, > > + { L"DCK_CAP", 1, 9, L"%d", NULL, NULL, NULL, NULL }, > > + { L"RESET_REG_SUP", 1, 10, L"%d", NULL, NULL, NULL, NULL }, > > + { L"SEALED_CASE", 1, 11, L"%d", NULL, NULL, NULL, NULL }, > > + { L"HEADLESS", 1, 12, L"%d", NULL, NULL, NULL, NULL }, > > + { L"CPU_SW_SLP", 1, 13, L"%d", NULL, NULL, NULL, NULL }, > > + { L"PCI_EXP_WAK", 1, 14, L"%d", NULL, NULL, NULL, NULL }, > > + { L"USE_PLATFORM_CLOCK", 1, 15, L"%d", NULL, NULL, NULL, NULL }, > > + { L"S4_RTC_STS_VALID", 1, 16, L"%d", NULL, NULL, NULL, NULL }, > > + { L"REMOTE_POWER_ON_CAPABLE", 1, 17, L"%d", NULL, NULL, NULL, NULL }, > > + { L"FORCE_APIC_CLUSTER_MODEL", 1, 18, L"%d", NULL, NULL, NULL, NULL }, > > + { L"FORCE_APIC_PHYSICAL_DESTINATION_MODE", 1, 19, L"%d", NULL, NULL, NULL, NULL }, > > + { L"HW_REDUCED_ACPI", 1, 20, L"%d", NULL, NULL, NULL, NULL }, > > + { L"LOW_POWER_S0_IDLE_CAPABLE", 1, 21, L"%d", NULL, NULL, NULL, NULL }, > > + { L"Reserved", 10, 22, L"%d", NULL, NULL, NULL, NULL } > > +}; > > + > > +/** > > + This function traces FADT Flags fields. > > + If no format string is specified the Format must be NULL. > > + > > + @param [in] Format Optional format string for tracing the data. > > + @param [in] Ptr Pointer to the start of the buffer. > > +**/ > > +VOID > > +EFIAPI > > +DumpFadtFlags ( > > + IN CONST CHAR16 *Format OPTIONAL, > > + IN UINT8 *Ptr > > + ) > > +{ > > + if (Format != NULL) { > > + Print (Format, *(UINT32 *)Ptr); > > + return; > > + } > > + > > + Print (L"0x%X\n", *(UINT32 *)Ptr); > > + ParseAcpiBitFields ( > > + TRUE, > > + 2, > > + NULL, > > + Ptr, > > + 4, > > + PARSER_PARAMS (FadtFlagParser) > > + ); > > +} > > + > > /** > > An ACPI_PARSER array describing the ACPI FADT Table. > > **/ > > STATIC CONST ACPI_PARSER FadtParser[] = { > > PARSE_ACPI_HEADER (&AcpiHdrInfo), > > - { L"FIRMWARE_CTRL", 4, 36, L"0x%x", NULL, (VOID **)&FirmwareCtrl, > > + { L"FIRMWARE_CTRL", 4, 36, L"0x%x", NULL, (VOID **)&FirmwareCtrl, > > ValidateFirmwareCtrl, NULL }, > > - { L"DSDT", 4, 40, L"0x%x", NULL, (VOID **)&DsdtAddress, NULL, NULL }, > > - { L"Reserved", 1, 44, L"%x", NULL, NULL, NULL, NULL }, > > - { L"Preferred_PM_Profile", 1, 45, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"SCI_INT", 2, 46, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"SMI_CMD", 4, 48, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"ACPI_ENABLE", 1, 52, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"ACPI_DISABLE", 1, 53, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"S4BIOS_REQ", 1, 54, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PSTATE_CNT", 1, 55, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM1a_EVT_BLK", 4, 56, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM1b_EVT_BLK", 4, 60, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM1a_CNT_BLK", 4, 64, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM1b_CNT_BLK", 4, 68, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM2_CNT_BLK", 4, 72, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM_TMR_BLK", 4, 76, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"GPE0_BLK", 4, 80, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"GPE1_BLK", 4, 84, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM1_EVT_LEN", 1, 88, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM1_CNT_LEN", 1, 89, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM2_CNT_LEN", 1, 90, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM_TMR_LEN", 1, 91, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"GPE0_BLK_LEN", 1, 92, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"GPE1_BLK_LEN", 1, 93, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"GPE1_BASE", 1, 94, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"CST_CNT", 1, 95, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"P_LVL2_LAT", 2, 96, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"P_LVL3_LAT", 2, 98, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"FLUSH_SIZE", 2, 100, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"FLUSH_STRIDE", 2, 102, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"DUTY_OFFSET", 1, 104, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"DUTY_WIDTH", 1, 105, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"DAY_ALRM", 1, 106, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"MON_ALRM", 1, 107, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"CENTURY", 1, 108, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"IAPC_BOOT_ARCH", 2, 109, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"Reserved", 1, 111, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"Flags", 4, 112, L"0x%x", NULL, (VOID **)&Flags, ValidateFlags, NULL }, > > - { L"RESET_REG", 12, 116, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"RESET_VALUE", 1, 128, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"ARM_BOOT_ARCH", 2, 129, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"FADT Minor Version", 1, 131, L"0x%x", NULL, (VOID **)&FadtMinorRevision, > > + { L"DSDT", 4, 40, L"0x%x", NULL, (VOID **)&DsdtAddress, NULL, NULL }, > > + { L"Reserved", 1, 44, L"%x", NULL, NULL, NULL, NULL }, > > + { L"Preferred_PM_Profile", 1, 45, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"SCI_INT", 2, 46, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"SMI_CMD", 4, 48, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"ACPI_ENABLE", 1, 52, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"ACPI_DISABLE", 1, 53, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"S4BIOS_REQ", 1, 54, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PSTATE_CNT", 1, 55, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM1a_EVT_BLK", 4, 56, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM1b_EVT_BLK", 4, 60, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM1a_CNT_BLK", 4, 64, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM1b_CNT_BLK", 4, 68, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM2_CNT_BLK", 4, 72, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM_TMR_BLK", 4, 76, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"GPE0_BLK", 4, 80, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"GPE1_BLK", 4, 84, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM1_EVT_LEN", 1, 88, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM1_CNT_LEN", 1, 89, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM2_CNT_LEN", 1, 90, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM_TMR_LEN", 1, 91, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"GPE0_BLK_LEN", 1, 92, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"GPE1_BLK_LEN", 1, 93, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"GPE1_BASE", 1, 94, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"CST_CNT", 1, 95, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"P_LVL2_LAT", 2, 96, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"P_LVL3_LAT", 2, 98, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"FLUSH_SIZE", 2, 100, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"FLUSH_STRIDE", 2, 102, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"DUTY_OFFSET", 1, 104, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"DUTY_WIDTH", 1, 105, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"DAY_ALRM", 1, 106, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"MON_ALRM", 1, 107, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"CENTURY", 1, 108, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"IAPC_BOOT_ARCH", 2, 109, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"Reserved", 1, 111, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"Flags", 4, 112, NULL, DumpFadtFlags, (VOID **)&Flags, ValidateFlags, NULL }, > > + { L"RESET_REG", 12, 116, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"RESET_VALUE", 1, 128, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"ARM_BOOT_ARCH", 2, 129, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"FADT Minor Version", 1, 131, L"0x%x", NULL, (VOID **)&FadtMinorRevision, > > NULL, NULL }, > > - { L"X_FIRMWARE_CTRL", 8, 132, L"0x%lx", NULL, (VOID **)&X_FirmwareCtrl, > > + { L"X_FIRMWARE_CTRL", 8, 132, L"0x%lx", NULL, (VOID **)&X_FirmwareCtrl, > > ValidateXFirmwareCtrl, NULL }, > > - { L"X_DSDT", 8, 140, L"0x%lx", NULL, (VOID **)&X_DsdtAddress, NULL, NULL }, > > - { L"X_PM1a_EVT_BLK", 12, 148, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"X_PM1b_EVT_BLK", 12, 160, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"X_PM1a_CNT_BLK", 12, 172, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"X_PM1b_CNT_BLK", 12, 184, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"X_PM2_CNT_BLK", 12, 196, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"X_PM_TMR_BLK", 12, 208, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"X_GPE0_BLK", 12, 220, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"X_GPE1_BLK", 12, 232, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"SLEEP_CONTROL_REG", 12, 244, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"SLEEP_STATUS_REG", 12, 256, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"Hypervisor VendorIdentity", 8, 268, L"%lx", NULL, NULL, NULL, NULL } > > + { L"X_DSDT", 8, 140, L"0x%lx", NULL, (VOID **)&X_DsdtAddress, NULL, NULL }, > > + { L"X_PM1a_EVT_BLK", 12, 148, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"X_PM1b_EVT_BLK", 12, 160, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"X_PM1a_CNT_BLK", 12, 172, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"X_PM1b_CNT_BLK", 12, 184, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"X_PM2_CNT_BLK", 12, 196, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"X_PM_TMR_BLK", 12, 208, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"X_GPE0_BLK", 12, 220, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"X_GPE1_BLK", 12, 232, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"SLEEP_CONTROL_REG", 12, 244, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"SLEEP_STATUS_REG", 12, 256, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"Hypervisor VendorIdentity", 8, 268, L"%lx", NULL, NULL, NULL, NULL } > > }; > > > > /** >